[INFO] crate message_bus 0.1.0 is already in cache [INFO] extracting crate message_bus 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/message_bus/0.1.0 [INFO] extracting crate message_bus 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/message_bus/0.1.0 [INFO] validating manifest of message_bus-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of message_bus-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing message_bus-0.1.0 [INFO] finished frobbing message_bus-0.1.0 [INFO] frobbed toml for message_bus-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/message_bus/0.1.0/Cargo.toml [INFO] started frobbing message_bus-0.1.0 [INFO] finished frobbing message_bus-0.1.0 [INFO] frobbed toml for message_bus-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/message_bus/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting message_bus-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/message_bus/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd226a913b7c9ce94a3b17b76a1ff3dcacb339baaab9f0bf3e821b1fcf444777 [INFO] running `"docker" "start" "-a" "dd226a913b7c9ce94a3b17b76a1ff3dcacb339baaab9f0bf3e821b1fcf444777"` [INFO] [stderr] Checking message_bus v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message_bus.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message_bus.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | time: time [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message_bus.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message_bus.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | time: time [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_bus.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return Bus { [INFO] [stderr] 27 | | sender: itx, [INFO] [stderr] 28 | | input_receiver: irx, [INFO] [stderr] 29 | | [INFO] [stderr] ... | [INFO] [stderr] 69 | | ] [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | Bus { [INFO] [stderr] 27 | sender: itx, [INFO] [stderr] 28 | input_receiver: irx, [INFO] [stderr] 29 | [INFO] [stderr] 30 | output_sender: otx, [INFO] [stderr] 31 | receiver: orx, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_bus.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return (offset.next_power_of_two().trailing_zeros()) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(offset.next_power_of_two().trailing_zeros()) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_bus.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / return Message { [INFO] [stderr] 131 | | message: message, [INFO] [stderr] 132 | | time: time [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Message { [INFO] [stderr] 131 | message: message, [INFO] [stderr] 132 | time: time [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_bus.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return Bus { [INFO] [stderr] 27 | | sender: itx, [INFO] [stderr] 28 | | input_receiver: irx, [INFO] [stderr] 29 | | [INFO] [stderr] ... | [INFO] [stderr] 69 | | ] [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | Bus { [INFO] [stderr] 27 | sender: itx, [INFO] [stderr] 28 | input_receiver: irx, [INFO] [stderr] 29 | [INFO] [stderr] 30 | output_sender: otx, [INFO] [stderr] 31 | receiver: orx, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_bus.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return (offset.next_power_of_two().trailing_zeros()) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(offset.next_power_of_two().trailing_zeros()) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_bus.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / return Message { [INFO] [stderr] 131 | | message: message, [INFO] [stderr] 132 | | time: time [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | Message { [INFO] [stderr] 131 | message: message, [INFO] [stderr] 132 | time: time [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message_bus::Bus` [INFO] [stderr] --> src/message_bus.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Bus { [INFO] [stderr] 20 | | //Input channel [INFO] [stderr] 21 | | let (itx, irx) = mpsc::channel(); [INFO] [stderr] 22 | | [INFO] [stderr] ... | [INFO] [stderr] 70 | | }; [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for message_bus::Bus { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/message_bus.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / loop { [INFO] [stderr] 76 | | match self.input_receiver.try_recv() { [INFO] [stderr] 77 | | Ok(v) => { [INFO] [stderr] 78 | | if v.time <= time { [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(v) = self.input_receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message_bus::Bus` [INFO] [stderr] --> src/message_bus.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Bus { [INFO] [stderr] 20 | | //Input channel [INFO] [stderr] 21 | | let (itx, irx) = mpsc::channel(); [INFO] [stderr] 22 | | [INFO] [stderr] ... | [INFO] [stderr] 70 | | }; [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for message_bus::Bus { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/message_bus.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / loop { [INFO] [stderr] 170 | | match bus.receiver.try_recv() { [INFO] [stderr] 171 | | Ok(v) => { assert_eq!(v, i); }, [INFO] [stderr] 172 | | Err(_) => { break; } [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(v) = bus.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/message_bus.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / loop { [INFO] [stderr] 76 | | match self.input_receiver.try_recv() { [INFO] [stderr] 77 | | Ok(v) => { [INFO] [stderr] 78 | | if v.time <= time { [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(v) = self.input_receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / loop { [INFO] [stderr] 24 | | match bus.receiver.try_recv() { [INFO] [stderr] 25 | | Ok(v) => { println!("m{0} @ t{1}", v, time); }, [INFO] [stderr] 26 | | Err(_) => { break; } [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(v) = bus.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / loop { [INFO] [stderr] 24 | | match bus.receiver.try_recv() { [INFO] [stderr] 25 | | Ok(v) => { println!("m{0} @ t{1}", v, time); }, [INFO] [stderr] 26 | | Err(_) => { break; } [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(v) = bus.receiver.try_recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "dd226a913b7c9ce94a3b17b76a1ff3dcacb339baaab9f0bf3e821b1fcf444777"` [INFO] running `"docker" "rm" "-f" "dd226a913b7c9ce94a3b17b76a1ff3dcacb339baaab9f0bf3e821b1fcf444777"` [INFO] [stdout] dd226a913b7c9ce94a3b17b76a1ff3dcacb339baaab9f0bf3e821b1fcf444777