[INFO] crate menu 0.2.1 is already in cache [INFO] extracting crate menu 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/menu/0.2.1 [INFO] extracting crate menu 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/menu/0.2.1 [INFO] validating manifest of menu-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of menu-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing menu-0.2.1 [INFO] finished frobbing menu-0.2.1 [INFO] frobbed toml for menu-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/menu/0.2.1/Cargo.toml [INFO] started frobbing menu-0.2.1 [INFO] finished frobbing menu-0.2.1 [INFO] frobbed toml for menu-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/menu/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting menu-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/menu/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa2808adc2a571e0e34dc2039fcb9be8263648f6485a2e413d80647b342b4ed8 [INFO] running `"docker" "start" "-a" "fa2808adc2a571e0e34dc2039fcb9be8263648f6485a2e413d80647b342b4ed8"` [INFO] [stderr] Checking menu v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | write!(self.context, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | write!(self.context, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | write!(self.context, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | write!(self.context, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:175:32 [INFO] [stderr] | [INFO] [stderr] 175 | let valid = if let Ok(_) = core::str::from_utf8(&self.buffer[0..self.used]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 176 | | true [INFO] [stderr] 177 | | } else { [INFO] [stderr] 178 | | false [INFO] [stderr] 179 | | }; [INFO] [stderr] | |_____________- help: try this: `if core::str::from_utf8(&self.buffer[0..self.used]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:175:32 [INFO] [stderr] | [INFO] [stderr] 175 | let valid = if let Ok(_) = core::str::from_utf8(&self.buffer[0..self.used]) { [INFO] [stderr] | _________________________- ^^^^^ [INFO] [stderr] 176 | | true [INFO] [stderr] 177 | | } else { [INFO] [stderr] 178 | | false [INFO] [stderr] 179 | | }; [INFO] [stderr] | |_____________- help: try this: `if core::str::from_utf8(&self.buffer[0..self.used]).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> examples/simple.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(_) = io::stdin().read(&mut ch) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 69 | | // Fix newlines [INFO] [stderr] 70 | | if ch[0] == 0x0A { [INFO] [stderr] 71 | | ch[0] = 0x0D; [INFO] [stderr] ... | [INFO] [stderr] 74 | | r.input_byte(ch[0]); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________- help: try this: `if io::stdin().read(&mut ch).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/simple.rs:87:15 [INFO] [stderr] | [INFO] [stderr] 87 | fn select_foo<'a>(_menu: &Menu, _item: &Item, input: &str, _context: &mut Output) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/simple.rs:91:15 [INFO] [stderr] | [INFO] [stderr] 91 | fn select_bar<'a>(_menu: &Menu, _item: &Item, input: &str, _context: &mut Output) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/simple.rs:103:15 [INFO] [stderr] | [INFO] [stderr] 103 | fn select_baz<'a>(_menu: &Menu, _item: &Item, input: &str, _context: &mut Output) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> examples/simple.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | fn select_quux<'a>(_menu: &Menu, _item: &Item, input: &str, _context: &mut Output) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "fa2808adc2a571e0e34dc2039fcb9be8263648f6485a2e413d80647b342b4ed8"` [INFO] running `"docker" "rm" "-f" "fa2808adc2a571e0e34dc2039fcb9be8263648f6485a2e413d80647b342b4ed8"` [INFO] [stdout] fa2808adc2a571e0e34dc2039fcb9be8263648f6485a2e413d80647b342b4ed8