[INFO] crate mars 0.0.0 is already in cache [INFO] extracting crate mars 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/mars/0.0.0 [INFO] extracting crate mars 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mars/0.0.0 [INFO] validating manifest of mars-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mars-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mars-0.0.0 [INFO] finished frobbing mars-0.0.0 [INFO] frobbed toml for mars-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/mars/0.0.0/Cargo.toml [INFO] started frobbing mars-0.0.0 [INFO] finished frobbing mars-0.0.0 [INFO] frobbed toml for mars-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mars/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mars-0.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mars/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2824b8e007b04bada040600b6a4e2a4bdef37dc6f0be1efeeb9d74dd2acfa3ff [INFO] running `"docker" "start" "-a" "2824b8e007b04bada040600b6a4e2a4bdef37dc6f0be1efeeb9d74dd2acfa3ff"` [INFO] [stderr] Checking mars v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/mars/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/mars/mod.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | rpa = self.fold((rpa + self.core[((self.pc + rpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/mars/mod.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | wpa = self.fold((wpa + self.core[((self.pc + wpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::PartialEq` [INFO] [stderr] --> src/mars/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::cmp::PartialEq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/mars/mod.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | rpa = self.fold((rpa + self.core[((self.pc + rpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/mars/mod.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | wpa = self.fold((wpa + self.core[((self.pc + wpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ira` [INFO] [stderr] --> src/mars/mod.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | let ira: Instruction; [INFO] [stderr] | ^^^ help: consider using `_ira` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `irb` [INFO] [stderr] --> src/mars/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | let irb: Instruction; [INFO] [stderr] | ^^^ help: consider using `_irb` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rpb` [INFO] [stderr] --> src/mars/mod.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let rpb: Address; [INFO] [stderr] | ^^^ help: consider using `_rpb` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wpb` [INFO] [stderr] --> src/mars/mod.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | let wpb: Address; [INFO] [stderr] | ^^^ help: consider using `_wpb` instead [INFO] [stderr] [INFO] [stderr] warning: variable `pip` is assigned to, but never used [INFO] [stderr] --> src/mars/mod.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let pip: Address; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_pip` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `rpa` is never read [INFO] [stderr] --> src/mars/mod.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | rpa = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `wpa` is never read [INFO] [stderr] --> src/mars/mod.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | wpa = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pip` is never read [INFO] [stderr] --> src/mars/mod.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | pip = (self.pc + wpa) % self.core_size; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `rpa` is never read [INFO] [stderr] --> src/mars/mod.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | rpa = self.fold((rpa + self.core[((self.pc + rpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `wpa` is never read [INFO] [stderr] --> src/mars/mod.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | wpa = self.fold((wpa + self.core[((self.pc + wpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mars/mod.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / fn index<'a>(&'a self, _index: Address) -> &'a Instruction { [INFO] [stderr] 121 | | &self.0[_index as usize] [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mars/mod.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / fn index_mut<'a>(&'a mut self, _index: Address) -> &'a mut Instruction { [INFO] [stderr] 127 | | &mut self.0[_index as usize] [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mars::CoreBuilder` [INFO] [stderr] --> src/mars/mod.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn new() -> Self { [INFO] [stderr] 217 | | CoreBuilder { [INFO] [stderr] 218 | | core_size: 8192, [INFO] [stderr] 219 | | initial_instruction: InitialInstruction::Default, [INFO] [stderr] 220 | | task_limit: 64, [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | impl Default for mars::CoreBuilder { [INFO] [stderr] 216 | fn default() -> Self { [INFO] [stderr] 217 | Self::new() [INFO] [stderr] 218 | } [INFO] [stderr] 219 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ira` [INFO] [stderr] --> src/mars/mod.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | let ira: Instruction; [INFO] [stderr] | ^^^ help: consider using `_ira` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `irb` [INFO] [stderr] --> src/mars/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | let irb: Instruction; [INFO] [stderr] | ^^^ help: consider using `_irb` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rpb` [INFO] [stderr] --> src/mars/mod.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let rpb: Address; [INFO] [stderr] | ^^^ help: consider using `_rpb` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `wpb` [INFO] [stderr] --> src/mars/mod.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | let wpb: Address; [INFO] [stderr] | ^^^ help: consider using `_wpb` instead [INFO] [stderr] [INFO] [stderr] warning: variable `pip` is assigned to, but never used [INFO] [stderr] --> src/mars/mod.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let pip: Address; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_pip` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `rpa` is never read [INFO] [stderr] --> src/mars/mod.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | rpa = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `wpa` is never read [INFO] [stderr] --> src/mars/mod.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | wpa = 0; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pip` is never read [INFO] [stderr] --> src/mars/mod.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | pip = (self.pc + wpa) % self.core_size; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `rpa` is never read [INFO] [stderr] --> src/mars/mod.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | rpa = self.fold((rpa + self.core[((self.pc + rpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `wpa` is never read [INFO] [stderr] --> src/mars/mod.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | wpa = self.fold((wpa + self.core[((self.pc + wpa) % self.core_size)].b_number), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mars/mod.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / fn index<'a>(&'a self, _index: Address) -> &'a Instruction { [INFO] [stderr] 121 | | &self.0[_index as usize] [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mars/mod.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / fn index_mut<'a>(&'a mut self, _index: Address) -> &'a mut Instruction { [INFO] [stderr] 127 | | &mut self.0[_index as usize] [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mars::CoreBuilder` [INFO] [stderr] --> src/mars/mod.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn new() -> Self { [INFO] [stderr] 217 | | CoreBuilder { [INFO] [stderr] 218 | | core_size: 8192, [INFO] [stderr] 219 | | initial_instruction: InitialInstruction::Default, [INFO] [stderr] 220 | | task_limit: 64, [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | impl Default for mars::CoreBuilder { [INFO] [stderr] 216 | fn default() -> Self { [INFO] [stderr] 217 | Self::new() [INFO] [stderr] 218 | } [INFO] [stderr] 219 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.38s [INFO] running `"docker" "inspect" "2824b8e007b04bada040600b6a4e2a4bdef37dc6f0be1efeeb9d74dd2acfa3ff"` [INFO] running `"docker" "rm" "-f" "2824b8e007b04bada040600b6a4e2a4bdef37dc6f0be1efeeb9d74dd2acfa3ff"` [INFO] [stdout] 2824b8e007b04bada040600b6a4e2a4bdef37dc6f0be1efeeb9d74dd2acfa3ff