[INFO] crate maplit 1.0.1 is already in cache [INFO] extracting crate maplit 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/maplit/1.0.1 [INFO] extracting crate maplit 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maplit/1.0.1 [INFO] validating manifest of maplit-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maplit-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maplit-1.0.1 [INFO] finished frobbing maplit-1.0.1 [INFO] frobbed toml for maplit-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/maplit/1.0.1/Cargo.toml [INFO] started frobbing maplit-1.0.1 [INFO] finished frobbing maplit-1.0.1 [INFO] frobbed toml for maplit-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maplit/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maplit-1.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maplit/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ba59e2a368413f7e859a0a36668c27d0064791e0700b0117d28e1831b9fc0a9 [INFO] running `"docker" "start" "-a" "0ba59e2a368413f7e859a0a36668c27d0064791e0700b0117d28e1831b9fc0a9"` [INFO] [stderr] Checking maplit v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 266 | let empty: HashMap = hashmap!{}; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | let mut _map = ::std::collections::HashMap::with_capacity(_cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 266 | let empty: HashMap = hashmap!{}; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 315 | let empty: BTreeMap = btreemap!{}; [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let mut _map = ::std::collections::BTreeMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 315 | let empty: BTreeMap = btreemap!{}; [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> tests/tests.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | hashmap!{{1 + 2} => 1, (1 + 3) => {0 + 2}}; [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> tests/tests.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | hashset!{{1 + 1}, (2 + 1)}; [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2` [INFO] [stderr] --> tests/tests.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | hashmap!{{1 + 2} => 1, (1 + 3) => {0 + 2}}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "0ba59e2a368413f7e859a0a36668c27d0064791e0700b0117d28e1831b9fc0a9"` [INFO] running `"docker" "rm" "-f" "0ba59e2a368413f7e859a0a36668c27d0064791e0700b0117d28e1831b9fc0a9"` [INFO] [stdout] 0ba59e2a368413f7e859a0a36668c27d0064791e0700b0117d28e1831b9fc0a9