[INFO] crate magnetic 2.0.0 is already in cache [INFO] extracting crate magnetic 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/magnetic/2.0.0 [INFO] extracting crate magnetic 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/magnetic/2.0.0 [INFO] validating manifest of magnetic-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of magnetic-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing magnetic-2.0.0 [INFO] finished frobbing magnetic-2.0.0 [INFO] frobbed toml for magnetic-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/magnetic/2.0.0/Cargo.toml [INFO] started frobbing magnetic-2.0.0 [INFO] finished frobbing magnetic-2.0.0 [INFO] frobbed toml for magnetic-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/magnetic/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting magnetic-2.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/magnetic/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0242785943a975c2589d42d861229991701505547d49dd4aee977219c4eba767 [INFO] running `"docker" "start" "-a" "0242785943a975c2589d42d861229991701505547d49dd4aee977219c4eba767"` [INFO] [stderr] Checking magnetic v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/dynamic.rs:18:48 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(DynamicBuffer{ptr: alloc(size), size: size}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spsc.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spsc.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | SPSCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpsc.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpsc.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | MPSCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | SPMCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpmc.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpmc.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | MPMCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer/dynamic.rs:18:48 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(DynamicBuffer{ptr: alloc(size), size: size}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spsc.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spsc.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | SPSCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpsc.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpsc.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | MPSCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spmc.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | SPMCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpmc.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpmc.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | MPMCConsumer { queue: queue }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spsc.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spsc.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpsc.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 129 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 130 | | return Err(TryPushError::Full(value)) [INFO] [stderr] 131 | | } else { [INFO] [stderr] 132 | | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 129 | return Err(TryPushError::Full(value)) [INFO] [stderr] 130 | } else { [INFO] [stderr] 131 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spmc.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spmc.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/spmc.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 159 | | if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 160 | | let v = buf_read(&q.buf, tail); [INFO] [stderr] 161 | | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 158 | } else if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 159 | let v = buf_read(&q.buf, tail); [INFO] [stderr] 160 | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] 161 | Ok(v) [INFO] [stderr] 162 | } else { [INFO] [stderr] 163 | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/spmc.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 164 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 165 | | Err(TryPopError::Empty) [INFO] [stderr] 166 | | } else { [INFO] [stderr] 167 | | Err(TryPopError::Disconnected) [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 164 | Err(TryPopError::Empty) [INFO] [stderr] 165 | } else { [INFO] [stderr] 166 | Err(TryPopError::Disconnected) [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpmc.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 131 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 132 | | return Err(TryPushError::Full(value)) [INFO] [stderr] 133 | | } else { [INFO] [stderr] 134 | | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 131 | return Err(TryPushError::Full(value)) [INFO] [stderr] 132 | } else { [INFO] [stderr] 133 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpmc.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 173 | | if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 174 | | let v = buf_read(&q.buf, tail); [INFO] [stderr] 175 | | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | } else if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 173 | let v = buf_read(&q.buf, tail); [INFO] [stderr] 174 | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] 175 | Ok(v) [INFO] [stderr] 176 | } else { [INFO] [stderr] 177 | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpmc.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 178 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 179 | | Err(TryPopError::Empty) [INFO] [stderr] 180 | | } else { [INFO] [stderr] 181 | | Err(TryPopError::Disconnected) [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 177 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 178 | Err(TryPopError::Empty) [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | Err(TryPopError::Disconnected) [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spsc.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spsc.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpsc.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpsc.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 129 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 130 | | return Err(TryPushError::Full(value)) [INFO] [stderr] 131 | | } else { [INFO] [stderr] 132 | | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 129 | return Err(TryPushError::Full(value)) [INFO] [stderr] 130 | } else { [INFO] [stderr] 131 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spmc.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spmc.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/spmc.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 159 | | if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 160 | | let v = buf_read(&q.buf, tail); [INFO] [stderr] 161 | | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 158 | } else if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 159 | let v = buf_read(&q.buf, tail); [INFO] [stderr] 160 | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] 161 | Ok(v) [INFO] [stderr] 162 | } else { [INFO] [stderr] 163 | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/spmc.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 164 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 165 | | Err(TryPopError::Empty) [INFO] [stderr] 166 | | } else { [INFO] [stderr] 167 | | Err(TryPopError::Disconnected) [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 164 | Err(TryPopError::Empty) [INFO] [stderr] 165 | } else { [INFO] [stderr] 166 | Err(TryPopError::Disconnected) [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | return Err(TryPushError::Full(value)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Full(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mpmc.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TryPushError::Disconnected(value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpmc.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 131 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 132 | | return Err(TryPushError::Full(value)) [INFO] [stderr] 133 | | } else { [INFO] [stderr] 134 | | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 131 | return Err(TryPushError::Full(value)) [INFO] [stderr] 132 | } else { [INFO] [stderr] 133 | return Err(TryPushError::Disconnected(value)); [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpmc.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 173 | | if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 174 | | let v = buf_read(&q.buf, tail); [INFO] [stderr] 175 | | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | } else if q.next_tail.compare_and_swap(tail, tail_plus_one, Ordering::Acquire) == tail { [INFO] [stderr] 173 | let v = buf_read(&q.buf, tail); [INFO] [stderr] 174 | q.tail.store(tail_plus_one, Ordering::Release); [INFO] [stderr] 175 | Ok(v) [INFO] [stderr] 176 | } else { [INFO] [stderr] 177 | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/mpmc.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 178 | | if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 179 | | Err(TryPopError::Empty) [INFO] [stderr] 180 | | } else { [INFO] [stderr] 181 | | Err(TryPopError::Disconnected) [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 177 | } else if q.ok.load(Ordering::Relaxed) { [INFO] [stderr] 178 | Err(TryPopError::Empty) [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | Err(TryPopError::Disconnected) [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer/dynamic.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { self.ptr.offset(idx as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/spmc.rs:259:40 [INFO] [stderr] | [INFO] [stderr] 259 | .map(|t| t.join().unwrap()) [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 260 | | .fold(0u64, |a, b| a + b); [INFO] [stderr] | |_____________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/mpmc.rs:281:40 [INFO] [stderr] | [INFO] [stderr] 281 | .map(|t| t.join().unwrap()) [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 282 | | .fold(0u64, |a, b| a + b); [INFO] [stderr] | |_____________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "0242785943a975c2589d42d861229991701505547d49dd4aee977219c4eba767"` [INFO] running `"docker" "rm" "-f" "0242785943a975c2589d42d861229991701505547d49dd4aee977219c4eba767"` [INFO] [stdout] 0242785943a975c2589d42d861229991701505547d49dd4aee977219c4eba767