[INFO] crate m3u8-rs 1.0.4 is already in cache [INFO] extracting crate m3u8-rs 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/m3u8-rs/1.0.4 [INFO] extracting crate m3u8-rs 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/m3u8-rs/1.0.4 [INFO] validating manifest of m3u8-rs-1.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of m3u8-rs-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing m3u8-rs-1.0.4 [INFO] finished frobbing m3u8-rs-1.0.4 [INFO] frobbed toml for m3u8-rs-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/m3u8-rs/1.0.4/Cargo.toml [INFO] started frobbing m3u8-rs-1.0.4 [INFO] finished frobbing m3u8-rs-1.0.4 [INFO] frobbed toml for m3u8-rs-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/m3u8-rs/1.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting m3u8-rs-1.0.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/m3u8-rs/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19c7ba8eb0e1948e1220bb41cfaac3ed48582932185a19f2145ea810bc1f7583 [INFO] running `"docker" "start" "-a" "19c7ba8eb0e1948e1220bb41cfaac3ed48582932185a19f2145ea810bc1f7583"` [INFO] [stderr] Checking m3u8-rs v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/playlist.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | writeln!(w, "{}" ,"#EXTM3U")?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/playlist.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | is_i_frame: is_i_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_i_frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/playlist.rs:493:27 [INFO] [stderr] | [INFO] [stderr] 493 | writeln!(w, "{}" ,"#EXTM3U")?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:598:13 [INFO] [stderr] | [INFO] [stderr] 598 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/playlist.rs:601:30 [INFO] [stderr] | [INFO] [stderr] 601 | writeln!(w, "{}", "#EXT-X-DISCONTINUITY")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:611:13 [INFO] [stderr] | [INFO] [stderr] 611 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:787:9 [INFO] [stderr] | [INFO] [stderr] 787 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/playlist.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | writeln!(w, "{}" ,"#EXTM3U")?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/playlist.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | is_i_frame: is_i_frame, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_i_frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/playlist.rs:493:27 [INFO] [stderr] | [INFO] [stderr] 493 | writeln!(w, "{}" ,"#EXTM3U")?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:598:13 [INFO] [stderr] | [INFO] [stderr] 598 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/playlist.rs:601:30 [INFO] [stderr] | [INFO] [stderr] 601 | writeln!(w, "{}", "#EXT-X-DISCONTINUITY")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:611:13 [INFO] [stderr] | [INFO] [stderr] 611 | write!(w, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/playlist.rs:787:9 [INFO] [stderr] | [INFO] [stderr] 787 | write!(w, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/playlist.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | MasterPlaylist(MasterPlaylist), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 43 | MasterPlaylist(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playlist.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &Playlist::MasterPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] 51 | | &Playlist::MediaPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | Playlist::MasterPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] 51 | Playlist::MediaPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 218 | write_some_attribute_quoted!(w, ",AUDIO", &self.audio)?; [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 219 | write_some_attribute_quoted!(w, ",SUBTITLES", &self.subtitles)?; [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 220 | write_some_attribute_quoted!(w, ",CLOSED-CAPTIONS", &self.closed_captions)?; [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/playlist.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | MasterPlaylist(MasterPlaylist), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 43 | MasterPlaylist(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 228 | write_some_attribute!(w, ",AVERAGE-BANDWIDTH", &self.average_bandwidth)?; [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 230 | write_some_attribute!(w, ",RESOLUTION", &self.resolution)?; [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 231 | write_some_attribute!(w, ",FRAME-RATE", &self.frame_rate)?; [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 232 | write_some_attribute_quoted!(w, ",VIDEO", &self.video) [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/playlist.rs:272:19 [INFO] [stderr] | [INFO] [stderr] 272 | name: attrs.remove("NAME").unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `attrs.remove("NAME").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playlist.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &Playlist::MasterPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] 51 | | &Playlist::MediaPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | Playlist::MasterPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] 51 | Playlist::MediaPlaylist(ref pl) => pl.write_to(writer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | write_some_attribute_quoted!(w, ",URI", &self.uri)?; [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 286 | write_some_attribute_quoted!(w, ",LANGUAGE", &self.language)?; [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 287 | write_some_attribute_quoted!(w, ",ASSOC-LANGUAGE", &self.assoc_language)?; [INFO] [stderr] | ------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 292 | write_some_attribute_quoted!(w, ",INSTREAM-ID", &self.instream_id)?; [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 293 | write_some_attribute_quoted!(w, ",CHARACTERISTICS", &self.characteristics)?; [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playlist.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 329 | | &AlternativeMediaType::Audio => "AUDIO", [INFO] [stderr] 330 | | &AlternativeMediaType::Video => "VIDEO", [INFO] [stderr] 331 | | &AlternativeMediaType::Subtitles => "SUBTITLES", [INFO] [stderr] 332 | | &AlternativeMediaType::ClosedCaptions => "CLOSEDCAPTIONS", [INFO] [stderr] 333 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 328 | write!(f, "{}", match *self { [INFO] [stderr] 329 | AlternativeMediaType::Audio => "AUDIO", [INFO] [stderr] 330 | AlternativeMediaType::Video => "VIDEO", [INFO] [stderr] 331 | AlternativeMediaType::Subtitles => "SUBTITLES", [INFO] [stderr] 332 | AlternativeMediaType::ClosedCaptions => "CLOSEDCAPTIONS", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 218 | write_some_attribute_quoted!(w, ",AUDIO", &self.audio)?; [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 219 | write_some_attribute_quoted!(w, ",SUBTITLES", &self.subtitles)?; [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 220 | write_some_attribute_quoted!(w, ",CLOSED-CAPTIONS", &self.closed_captions)?; [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 228 | write_some_attribute!(w, ",AVERAGE-BANDWIDTH", &self.average_bandwidth)?; [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 230 | write_some_attribute!(w, ",RESOLUTION", &self.resolution)?; [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 231 | write_some_attribute!(w, ",FRAME-RATE", &self.frame_rate)?; [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 232 | write_some_attribute_quoted!(w, ",VIDEO", &self.video) [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/playlist.rs:272:19 [INFO] [stderr] | [INFO] [stderr] 272 | name: attrs.remove("NAME").unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `attrs.remove("NAME").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 379 | write_some_attribute_quoted!(w, ",LANGUAGE", &self.language)?; [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | write_some_attribute_quoted!(w, ",URI", &self.uri)?; [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 286 | write_some_attribute_quoted!(w, ",LANGUAGE", &self.language)?; [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 287 | write_some_attribute_quoted!(w, ",ASSOC-LANGUAGE", &self.assoc_language)?; [INFO] [stderr] | ------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 292 | write_some_attribute_quoted!(w, ",INSTREAM-ID", &self.instream_id)?; [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 293 | write_some_attribute_quoted!(w, ",CHARACTERISTICS", &self.characteristics)?; [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playlist.rs:328:25 [INFO] [stderr] | [INFO] [stderr] 328 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 329 | | &AlternativeMediaType::Audio => "AUDIO", [INFO] [stderr] 330 | | &AlternativeMediaType::Video => "VIDEO", [INFO] [stderr] 331 | | &AlternativeMediaType::Subtitles => "SUBTITLES", [INFO] [stderr] 332 | | &AlternativeMediaType::ClosedCaptions => "CLOSEDCAPTIONS", [INFO] [stderr] 333 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 328 | write!(f, "{}", match *self { [INFO] [stderr] 329 | AlternativeMediaType::Audio => "AUDIO", [INFO] [stderr] 330 | AlternativeMediaType::Video => "VIDEO", [INFO] [stderr] 331 | AlternativeMediaType::Subtitles => "SUBTITLES", [INFO] [stderr] 332 | AlternativeMediaType::ClosedCaptions => "CLOSEDCAPTIONS", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 379 | write_some_attribute_quoted!(w, ",LANGUAGE", &self.language)?; [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playlist.rs:548:25 [INFO] [stderr] | [INFO] [stderr] 548 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 549 | | &MediaPlaylistType::Event => "EVENT", [INFO] [stderr] 550 | | &MediaPlaylistType::Vod => "VOD", [INFO] [stderr] 551 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 548 | write!(f, "{}", match *self { [INFO] [stderr] 549 | MediaPlaylistType::Event => "EVENT", [INFO] [stderr] 550 | MediaPlaylistType::Vod => "VOD", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playlist.rs:548:25 [INFO] [stderr] | [INFO] [stderr] 548 | write!(f, "{}", match self { [INFO] [stderr] | _________________________^ [INFO] [stderr] 549 | | &MediaPlaylistType::Event => "EVENT", [INFO] [stderr] 550 | | &MediaPlaylistType::Vod => "VOD", [INFO] [stderr] 551 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 548 | write!(f, "{}", match *self { [INFO] [stderr] 549 | MediaPlaylistType::Event => "EVENT", [INFO] [stderr] 550 | MediaPlaylistType::Vod => "VOD", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 661 | write_some_attribute_quoted!(w, ",URI", &self.uri)?; [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 662 | write_some_attribute!(w, ",IV", &self.iv)?; [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | write_some_attribute!(w, ",KEYFORMAT", &self.keyformat)?; [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | write_some_attribute!(w, ",KEYFORMATVERSIONS", &self.keyformatversions) [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | if let &Some(ref v) = $o { write!($w, "{}=\"{}\"", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 661 | write_some_attribute_quoted!(w, ",URI", &self.uri)?; [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 662 | write_some_attribute!(w, ",IV", &self.iv)?; [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | write_some_attribute!(w, ",KEYFORMAT", &self.keyformat)?; [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 664 | write_some_attribute!(w, ",KEYFORMATVERSIONS", &self.keyformatversions) [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/playlist.rs:780:46 [INFO] [stderr] | [INFO] [stderr] 780 | precise: attrs.remove("PRECISE").or(Some("NO".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some("NO".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 786 | write_some_attribute!(w, ",PRECISE", &self.precise)?; [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/playlist.rs:780:46 [INFO] [stderr] | [INFO] [stderr] 780 | precise: attrs.remove("PRECISE").or(Some("NO".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some("NO".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / match is_master_playlist(input) { [INFO] [stderr] 131 | | true => parse_master_playlist(input).map(Playlist::MasterPlaylist), [INFO] [stderr] 132 | | false => parse_media_playlist(input).map(Playlist::MediaPlaylist), [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_master_playlist(input) { parse_master_playlist(input).map(Playlist::MasterPlaylist) } else { parse_media_playlist(input).map(Playlist::MediaPlaylist) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/playlist.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | if let &Some(ref v) = $o { write!($w, "{}={}", $tag, v) } else { Ok(()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 786 | write_some_attribute!(w, ",PRECISE", &self.precise)?; [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | / match is_master_playlist(input) { [INFO] [stderr] 131 | | true => parse_master_playlist(input).map(Playlist::MasterPlaylist), [INFO] [stderr] 132 | | false => parse_media_playlist(input).map(Playlist::MediaPlaylist), [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_master_playlist(input) { parse_master_playlist(input).map(Playlist::MasterPlaylist) } else { parse_media_playlist(input).map(Playlist::MediaPlaylist) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | VariantStream(VariantStream), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 270 | VariantStream(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lib.rs:281:1 [INFO] [stderr] | [INFO] [stderr] 281 | / pub fn master_playlist_tag(input: &[u8]) -> IResult<&[u8], MasterPlaylistTag> { [INFO] [stderr] 282 | | alt!(input, [INFO] [stderr] 283 | | map!(m3u_tag, MasterPlaylistTag::M3U) [INFO] [stderr] 284 | | | map!(version_tag, MasterPlaylistTag::Version) [INFO] [stderr] ... | [INFO] [stderr] 298 | | ) [INFO] [stderr] 299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | VariantStream(VariantStream), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 270 | VariantStream(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lib.rs:281:1 [INFO] [stderr] | [INFO] [stderr] 281 | / pub fn master_playlist_tag(input: &[u8]) -> IResult<&[u8], MasterPlaylistTag> { [INFO] [stderr] 282 | | alt!(input, [INFO] [stderr] 283 | | map!(m3u_tag, MasterPlaylistTag::M3U) [INFO] [stderr] 284 | | | map!(version_tag, MasterPlaylistTag::Version) [INFO] [stderr] ... | [INFO] [stderr] 298 | | ) [INFO] [stderr] 299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 52 [INFO] [stderr] --> src/lib.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / pub fn media_playlist_tag(input: &[u8]) -> IResult<&[u8], MediaPlaylistTag> { [INFO] [stderr] 354 | | alt!(input, [INFO] [stderr] 355 | | map!(m3u_tag, MediaPlaylistTag::M3U) [INFO] [stderr] 356 | | | map!(version_tag, MediaPlaylistTag::Version) [INFO] [stderr] ... | [INFO] [stderr] 368 | | ) [INFO] [stderr] 369 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 52 [INFO] [stderr] --> src/lib.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / pub fn media_playlist_tag(input: &[u8]) -> IResult<&[u8], MediaPlaylistTag> { [INFO] [stderr] 354 | | alt!(input, [INFO] [stderr] 355 | | map!(m3u_tag, MediaPlaylistTag::M3U) [INFO] [stderr] 356 | | | map!(version_tag, MediaPlaylistTag::Version) [INFO] [stderr] ... | [INFO] [stderr] 368 | | ) [INFO] [stderr] 369 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 54 [INFO] [stderr] --> src/lib.rs:397:1 [INFO] [stderr] | [INFO] [stderr] 397 | / pub fn media_segment_tag(input: &[u8]) -> IResult<&[u8], SegmentTag> { [INFO] [stderr] 398 | | alt!(input, [INFO] [stderr] 399 | | map!(chain!(tag!("#EXTINF:") ~ e:duration_title_tag,||e), |(a,b)| SegmentTag::Extinf(a,b)) [INFO] [stderr] 400 | | | map!(chain!(tag!("#EXT-X-BYTERANGE:") ~ r:byte_range_val, || r), SegmentTag::ByteRange) [INFO] [stderr] ... | [INFO] [stderr] 411 | | ) [INFO] [stderr] 412 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 54 [INFO] [stderr] --> src/lib.rs:397:1 [INFO] [stderr] | [INFO] [stderr] 397 | / pub fn media_segment_tag(input: &[u8]) -> IResult<&[u8], SegmentTag> { [INFO] [stderr] 398 | | alt!(input, [INFO] [stderr] 399 | | map!(chain!(tag!("#EXTINF:") ~ e:duration_title_tag,||e), |(a,b)| SegmentTag::Extinf(a,b)) [INFO] [stderr] 400 | | | map!(chain!(tag!("#EXT-X-BYTERANGE:") ~ r:byte_range_val, || r), SegmentTag::ByteRange) [INFO] [stderr] ... | [INFO] [stderr] 411 | | ) [INFO] [stderr] 412 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:357:25 [INFO] [stderr] | [INFO] [stderr] 357 | media_sequence: 338559, [INFO] [stderr] | ^^^^^^ help: consider: `338_559` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> examples/with_nom_result.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | IResult::Done(i, playlist) => playlist, [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> examples/with_nom_result.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | IResult::Done(i, Playlist::MasterPlaylist(pl)) => println!("Master playlist:\n{:?}", pl), [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> examples/with_nom_result.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | IResult::Done(i, Playlist::MediaPlaylist(pl)) => println!("Media playlist:\n{:?}", pl), [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `main_alt` [INFO] [stderr] --> examples/with_nom_result.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | fn main_alt() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | "rest".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"rest"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:189:23 [INFO] [stderr] | [INFO] [stderr] 189 | IResult::Done("xxx".as_bytes(), "Hello".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"xxx"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | IResult::Done("rest".as_bytes(), "value".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"rest"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:211:23 [INFO] [stderr] | [INFO] [stderr] 211 | IResult::Done("rest".as_bytes(), 33.22f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"rest"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:219:23 [INFO] [stderr] | [INFO] [stderr] 219 | IResult::Done("rest".as_bytes(), 33f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"rest"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | IResult::Done(".rest".as_bytes(), 33f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b".rest"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:235:23 [INFO] [stderr] | [INFO] [stderr] 235 | IResult::Done("rest".as_bytes(), (2.002f32, Some("title".to_string()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"rest"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.93s [INFO] running `"docker" "inspect" "19c7ba8eb0e1948e1220bb41cfaac3ed48582932185a19f2145ea810bc1f7583"` [INFO] running `"docker" "rm" "-f" "19c7ba8eb0e1948e1220bb41cfaac3ed48582932185a19f2145ea810bc1f7583"` [INFO] [stdout] 19c7ba8eb0e1948e1220bb41cfaac3ed48582932185a19f2145ea810bc1f7583