[INFO] crate lzma 0.2.2 is already in cache [INFO] extracting crate lzma 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/lzma/0.2.2 [INFO] extracting crate lzma 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzma/0.2.2 [INFO] validating manifest of lzma-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lzma-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lzma-0.2.2 [INFO] finished frobbing lzma-0.2.2 [INFO] frobbed toml for lzma-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/lzma/0.2.2/Cargo.toml [INFO] started frobbing lzma-0.2.2 [INFO] finished frobbing lzma-0.2.2 [INFO] frobbed toml for lzma-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzma/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lzma-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzma/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e353f3ebd8aa1eb8bf85da725e7c779a3545289f3682b6d0e85f1bf16fa62045 [INFO] running `"docker" "start" "-a" "e353f3ebd8aa1eb8bf85da725e7c779a3545289f3682b6d0e85f1bf16fa62045"` [INFO] [stderr] Checking lzma v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | lc: lc, [INFO] [stderr] | ^^^^^^ help: replace it with: `lc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | lp: lp, [INFO] [stderr] | ^^^^^^ help: replace it with: `lp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | pb: pb, [INFO] [stderr] | ^^^^^^ help: replace it with: `pb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | dictionary: dictionary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dictionary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | uncompressed: uncompressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uncompressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/probabilities.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | size: size, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/bit_tree.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/window.rs:24:4 [INFO] [stderr] | [INFO] [stderr] 24 | size: size, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/range.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/range.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | code: code, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/cache.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | lc: lc, [INFO] [stderr] | ^^^^^^ help: replace it with: `lc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | lp: lp, [INFO] [stderr] | ^^^^^^ help: replace it with: `lp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:59:3 [INFO] [stderr] | [INFO] [stderr] 59 | pb: pb, [INFO] [stderr] | ^^^^^^ help: replace it with: `pb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | dictionary: dictionary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dictionary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/properties.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | uncompressed: uncompressed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uncompressed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/probabilities.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | size: size, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/bit_tree.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/window.rs:24:4 [INFO] [stderr] | [INFO] [stderr] 24 | size: size, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/range.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/range.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | code: code, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/cache.rs:17:4 [INFO] [stderr] | [INFO] [stderr] 17 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/reader.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | literal: literal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `literal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/range.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | range: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/range.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | self.range = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/reader/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | mod reader; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/reader/reader.rs:258:8 [INFO] [stderr] | [INFO] [stderr] 258 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 259 | | if self.range.is_finished() { [INFO] [stderr] 260 | | return Err(Error::MissingMarker); [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 258 | else if self.range.is_finished() { [INFO] [stderr] 259 | return Err(Error::MissingMarker); [INFO] [stderr] 260 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/reader.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | if self.rep[0] == 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/range.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | range: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/range.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | self.range = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/reader/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | mod reader; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/reader/reader.rs:258:8 [INFO] [stderr] | [INFO] [stderr] 258 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 259 | | if self.range.is_finished() { [INFO] [stderr] 260 | | return Err(Error::MissingMarker); [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 258 | else if self.range.is_finished() { [INFO] [stderr] 259 | return Err(Error::MissingMarker); [INFO] [stderr] 260 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader/reader.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | if self.rep[0] == 0xffffffff { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 45 | | &Error::IO(ref err) => [INFO] [stderr] 46 | | err.description(), [INFO] [stderr] 47 | | [INFO] [stderr] ... | [INFO] [stderr] 64 | | "The stream has finished unexpectedly with a marker.", [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *self { [INFO] [stderr] 45 | Error::IO(ref err) => [INFO] [stderr] 46 | err.description(), [INFO] [stderr] 47 | [INFO] [stderr] 48 | Error::Corrupted => [INFO] [stderr] 49 | "The LZMA stream is corrupted.", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/range.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | self.code = (self.code << 8) | try!(stream.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | self.code = (self.code << 8) | u32::from(match $ expr { [INFO] [stderr] 53 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 54 | :: Err ( err ) => { [INFO] [stderr] 55 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 56 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/range.rs:76:38 [INFO] [stderr] | [INFO] [stderr] 76 | self.code = (self.code << 8) | try!(stream.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | self.code = (self.code << 8) | u32::from(match $ expr { [INFO] [stderr] 77 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 78 | :: Err ( err ) => { [INFO] [stderr] 79 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 80 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/range.rs:109:54 [INFO] [stderr] | [INFO] [stderr] 109 | let bound = (self.range >> MODEL_TOTAL_BITS) * v as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `reader::length::Length` [INFO] [stderr] --> src/reader/length.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 20 | | Length { [INFO] [stderr] 21 | | choice: [PROBABILITY_INITIAL_VALUE; 2], [INFO] [stderr] 22 | | [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for reader::length::Length { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/reader.rs:200:4 [INFO] [stderr] | [INFO] [stderr] 200 | self.window[1] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.window[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/reader.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | + (prev >> (8 - self.properties.lc as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.properties.lc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/reader.rs:223:24 [INFO] [stderr] | [INFO] [stderr] 223 | &mut probs[(((1 + match_bit as u32) << 8) + byte) as usize])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(match_bit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/reader.rs:386:6 [INFO] [stderr] | [INFO] [stderr] 386 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 45 | | &Error::IO(ref err) => [INFO] [stderr] 46 | | err.description(), [INFO] [stderr] 47 | | [INFO] [stderr] ... | [INFO] [stderr] 64 | | "The stream has finished unexpectedly with a marker.", [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *self { [INFO] [stderr] 45 | Error::IO(ref err) => [INFO] [stderr] 46 | err.description(), [INFO] [stderr] 47 | [INFO] [stderr] 48 | Error::Corrupted => [INFO] [stderr] 49 | "The LZMA stream is corrupted.", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/range.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | self.code = (self.code << 8) | try!(stream.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 52 | self.code = (self.code << 8) | u32::from(match $ expr { [INFO] [stderr] 53 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 54 | :: Err ( err ) => { [INFO] [stderr] 55 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 56 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/range.rs:76:38 [INFO] [stderr] | [INFO] [stderr] 76 | self.code = (self.code << 8) | try!(stream.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | self.code = (self.code << 8) | u32::from(match $ expr { [INFO] [stderr] 77 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 78 | :: Err ( err ) => { [INFO] [stderr] 79 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 80 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/range.rs:109:54 [INFO] [stderr] | [INFO] [stderr] 109 | let bound = (self.range >> MODEL_TOTAL_BITS) * v as u32; [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `reader::length::Length` [INFO] [stderr] --> src/reader/length.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 20 | | Length { [INFO] [stderr] 21 | | choice: [PROBABILITY_INITIAL_VALUE; 2], [INFO] [stderr] 22 | | [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for reader::length::Length { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/reader.rs:200:4 [INFO] [stderr] | [INFO] [stderr] 200 | self.window[1] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.window[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/reader.rs:210:20 [INFO] [stderr] | [INFO] [stderr] 210 | + (prev >> (8 - self.properties.lc as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.properties.lc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader/reader.rs:223:24 [INFO] [stderr] | [INFO] [stderr] 223 | &mut probs[(((1 + match_bit as u32) << 8) + byte) as usize])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(match_bit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader/reader.rs:386:6 [INFO] [stderr] | [INFO] [stderr] 386 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> examples/info.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | else { [INFO] [stderr] | __________^ [INFO] [stderr] 34 | | if read { [INFO] [stderr] 35 | | let mut size = 0u64; [INFO] [stderr] 36 | | let mut buf = [0u8; 4096]; [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | else if read { [INFO] [stderr] 34 | let mut size = 0u64; [INFO] [stderr] 35 | let mut buf = [0u8; 4096]; [INFO] [stderr] 36 | [INFO] [stderr] 37 | loop { [INFO] [stderr] 38 | match decoder.read(&mut buf) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `"docker" "inspect" "e353f3ebd8aa1eb8bf85da725e7c779a3545289f3682b6d0e85f1bf16fa62045"` [INFO] running `"docker" "rm" "-f" "e353f3ebd8aa1eb8bf85da725e7c779a3545289f3682b6d0e85f1bf16fa62045"` [INFO] [stdout] e353f3ebd8aa1eb8bf85da725e7c779a3545289f3682b6d0e85f1bf16fa62045