[INFO] crate lzf 0.3.1 is already in cache [INFO] extracting crate lzf 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/lzf/0.3.1 [INFO] extracting crate lzf 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzf/0.3.1 [INFO] validating manifest of lzf-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lzf-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lzf-0.3.1 [INFO] finished frobbing lzf-0.3.1 [INFO] frobbed toml for lzf-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/lzf/0.3.1/Cargo.toml [INFO] started frobbing lzf-0.3.1 [INFO] finished frobbing lzf-0.3.1 [INFO] frobbed toml for lzf-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzf/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lzf-0.3.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzf/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdb058da5c088d9642d135d0142111968fe916cad58aff838850b6f57d365663 [INFO] running `"docker" "start" "-a" "fdb058da5c088d9642d135d0142111968fe916cad58aff838850b6f57d365663"` [INFO] [stderr] Checking lzf v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | ((p[off] as u32) << 8) | p[off+1] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(p[off])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | ((p[off] as u32) << 8) | p[off+1] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(p[off+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | (v << 8) | p[off+2] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(p[off+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let h = h as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:23:11 [INFO] [stderr] | [INFO] [stderr] 23 | & (HSIZE-1) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(HSIZE-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ref_offset` [INFO] [stderr] --> src/compress.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | && data[ref_offset+0] == data[current_offset+0] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `current_offset` [INFO] [stderr] --> src/compress.rs:84:43 [INFO] [stderr] | [INFO] [stderr] 84 | && data[ref_offset+0] == data[current_offset+0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/compress.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | / loop { [INFO] [stderr] 100 | | len += 1; [INFO] [stderr] 101 | | while len < maxlen && data[ref_offset+len] == data[current_offset+len] { [INFO] [stderr] 102 | | len += 1; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | break; [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/decompress.rs:50:27 [INFO] [stderr] | [INFO] [stderr] 50 | let src = src.offset(current_offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(current_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/decompress.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | let dst = dst.offset((out_len) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add((out_len))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decompress.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | ref_offset += data[current_offset] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data[current_offset])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lzf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | ((p[off] as u32) << 8) | p[off+1] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(p[off])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | ((p[off] as u32) << 8) | p[off+1] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(p[off+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | (v << 8) | p[off+2] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(p[off+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let h = h as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/compress.rs:23:11 [INFO] [stderr] | [INFO] [stderr] 23 | & (HSIZE-1) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(HSIZE-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ref_offset` [INFO] [stderr] --> src/compress.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | && data[ref_offset+0] == data[current_offset+0] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `current_offset` [INFO] [stderr] --> src/compress.rs:84:43 [INFO] [stderr] | [INFO] [stderr] 84 | && data[ref_offset+0] == data[current_offset+0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/compress.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | / loop { [INFO] [stderr] 100 | | len += 1; [INFO] [stderr] 101 | | while len < maxlen && data[ref_offset+len] == data[current_offset+len] { [INFO] [stderr] 102 | | len += 1; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | break; [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compress.rs:189:20 [INFO] [stderr] | [INFO] [stderr] 189 | match compress("foo".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/decompress.rs:50:27 [INFO] [stderr] | [INFO] [stderr] 50 | let src = src.offset(current_offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(current_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/decompress.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | let dst = dst.offset((out_len) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add((out_len))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decompress.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | ref_offset += data[current_offset] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data[current_offset])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | match compress("foo".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lzf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fdb058da5c088d9642d135d0142111968fe916cad58aff838850b6f57d365663"` [INFO] running `"docker" "rm" "-f" "fdb058da5c088d9642d135d0142111968fe916cad58aff838850b6f57d365663"` [INFO] [stdout] fdb058da5c088d9642d135d0142111968fe916cad58aff838850b6f57d365663