[INFO] crate luthor 0.2.0 is already in cache [INFO] extracting crate luthor 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/luthor/0.2.0 [INFO] extracting crate luthor 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luthor/0.2.0 [INFO] validating manifest of luthor-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luthor-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luthor-0.2.0 [INFO] finished frobbing luthor-0.2.0 [INFO] frobbed toml for luthor-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/luthor/0.2.0/Cargo.toml [INFO] started frobbing luthor-0.2.0 [INFO] finished frobbing luthor-0.2.0 [INFO] frobbed toml for luthor-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luthor/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luthor-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luthor/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c76f44026da732d1b4ae8ccf61b6e4f64f1349df9d9d866992de93bb7cbf3167 [INFO] running `"docker" "start" "-a" "c76f44026da732d1b4ae8ccf61b6e4f64f1349df9d9d866992de93bb7cbf3167"` [INFO] [stderr] Checking luthor v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | category: category, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | category: category, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `category` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexers/xml.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | return Some(StateFunction(whitespace)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(StateFunction(whitespace))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexers/xml.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | return Some(StateFunction(whitespace)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(StateFunction(whitespace))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexers/xml.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | return Some(StateFunction(whitespace)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(StateFunction(whitespace))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexers/xml.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | return Some(StateFunction(whitespace)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(StateFunction(whitespace))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lexers/ruby.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | } else if tokenizer.starts_with_lexeme("if") { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 19 | | tokenizer.tokenize_next(2, Category::Keyword); [INFO] [stderr] 20 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 21 | | } else if tokenizer.starts_with_lexeme("end") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lexers/ruby.rs:15:50 [INFO] [stderr] | [INFO] [stderr] 15 | } else if tokenizer.starts_with_lexeme("do") { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 16 | | tokenizer.tokenize_next(2, Category::Keyword); [INFO] [stderr] 17 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 18 | | } else if tokenizer.starts_with_lexeme("if") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lexers/rust.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | for keyword in vec!["pub", "let", "mut", "match", "loop"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["pub", "let", "mut", "match", "loop"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lexers/rust.rs:20:51 [INFO] [stderr] | [INFO] [stderr] 20 | } else if tokenizer.starts_with_lexeme("mod") { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 21 | | tokenizer.tokenize_next(3, Category::Keyword); [INFO] [stderr] 22 | | tokenizer.states.push(StateFunction(identifier)); [INFO] [stderr] 23 | | [INFO] [stderr] 24 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 25 | | } else if tokenizer.starts_with_lexeme("extern") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lexers/rust.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | if tokenizer.starts_with_lexeme("use") { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 16 | | tokenizer.tokenize_next(3, Category::Keyword); [INFO] [stderr] 17 | | tokenizer.states.push(StateFunction(identifier)); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 20 | | } else if tokenizer.starts_with_lexeme("mod") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match self.data.next() { [INFO] [stderr] 105 | | Some(c) => self.current_token.push(c), [INFO] [stderr] 106 | | None => () [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(c) = self.data.next() { self.current_token.push(c) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | Some(c) => Some(c.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/tokenizer.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | self.has_prefix(lexeme) && match data_iter.skip(lexeme.len()).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `luthor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lexers/ruby.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | } else if tokenizer.starts_with_lexeme("if") { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 19 | | tokenizer.tokenize_next(2, Category::Keyword); [INFO] [stderr] 20 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 21 | | } else if tokenizer.starts_with_lexeme("end") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lexers/ruby.rs:15:50 [INFO] [stderr] | [INFO] [stderr] 15 | } else if tokenizer.starts_with_lexeme("do") { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 16 | | tokenizer.tokenize_next(2, Category::Keyword); [INFO] [stderr] 17 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 18 | | } else if tokenizer.starts_with_lexeme("if") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lexers/rust.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | for keyword in vec!["pub", "let", "mut", "match", "loop"] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["pub", "let", "mut", "match", "loop"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lexers/rust.rs:20:51 [INFO] [stderr] | [INFO] [stderr] 20 | } else if tokenizer.starts_with_lexeme("mod") { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 21 | | tokenizer.tokenize_next(3, Category::Keyword); [INFO] [stderr] 22 | | tokenizer.states.push(StateFunction(identifier)); [INFO] [stderr] 23 | | [INFO] [stderr] 24 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 25 | | } else if tokenizer.starts_with_lexeme("extern") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lexers/rust.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | if tokenizer.starts_with_lexeme("use") { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 16 | | tokenizer.tokenize_next(3, Category::Keyword); [INFO] [stderr] 17 | | tokenizer.states.push(StateFunction(identifier)); [INFO] [stderr] 18 | | [INFO] [stderr] 19 | | return Some(StateFunction(whitespace)) [INFO] [stderr] 20 | | } else if tokenizer.starts_with_lexeme("mod") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match self.data.next() { [INFO] [stderr] 105 | | Some(c) => self.current_token.push(c), [INFO] [stderr] 106 | | None => () [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(c) = self.data.next() { self.current_token.push(c) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tokenizer.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | Some(c) => Some(c.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/tokenizer.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | self.has_prefix(lexeme) && match data_iter.skip(lexeme.len()).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `luthor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c76f44026da732d1b4ae8ccf61b6e4f64f1349df9d9d866992de93bb7cbf3167"` [INFO] running `"docker" "rm" "-f" "c76f44026da732d1b4ae8ccf61b6e4f64f1349df9d9d866992de93bb7cbf3167"` [INFO] [stdout] c76f44026da732d1b4ae8ccf61b6e4f64f1349df9d9d866992de93bb7cbf3167