[INFO] crate lrs 0.1.1 is already in cache
[INFO] extracting crate lrs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lrs/0.1.1
[INFO] extracting crate lrs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lrs/0.1.1
[INFO] validating manifest of lrs-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lrs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lrs-0.1.1
[INFO] finished frobbing lrs-0.1.1
[INFO] frobbed toml for lrs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lrs/0.1.1/Cargo.toml
[INFO] started frobbing lrs-0.1.1
[INFO] finished frobbing lrs-0.1.1
[INFO] frobbed toml for lrs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lrs/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lrs-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lrs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 408d50d9bd5e5a9522b4120d0dd3de65c9f0f4dc4456056d204094adf2c6c1f3
[INFO] running `"docker" "start" "-a" "408d50d9bd5e5a9522b4120d0dd3de65c9f0f4dc4456056d204094adf2c6c1f3"`
[INFO] [stderr]     Checking lrs v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return t;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `t`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/clause.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 | /         return Operation {
[INFO] [stderr] 57 | |             _type: DERIVE,
[INFO] [stderr] 58 | |             term: Vec::new(),
[INFO] [stderr] 59 | |             symbol: Vec::new(),
[INFO] [stderr] 60 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Operation {
[INFO] [stderr] 57 |             _type: DERIVE,
[INFO] [stderr] 58 |             term: Vec::new(),
[INFO] [stderr] 59 |             symbol: Vec::new(),
[INFO] [stderr] 60 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/clause.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return t;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `t`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/terms.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/clause.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 | /         return Operation {
[INFO] [stderr] 57 | |             _type: DERIVE,
[INFO] [stderr] 58 | |             term: Vec::new(),
[INFO] [stderr] 59 | |             symbol: Vec::new(),
[INFO] [stderr] 60 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Operation {
[INFO] [stderr] 57 |             _type: DERIVE,
[INFO] [stderr] 58 |             term: Vec::new(),
[INFO] [stderr] 59 |             symbol: Vec::new(),
[INFO] [stderr] 60 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/clause.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/tests.rs:7:1
[INFO] [stderr]    |
[INFO] [stderr] 7  | / mod tests {
[INFO] [stderr] 8  | |     use terms::*;
[INFO] [stderr] 9  | |     use clause::*;
[INFO] [stderr] 10 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |     }
[INFO] [stderr] 45 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `t`
[INFO] [stderr]   --> src/clause.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |             Some(t) => {
[INFO] [stderr]    |                  ^ help: consider using `_t` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/terms.rs:42:33
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn contains(&self, sym: &Symbol) -> bool {
[INFO] [stderr]    |                                 ^^^^^^^ help: consider passing by value instead: `Symbol`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `t`
[INFO] [stderr]   --> src/clause.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |             Some(t) => {
[INFO] [stderr]    |                  ^ help: consider using `_t` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/clause.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match single {
[INFO] [stderr] 50 | |             Some(t) => {
[INFO] [stderr] 51 | |                 
[INFO] [stderr] 52 | |             }
[INFO] [stderr] 53 | |             None => {}
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if let Some(t) = single {
[INFO] [stderr] 50 |     
[INFO] [stderr] 51 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/terms.rs:42:33
[INFO] [stderr]    |
[INFO] [stderr] 42 |     pub fn contains(&self, sym: &Symbol) -> bool {
[INFO] [stderr]    |                                 ^^^^^^^ help: consider passing by value instead: `Symbol`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/clause.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match single {
[INFO] [stderr] 50 | |             Some(t) => {
[INFO] [stderr] 51 | |                 
[INFO] [stderr] 52 | |             }
[INFO] [stderr] 53 | |             None => {}
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 |         if let Some(t) = single {
[INFO] [stderr] 50 |     
[INFO] [stderr] 51 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/tests.rs:15:17
[INFO] [stderr]    |
[INFO] [stderr] 15 |         assert!(s.state == true);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `s.state`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.72s
[INFO] running `"docker" "inspect" "408d50d9bd5e5a9522b4120d0dd3de65c9f0f4dc4456056d204094adf2c6c1f3"`
[INFO] running `"docker" "rm" "-f" "408d50d9bd5e5a9522b4120d0dd3de65c9f0f4dc4456056d204094adf2c6c1f3"`
[INFO] [stdout] 408d50d9bd5e5a9522b4120d0dd3de65c9f0f4dc4456056d204094adf2c6c1f3