[INFO] crate logwatcher 0.1.0 is already in cache [INFO] extracting crate logwatcher 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/logwatcher/0.1.0 [INFO] extracting crate logwatcher 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logwatcher/0.1.0 [INFO] validating manifest of logwatcher-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of logwatcher-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing logwatcher-0.1.0 [INFO] finished frobbing logwatcher-0.1.0 [INFO] frobbed toml for logwatcher-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/logwatcher/0.1.0/Cargo.toml [INFO] started frobbing logwatcher-0.1.0 [INFO] finished frobbing logwatcher-0.1.0 [INFO] frobbed toml for logwatcher-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logwatcher/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting logwatcher-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logwatcher/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bcc53c2a3262cb803fa42ce040f637c80711c1ea0cb4b70fb837d831334e80c [INFO] running `"docker" "start" "-a" "5bcc53c2a3262cb803fa42ce040f637c80711c1ea0cb4b70fb837d831334e80c"` [INFO] [stderr] Checking logwatcher v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(LogWatcher{filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(LogWatcher{filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | }else { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 89 | | if self.finish{ [INFO] [stderr] 90 | | break; [INFO] [stderr] 91 | | } [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | }else if self.finish{ [INFO] [stderr] 89 | break; [INFO] [stderr] 90 | } [INFO] [stderr] 91 | else{ [INFO] [stderr] 92 | self.reopen_if_log_rotated(callback); [INFO] [stderr] 93 | self.reader.seek(SeekFrom::Start(self.pos)).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | }else { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 89 | | if self.finish{ [INFO] [stderr] 90 | | break; [INFO] [stderr] 91 | | } [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 88 | }else if self.finish{ [INFO] [stderr] 89 | break; [INFO] [stderr] 90 | } [INFO] [stderr] 91 | else{ [INFO] [stderr] 92 | self.reopen_if_log_rotated(callback); [INFO] [stderr] 93 | self.reader.seek(SeekFrom::Start(self.pos)).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.37s [INFO] running `"docker" "inspect" "5bcc53c2a3262cb803fa42ce040f637c80711c1ea0cb4b70fb837d831334e80c"` [INFO] running `"docker" "rm" "-f" "5bcc53c2a3262cb803fa42ce040f637c80711c1ea0cb4b70fb837d831334e80c"` [INFO] [stdout] 5bcc53c2a3262cb803fa42ce040f637c80711c1ea0cb4b70fb837d831334e80c