[INFO] crate lock-free-stack 0.1.1 is already in cache [INFO] extracting crate lock-free-stack 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lock-free-stack/0.1.1 [INFO] extracting crate lock-free-stack 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lock-free-stack/0.1.1 [INFO] validating manifest of lock-free-stack-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lock-free-stack-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lock-free-stack-0.1.1 [INFO] finished frobbing lock-free-stack-0.1.1 [INFO] frobbed toml for lock-free-stack-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lock-free-stack/0.1.1/Cargo.toml [INFO] started frobbing lock-free-stack-0.1.1 [INFO] finished frobbing lock-free-stack-0.1.1 [INFO] frobbed toml for lock-free-stack-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lock-free-stack/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lock-free-stack-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lock-free-stack/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f37fb389e7a04aa6c8b61929d3a464164d5bdb37a4497a316b5023f1f4e1a2b [INFO] running `"docker" "start" "-a" "5f37fb389e7a04aa6c8b61929d3a464164d5bdb37a4497a316b5023f1f4e1a2b"` [INFO] [stderr] Checking lock-free-stack v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | unsafe { (&*top_ptr).size } [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `*top_ptr.size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:46:71 [INFO] [stderr] | [INFO] [stderr] 46 | let new_size = if top_ptr.is_null() { 1 } else { unsafe { (&*top_ptr).size + 1 } }; [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `*top_ptr.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | (&mut *new_top).size = new_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `*new_top.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | (&mut *new_top).next = top_ptr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `*new_top.next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lock_free_stack::Stack` [INFO] [stderr] --> src/lock_free_stack.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Stack { [INFO] [stderr] 24 | | Stack { top: AtomicPtr::new(ptr::null_mut()) } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | unsafe { (&*top_ptr).size } [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `*top_ptr.size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:46:71 [INFO] [stderr] | [INFO] [stderr] 46 | let new_size = if top_ptr.is_null() { 1 } else { unsafe { (&*top_ptr).size + 1 } }; [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `*top_ptr.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | (&mut *new_top).size = new_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `*new_top.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/lock_free_stack.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | (&mut *new_top).next = top_ptr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `*new_top.next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lock_free_stack::Stack` [INFO] [stderr] --> src/lock_free_stack.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Stack { [INFO] [stderr] 24 | | Stack { top: AtomicPtr::new(ptr::null_mut()) } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "5f37fb389e7a04aa6c8b61929d3a464164d5bdb37a4497a316b5023f1f4e1a2b"` [INFO] running `"docker" "rm" "-f" "5f37fb389e7a04aa6c8b61929d3a464164d5bdb37a4497a316b5023f1f4e1a2b"` [INFO] [stdout] 5f37fb389e7a04aa6c8b61929d3a464164d5bdb37a4497a316b5023f1f4e1a2b