[INFO] crate lexers 0.0.6 is already in cache [INFO] extracting crate lexers 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/lexers/0.0.6 [INFO] extracting crate lexers 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lexers/0.0.6 [INFO] validating manifest of lexers-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lexers-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lexers-0.0.6 [INFO] finished frobbing lexers-0.0.6 [INFO] frobbed toml for lexers-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/lexers/0.0.6/Cargo.toml [INFO] started frobbing lexers-0.0.6 [INFO] finished frobbing lexers-0.0.6 [INFO] frobbed toml for lexers-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lexers/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lexers-0.0.6 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lexers/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a77aa1d0635004c6297ad0b80dc3e8e1d7aeea3616aeaedab431d1d20937914c [INFO] running `"docker" "start" "-a" "a77aa1d0635004c6297ad0b80dc3e8e1d7aeea3616aeaedab431d1d20937914c"` [INFO] [stderr] Checking lexers v0.0.6 (/opt/crater/workdir) [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/lisp_tokenizer.rs:76:55 [INFO] [stderr] | [INFO] [stderr] 76 | vec![LispToken::OParen, LispToken::Symbol(format!("+")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"+".to_string()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lisp_tokenizer.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::useless_format)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/lisp_tokenizer.rs:79:55 [INFO] [stderr] | [INFO] [stderr] 79 | vec![LispToken::OParen, LispToken::Symbol(format!("max")), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"max".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/lisp_tokenizer.rs:80:54 [INFO] [stderr] | [INFO] [stderr] 80 | LispToken::Quote, LispToken::Symbol(format!("a")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"a".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/lisp_tokenizer.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | LispToken::String(format!("\"hello\"")), LispToken::CParen], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\"hello\"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | MathToken::BOp(format!("+")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"+".to_string()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/math_tokenizer.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | MathToken::BOp(format!("*")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"*".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | MathToken::BOp(format!("/")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"/".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | MathToken::UOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:93:28 [INFO] [stderr] | [INFO] [stderr] 93 | MathToken::BOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:96:28 [INFO] [stderr] | [INFO] [stderr] 96 | MathToken::BOp(format!("^")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"^".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | MathToken::BOp(format!("^")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"^".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:113:28 [INFO] [stderr] | [INFO] [stderr] 113 | MathToken::BOp(format!("*")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"*".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:114:33 [INFO] [stderr] | [INFO] [stderr] 114 | MathToken::Function(format!("sin"), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"sin".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:116:33 [INFO] [stderr] | [INFO] [stderr] 116 | MathToken::Variable(format!("x")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:118:28 [INFO] [stderr] | [INFO] [stderr] 118 | MathToken::BOp(format!("/")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"/".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | MathToken::UOp(format!("!")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"!".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:122:28 [INFO] [stderr] | [INFO] [stderr] 122 | MathToken::BOp(format!("%")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"%".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | MathToken::UOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:126:28 [INFO] [stderr] | [INFO] [stderr] 126 | MathToken::BOp(format!("*")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"*".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:127:33 [INFO] [stderr] | [INFO] [stderr] 127 | MathToken::Function(format!("max"), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"max".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:131:33 [INFO] [stderr] | [INFO] [stderr] 131 | MathToken::Variable(format!("x")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:145:33 [INFO] [stderr] | [INFO] [stderr] 145 | MathToken::Function(format!("sqrt"), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"sqrt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:147:28 [INFO] [stderr] | [INFO] [stderr] 147 | MathToken::UOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | MathToken::BOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:151:33 [INFO] [stderr] | [INFO] [stderr] 151 | MathToken::Variable(format!("x")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | MathToken::BOp(format!("^")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"^".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | MathToken::BOp(format!("/")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"/".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:158:28 [INFO] [stderr] | [INFO] [stderr] 158 | MathToken::BOp(format!("+")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"+".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:159:33 [INFO] [stderr] | [INFO] [stderr] 159 | MathToken::Variable(format!("x")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:160:28 [INFO] [stderr] | [INFO] [stderr] 160 | MathToken::BOp(format!("^")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"^".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:176:33 [INFO] [stderr] | [INFO] [stderr] 176 | MathToken::Variable(format!("x")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"x".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:177:28 [INFO] [stderr] | [INFO] [stderr] 177 | MathToken::BOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:178:28 [INFO] [stderr] | [INFO] [stderr] 178 | MathToken::UOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:179:28 [INFO] [stderr] | [INFO] [stderr] 179 | MathToken::UOp(format!("-")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:180:33 [INFO] [stderr] | [INFO] [stderr] 180 | MathToken::Variable(format!("y")), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `"y".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: useless use of `format!` [INFO] [stderr] --> src/math_tokenizer.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | MathToken::Function(format!("max"), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"max".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 36 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lexers`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a77aa1d0635004c6297ad0b80dc3e8e1d7aeea3616aeaedab431d1d20937914c"` [INFO] running `"docker" "rm" "-f" "a77aa1d0635004c6297ad0b80dc3e8e1d7aeea3616aeaedab431d1d20937914c"` [INFO] [stdout] a77aa1d0635004c6297ad0b80dc3e8e1d7aeea3616aeaedab431d1d20937914c