[INFO] crate lehmer 3.0.0 is already in cache [INFO] extracting crate lehmer 3.0.0 into work/ex/clippy-test-run/sources/stable/reg/lehmer/3.0.0 [INFO] extracting crate lehmer 3.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lehmer/3.0.0 [INFO] validating manifest of lehmer-3.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lehmer-3.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lehmer-3.0.0 [INFO] finished frobbing lehmer-3.0.0 [INFO] frobbed toml for lehmer-3.0.0 written to work/ex/clippy-test-run/sources/stable/reg/lehmer/3.0.0/Cargo.toml [INFO] started frobbing lehmer-3.0.0 [INFO] finished frobbing lehmer-3.0.0 [INFO] frobbed toml for lehmer-3.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lehmer/3.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lehmer-3.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lehmer/3.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c327c2b07ae2db1abdc4e63ded60f9a88e0ad55cdab3f4f38573b3ce5e49337c [INFO] running `"docker" "start" "-a" "c327c2b07ae2db1abdc4e63ded60f9a88e0ad55cdab3f4f38573b3ce5e49337c"` [INFO] [stderr] Checking lehmer v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut code: Vec = Vec::with_capacity(n); [INFO] [stderr] | --------------------- help: consider replace allocation with: `vec![0; n]` [INFO] [stderr] 23 | code.resize(n, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_string/test.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(2147483653, subject.b); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_653` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn to_permutation(mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn to_decimal(self) -> usize { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | for i in (0..n+1).skip(1) { [INFO] [stderr] | ^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut code: Vec = Vec::with_capacity(n); [INFO] [stderr] | --------------------- help: consider replace allocation with: `vec![0; n]` [INFO] [stderr] 23 | code.resize(n, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn to_permutation(mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn to_decimal(self) -> usize { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | for i in (0..n+1).skip(1) { [INFO] [stderr] | ^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "c327c2b07ae2db1abdc4e63ded60f9a88e0ad55cdab3f4f38573b3ce5e49337c"` [INFO] running `"docker" "rm" "-f" "c327c2b07ae2db1abdc4e63ded60f9a88e0ad55cdab3f4f38573b3ce5e49337c"` [INFO] [stdout] c327c2b07ae2db1abdc4e63ded60f9a88e0ad55cdab3f4f38573b3ce5e49337c