[INFO] crate lcs 0.2.0 is already in cache [INFO] extracting crate lcs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/lcs/0.2.0 [INFO] extracting crate lcs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lcs/0.2.0 [INFO] validating manifest of lcs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lcs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lcs-0.2.0 [INFO] finished frobbing lcs-0.2.0 [INFO] frobbed toml for lcs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/lcs/0.2.0/Cargo.toml [INFO] started frobbing lcs-0.2.0 [INFO] finished frobbing lcs-0.2.0 [INFO] frobbed toml for lcs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lcs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lcs-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lcs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac3cd48d3aee7e2ea95da875aaf6ba139f864caa1999f7dd1d42f75e9b4fca3e [INFO] running `"docker" "start" "-a" "ac3cd48d3aee7e2ea95da875aaf6ba139f864caa1999f7dd1d42f75e9b4fca3e"` [INFO] [stderr] Checking lcs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | LcsTable { lengths: lengths, a: a, b: b } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lengths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:38 [INFO] [stderr] | [INFO] [stderr] 46 | LcsTable { lengths: lengths, a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:44 [INFO] [stderr] | [INFO] [stderr] 46 | LcsTable { lengths: lengths, a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | LcsTable { lengths: lengths, a: a, b: b } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lengths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:38 [INFO] [stderr] | [INFO] [stderr] 46 | LcsTable { lengths: lengths, a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:44 [INFO] [stderr] | [INFO] [stderr] 46 | LcsTable { lengths: lengths, a: a, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 80 | | if self.lengths[i][j - 1] > self.lengths[i - 1][j] { [INFO] [stderr] 81 | | self.find_lcs(i, j - 1) [INFO] [stderr] 82 | | } else { [INFO] [stderr] 83 | | self.find_lcs(i - 1, j) [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | } else if self.lengths[i][j - 1] > self.lengths[i - 1][j] { [INFO] [stderr] 80 | self.find_lcs(i, j - 1) [INFO] [stderr] 81 | } else { [INFO] [stderr] 82 | self.find_lcs(i - 1, j) [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 80 | | if self.lengths[i][j - 1] > self.lengths[i - 1][j] { [INFO] [stderr] 81 | | self.find_lcs(i, j - 1) [INFO] [stderr] 82 | | } else { [INFO] [stderr] 83 | | self.find_lcs(i - 1, j) [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 79 | } else if self.lengths[i][j - 1] > self.lengths[i - 1][j] { [INFO] [stderr] 80 | self.find_lcs(i, j - 1) [INFO] [stderr] 81 | } else { [INFO] [stderr] 82 | self.find_lcs(i - 1, j) [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `b` [INFO] [stderr] --> src/lib.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | for j in 0..b.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (j, ) in b.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `b` [INFO] [stderr] --> src/lib.rs:37:22 [INFO] [stderr] | [INFO] [stderr] 37 | for j in 0..b.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (j, ) in b.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "ac3cd48d3aee7e2ea95da875aaf6ba139f864caa1999f7dd1d42f75e9b4fca3e"` [INFO] running `"docker" "rm" "-f" "ac3cd48d3aee7e2ea95da875aaf6ba139f864caa1999f7dd1d42f75e9b4fca3e"` [INFO] [stdout] ac3cd48d3aee7e2ea95da875aaf6ba139f864caa1999f7dd1d42f75e9b4fca3e