[INFO] crate lcd-ili9341 0.1.0 is already in cache [INFO] extracting crate lcd-ili9341 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/lcd-ili9341/0.1.0 [INFO] extracting crate lcd-ili9341 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lcd-ili9341/0.1.0 [INFO] validating manifest of lcd-ili9341-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lcd-ili9341-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lcd-ili9341-0.1.0 [INFO] finished frobbing lcd-ili9341-0.1.0 [INFO] frobbed toml for lcd-ili9341-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/lcd-ili9341/0.1.0/Cargo.toml [INFO] started frobbing lcd-ili9341-0.1.0 [INFO] finished frobbing lcd-ili9341-0.1.0 [INFO] frobbed toml for lcd-ili9341-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lcd-ili9341/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lcd-ili9341-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lcd-ili9341/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 731e4d9df9af10589bf59a341e113bc8b3aacd2eaab8e579e936e7722b2251ec [INFO] running `"docker" "start" "-a" "731e4d9df9af10589bf59a341e113bc8b3aacd2eaab8e579e936e7722b2251ec"` [INFO] [stderr] Checking lcd-ili9341 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | iface: iface, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | iface: iface, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let command = match on { [INFO] [stderr] | _______________________^ [INFO] [stderr] 175 | | false => 0x20, [INFO] [stderr] 176 | | true => 0x21, [INFO] [stderr] 177 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if on { 0x21 } else { 0x20 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let command = match on { [INFO] [stderr] | _______________________^ [INFO] [stderr] 187 | | false => 0x28, [INFO] [stderr] 188 | | true => 0x29, [INFO] [stderr] 189 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if on { 0x29 } else { 0x28 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | let command = match on { [INFO] [stderr] | _______________________^ [INFO] [stderr] 254 | | false => 0x38, [INFO] [stderr] 255 | | true => 0x39, [INFO] [stderr] 256 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if on { 0x39 } else { 0x38 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:291:4 [INFO] [stderr] | [INFO] [stderr] 291 | ((result[0] as u16) << 8) | result[1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(result[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:291:31 [INFO] [stderr] | [INFO] [stderr] 291 | ((result[0] as u16) << 8) | result[1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(result[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let command = match on { [INFO] [stderr] | _______________________^ [INFO] [stderr] 175 | | false => 0x20, [INFO] [stderr] 176 | | true => 0x21, [INFO] [stderr] 177 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if on { 0x21 } else { 0x20 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let command = match on { [INFO] [stderr] | _______________________^ [INFO] [stderr] 187 | | false => 0x28, [INFO] [stderr] 188 | | true => 0x29, [INFO] [stderr] 189 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if on { 0x29 } else { 0x28 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | let command = match on { [INFO] [stderr] | _______________________^ [INFO] [stderr] 254 | | false => 0x38, [INFO] [stderr] 255 | | true => 0x39, [INFO] [stderr] 256 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if on { 0x39 } else { 0x38 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:291:4 [INFO] [stderr] | [INFO] [stderr] 291 | ((result[0] as u16) << 8) | result[1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(result[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:291:31 [INFO] [stderr] | [INFO] [stderr] 291 | ((result[0] as u16) << 8) | result[1] as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(result[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "731e4d9df9af10589bf59a341e113bc8b3aacd2eaab8e579e936e7722b2251ec"` [INFO] running `"docker" "rm" "-f" "731e4d9df9af10589bf59a341e113bc8b3aacd2eaab8e579e936e7722b2251ec"` [INFO] [stdout] 731e4d9df9af10589bf59a341e113bc8b3aacd2eaab8e579e936e7722b2251ec