[INFO] crate lazy_bencoding 0.1.1 is already in cache [INFO] extracting crate lazy_bencoding 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lazy_bencoding/0.1.1 [INFO] extracting crate lazy_bencoding 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_bencoding/0.1.1 [INFO] validating manifest of lazy_bencoding-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lazy_bencoding-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lazy_bencoding-0.1.1 [INFO] finished frobbing lazy_bencoding-0.1.1 [INFO] frobbed toml for lazy_bencoding-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lazy_bencoding/0.1.1/Cargo.toml [INFO] started frobbing lazy_bencoding-0.1.1 [INFO] finished frobbing lazy_bencoding-0.1.1 [INFO] frobbed toml for lazy_bencoding-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_bencoding/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lazy_bencoding-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lazy_bencoding/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 52b454da8cf4c686421b25591020322e3ee0c84b49c5453a72e647faa131bd1b [INFO] running `"docker" "start" "-a" "52b454da8cf4c686421b25591020322e3ee0c84b49c5453a72e647faa131bd1b"` [INFO] [stderr] Checking lazy_bencoding v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bencoded.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bencoded.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / pub fn parse_token<'a>(data: &'a [u8]) -> Option<(Token<'a>, &'a [u8])> { [INFO] [stderr] 4 | | if data.len() < 1 { [INFO] [stderr] 5 | | // Already done [INFO] [stderr] 6 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parse.rs:4:8 [INFO] [stderr] | [INFO] [stderr] 4 | if data.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/traverse.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match s[0] as char { [INFO] [stderr] 52 | | '-' => { [INFO] [stderr] 53 | | sig = -1; [INFO] [stderr] 54 | | position += 1; [INFO] [stderr] 55 | | }, [INFO] [stderr] 56 | | _ => (), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let '-' = s[0] as char { [INFO] [stderr] 52 | sig = -1; [INFO] [stderr] 53 | position += 1; [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/traverse.rs:63:44 [INFO] [stderr] | [INFO] [stderr] 63 | value = (value * 10) + *ch as i64 - '0' as i64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(*ch)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/traverse.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / match self.next() { [INFO] [stderr] 79 | | None => return None, [INFO] [stderr] 80 | | _ => (), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____________^ help: try this: `if let None = self.next() { return None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/dict.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if self.data.len() < 1 || self.data[0] as char == 'e' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/list.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if self.data.len() < 1 || self.data[0] as char == 'e' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / pub fn parse_token<'a>(data: &'a [u8]) -> Option<(Token<'a>, &'a [u8])> { [INFO] [stderr] 4 | | if data.len() < 1 { [INFO] [stderr] 5 | | // Already done [INFO] [stderr] 6 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parse.rs:4:8 [INFO] [stderr] | [INFO] [stderr] 4 | if data.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/traverse.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match s[0] as char { [INFO] [stderr] 52 | | '-' => { [INFO] [stderr] 53 | | sig = -1; [INFO] [stderr] 54 | | position += 1; [INFO] [stderr] 55 | | }, [INFO] [stderr] 56 | | _ => (), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | if let '-' = s[0] as char { [INFO] [stderr] 52 | sig = -1; [INFO] [stderr] 53 | position += 1; [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/traverse.rs:63:44 [INFO] [stderr] | [INFO] [stderr] 63 | value = (value * 10) + *ch as i64 - '0' as i64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(*ch)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/traverse.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | / match self.next() { [INFO] [stderr] 79 | | None => return None, [INFO] [stderr] 80 | | _ => (), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____________^ help: try this: `if let None = self.next() { return None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/dict.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if self.data.len() < 1 || self.data[0] as char == 'e' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/list.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if self.data.len() < 1 || self.data[0] as char == 'e' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> examples/print_torrent.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | .map(|c| ' ').collect(); [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> examples/print_torrent.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if i & 15 == 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> examples/print_torrent.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | } else if i & 7 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: try: `i.trailing_zeros() >= 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> examples/print_torrent.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | } else if i & 3 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: try: `i.trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/print_torrent.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "52b454da8cf4c686421b25591020322e3ee0c84b49c5453a72e647faa131bd1b"` [INFO] running `"docker" "rm" "-f" "52b454da8cf4c686421b25591020322e3ee0c84b49c5453a72e647faa131bd1b"` [INFO] [stdout] 52b454da8cf4c686421b25591020322e3ee0c84b49c5453a72e647faa131bd1b