[INFO] crate larry 0.1.0 is already in cache
[INFO] extracting crate larry 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/larry/0.1.0
[INFO] extracting crate larry 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/larry/0.1.0
[INFO] validating manifest of larry-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of larry-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing larry-0.1.0
[INFO] finished frobbing larry-0.1.0
[INFO] frobbed toml for larry-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/larry/0.1.0/Cargo.toml
[INFO] started frobbing larry-0.1.0
[INFO] finished frobbing larry-0.1.0
[INFO] frobbed toml for larry-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/larry/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting larry-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/larry/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 54efff3641c50c9ed6b39bc14b0ce14c04c188795fb7cc2916a4d88915d432e4
[INFO] running `"docker" "start" "-a" "54efff3641c50c9ed6b39bc14b0ce14c04c188795fb7cc2916a4d88915d432e4"`
[INFO] [stderr]     Checking larry v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:124:21
[INFO] [stderr]     |
[INFO] [stderr] 124 |                     lines: lines,
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `lines`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:124:21
[INFO] [stderr]     |
[INFO] [stderr] 124 |                     lines: lines,
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `lines`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:71:52
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                               } else {
[INFO] [stderr]    |  ____________________________________________________^
[INFO] [stderr] 72 | |                                                 if last_was_0a {
[INFO] [stderr] 73 | |                                                     lines.push(Line::new(offset));
[INFO] [stderr] 74 | |                                                     offset += length - 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |                                                 }
[INFO] [stderr] 79 | |                                             }
[INFO] [stderr]    | |_____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                             } else if last_was_0a {
[INFO] [stderr] 72 |     lines.push(Line::new(offset));
[INFO] [stderr] 73 |     offset += length - 1;
[INFO] [stderr] 74 |     length = 1;
[INFO] [stderr] 75 | } else {
[INFO] [stderr] 76 |     last_was_0a = true;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:88:52
[INFO] [stderr]    |
[INFO] [stderr] 88 |                                               } else {
[INFO] [stderr]    |  ____________________________________________________^
[INFO] [stderr] 89 | |                                                 if last_was_0d {
[INFO] [stderr] 90 | |                                                     lines.push(Line::new(offset));
[INFO] [stderr] 91 | |                                                     offset += length - 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 95 | |                                                 }
[INFO] [stderr] 96 | |                                             }
[INFO] [stderr]    | |_____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |                                             } else if last_was_0d {
[INFO] [stderr] 89 |     lines.push(Line::new(offset));
[INFO] [stderr] 90 |     offset += length - 1;
[INFO] [stderr] 91 |     length = 1;
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |     last_was_0d = true;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:152:16
[INFO] [stderr]     |
[INFO] [stderr] 152 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 153 | |             if self.lines[i].text.is_some() {
[INFO] [stderr] 154 | |                 Ok(self.lines[i].text.clone().unwrap())
[INFO] [stderr] 155 | |             } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |             }
[INFO] [stderr] 172 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 152 |         } else if self.lines[i].text.is_some() {
[INFO] [stderr] 153 |     Ok(self.lines[i].text.clone().unwrap())
[INFO] [stderr] 154 | } else {
[INFO] [stderr] 155 |     let length = if i == self.lines.len() - 1 {
[INFO] [stderr] 156 |         self.length - self.lines[i].offset
[INFO] [stderr] 157 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:71:52
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                               } else {
[INFO] [stderr]    |  ____________________________________________________^
[INFO] [stderr] 72 | |                                                 if last_was_0a {
[INFO] [stderr] 73 | |                                                     lines.push(Line::new(offset));
[INFO] [stderr] 74 | |                                                     offset += length - 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |                                                 }
[INFO] [stderr] 79 | |                                             }
[INFO] [stderr]    | |_____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                             } else if last_was_0a {
[INFO] [stderr] 72 |     lines.push(Line::new(offset));
[INFO] [stderr] 73 |     offset += length - 1;
[INFO] [stderr] 74 |     length = 1;
[INFO] [stderr] 75 | } else {
[INFO] [stderr] 76 |     last_was_0a = true;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:88:52
[INFO] [stderr]    |
[INFO] [stderr] 88 |                                               } else {
[INFO] [stderr]    |  ____________________________________________________^
[INFO] [stderr] 89 | |                                                 if last_was_0d {
[INFO] [stderr] 90 | |                                                     lines.push(Line::new(offset));
[INFO] [stderr] 91 | |                                                     offset += length - 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 95 | |                                                 }
[INFO] [stderr] 96 | |                                             }
[INFO] [stderr]    | |_____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |                                             } else if last_was_0d {
[INFO] [stderr] 89 |     lines.push(Line::new(offset));
[INFO] [stderr] 90 |     offset += length - 1;
[INFO] [stderr] 91 |     length = 1;
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |     last_was_0d = true;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:152:16
[INFO] [stderr]     |
[INFO] [stderr] 152 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 153 | |             if self.lines[i].text.is_some() {
[INFO] [stderr] 154 | |                 Ok(self.lines[i].text.clone().unwrap())
[INFO] [stderr] 155 | |             } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |             }
[INFO] [stderr] 172 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 152 |         } else if self.lines[i].text.is_some() {
[INFO] [stderr] 153 |     Ok(self.lines[i].text.clone().unwrap())
[INFO] [stderr] 154 | } else {
[INFO] [stderr] 155 |     let length = if i == self.lines.len() - 1 {
[INFO] [stderr] 156 |         self.length - self.lines[i].offset
[INFO] [stderr] 157 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: item `Larry` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:29:1
[INFO] [stderr]     |
[INFO] [stderr] 29  | / impl Larry {
[INFO] [stderr] 30  | |     /// Constructs a new `Larry`.
[INFO] [stderr] 31  | |     ///
[INFO] [stderr] 32  | |     /// Construction requires that the file be scanned for line-terminal byte
[INFO] [stderr] ...   |
[INFO] [stderr] 186 | |     }
[INFO] [stderr] 187 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:58:36
[INFO] [stderr]    |
[INFO] [stderr] 58 |                                 if buffer.len() == 0 {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`.
[INFO] [stderr]   --> src/lib.rs:61:42
[INFO] [stderr]    |
[INFO] [stderr] 61 |                                 for i in 0..buffer.len() {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 61 |                                 for <item> in &buffer {
[INFO] [stderr]    |                                     ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: item `Larry` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:29:1
[INFO] [stderr]     |
[INFO] [stderr] 29  | / impl Larry {
[INFO] [stderr] 30  | |     /// Constructs a new `Larry`.
[INFO] [stderr] 31  | |     ///
[INFO] [stderr] 32  | |     /// Construction requires that the file be scanned for line-terminal byte
[INFO] [stderr] ...   |
[INFO] [stderr] 186 | |     }
[INFO] [stderr] 187 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:58:36
[INFO] [stderr]    |
[INFO] [stderr] 58 |                                 if buffer.len() == 0 {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`.
[INFO] [stderr]   --> src/lib.rs:61:42
[INFO] [stderr]    |
[INFO] [stderr] 61 |                                 for i in 0..buffer.len() {
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 61 |                                 for <item> in &buffer {
[INFO] [stderr]    |                                     ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> tests/lib.rs:18:16
[INFO] [stderr]    |
[INFO] [stderr] 18 |           if let Err(_) = larry.get(lines.len() + 1) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 19 | |             assert!(true, "cannot read past end of file");
[INFO] [stderr] 20 | |         } else {
[INFO] [stderr] 21 | |             assert!(false, "read past end of file");
[INFO] [stderr] 22 | |         }
[INFO] [stderr]    | |_________- help: try this: `if larry.get(lines.len() + 1).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "54efff3641c50c9ed6b39bc14b0ce14c04c188795fb7cc2916a4d88915d432e4"`
[INFO] running `"docker" "rm" "-f" "54efff3641c50c9ed6b39bc14b0ce14c04c188795fb7cc2916a4d88915d432e4"`
[INFO] [stdout] 54efff3641c50c9ed6b39bc14b0ce14c04c188795fb7cc2916a4d88915d432e4