[INFO] crate labware_tracker 0.1.0 is already in cache [INFO] extracting crate labware_tracker 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/labware_tracker/0.1.0 [INFO] extracting crate labware_tracker 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/labware_tracker/0.1.0 [INFO] validating manifest of labware_tracker-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of labware_tracker-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing labware_tracker-0.1.0 [INFO] finished frobbing labware_tracker-0.1.0 [INFO] frobbed toml for labware_tracker-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/labware_tracker/0.1.0/Cargo.toml [INFO] started frobbing labware_tracker-0.1.0 [INFO] finished frobbing labware_tracker-0.1.0 [INFO] frobbed toml for labware_tracker-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/labware_tracker/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting labware_tracker-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/labware_tracker/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df1a2cc3d1075d972da8daf447774fd463937f0cdc5a948c90c44c77104fa271 [INFO] running `"docker" "start" "-a" "df1a2cc3d1075d972da8daf447774fd463937f0cdc5a948c90c44c77104fa271"` [INFO] [stderr] Checking labware_tracker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/labware.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | Labware { id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/labware.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | Labware { id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/labware_collection.rs:22:74 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn add(&mut self, name: &str, timestamp: &str, labware_type: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/labware_collection.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn remove(&mut self, id: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/loader.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn write_file(labwares: LabwareCollection, path: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/labware_collection.rs:22:74 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn add(&mut self, name: &str, timestamp: &str, labware_type: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/labware_collection.rs:31:37 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn remove(&mut self, id: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/loader.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn write_file(labwares: LabwareCollection, path: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `labware_collection::LabwareCollection` [INFO] [stderr] --> src/labware_collection.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | LabwareCollection{ items: Vec::::new() } [INFO] [stderr] 12 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `labware_collection::LabwareCollection` [INFO] [stderr] --> src/labware_collection.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | LabwareCollection{ items: Vec::::new() } [INFO] [stderr] 12 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("couldn't open {}:", display), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/loader.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | / match f.read_to_string(&mut s) { [INFO] [stderr] 19 | | Err(_) => panic!("couldn't read {}:", display), [INFO] [stderr] 20 | | Ok(_) => (), [INFO] [stderr] 21 | | }; [INFO] [stderr] | |___^ help: try this: `if let Err(_) = f.read_to_string(&mut s) { panic!("couldn't read {}:", display) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("couldn't read {}:", display), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Err(_) => panic!("couldn't create {}:", display), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("couldn't open {}:", display), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/loader.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | / match f.read_to_string(&mut s) { [INFO] [stderr] 19 | | Err(_) => panic!("couldn't read {}:", display), [INFO] [stderr] 20 | | Ok(_) => (), [INFO] [stderr] 21 | | }; [INFO] [stderr] | |___^ help: try this: `if let Err(_) = f.read_to_string(&mut s) { panic!("couldn't read {}:", display) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("couldn't read {}:", display), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Err(_) => panic!("couldn't create {}:", display), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/loader.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "df1a2cc3d1075d972da8daf447774fd463937f0cdc5a948c90c44c77104fa271"` [INFO] running `"docker" "rm" "-f" "df1a2cc3d1075d972da8daf447774fd463937f0cdc5a948c90c44c77104fa271"` [INFO] [stdout] df1a2cc3d1075d972da8daf447774fd463937f0cdc5a948c90c44c77104fa271