[INFO] crate kompact-component-derive 0.4.0 is already in cache [INFO] extracting crate kompact-component-derive 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/kompact-component-derive/0.4.0 [INFO] extracting crate kompact-component-derive 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kompact-component-derive/0.4.0 [INFO] validating manifest of kompact-component-derive-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kompact-component-derive-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kompact-component-derive-0.4.0 [INFO] finished frobbing kompact-component-derive-0.4.0 [INFO] frobbed toml for kompact-component-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/kompact-component-derive/0.4.0/Cargo.toml [INFO] started frobbing kompact-component-derive-0.4.0 [INFO] finished frobbing kompact-component-derive-0.4.0 [INFO] frobbed toml for kompact-component-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kompact-component-derive/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kompact-component-derive-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/kompact-component-derive/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4202a3605e4aba551351bbe054f7977e7cfcb44bcc3f03da53802c021a23927a [INFO] running `"docker" "start" "-a" "4202a3605e4aba551351bbe054f7977e7cfcb44bcc3f03da53802c021a23927a"` [INFO] [stderr] Checking kompact-component-derive v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | const REQP: &'static str = "RequiredPort"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:168:15 [INFO] [stderr] | [INFO] [stderr] 168 | const PROVP: &'static str = "ProvidedPort"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | const CTX: &'static str = "ComponentContext"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | const KOMPICS: &'static str = "kompics"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | const REQP: &'static str = "RequiredPort"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:168:15 [INFO] [stderr] | [INFO] [stderr] 168 | const PROVP: &'static str = "ProvidedPort"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | const CTX: &'static str = "ComponentContext"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | const KOMPICS: &'static str = "kompics"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match self { [INFO] [stderr] 161 | | &PortField::Provided(ref ty) => quote! { Provide::<#ty>::handle(self, event); }, [INFO] [stderr] 162 | | &PortField::Required(ref ty) => quote! { Require::<#ty>::handle(self, event); }, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *self { [INFO] [stderr] 161 | PortField::Provided(ref ty) => quote! { Provide::<#ty>::handle(self, event); }, [INFO] [stderr] 162 | PortField::Required(ref ty) => quote! { Require::<#ty>::handle(self, event); }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | let ref id = f.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let id = &f.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match self { [INFO] [stderr] 161 | | &PortField::Provided(ref ty) => quote! { Provide::<#ty>::handle(self, event); }, [INFO] [stderr] 162 | | &PortField::Required(ref ty) => quote! { Require::<#ty>::handle(self, event); }, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *self { [INFO] [stderr] 161 | PortField::Provided(ref ty) => quote! { Provide::<#ty>::handle(self, event); }, [INFO] [stderr] 162 | PortField::Required(ref ty) => quote! { Require::<#ty>::handle(self, event); }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "4202a3605e4aba551351bbe054f7977e7cfcb44bcc3f03da53802c021a23927a"` [INFO] running `"docker" "rm" "-f" "4202a3605e4aba551351bbe054f7977e7cfcb44bcc3f03da53802c021a23927a"` [INFO] [stdout] 4202a3605e4aba551351bbe054f7977e7cfcb44bcc3f03da53802c021a23927a