[INFO] crate josephine_derive 0.1.0 is already in cache [INFO] extracting crate josephine_derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/josephine_derive/0.1.0 [INFO] extracting crate josephine_derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/josephine_derive/0.1.0 [INFO] validating manifest of josephine_derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of josephine_derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing josephine_derive-0.1.0 [INFO] finished frobbing josephine_derive-0.1.0 [INFO] frobbed toml for josephine_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/josephine_derive/0.1.0/Cargo.toml [INFO] started frobbing josephine_derive-0.1.0 [INFO] finished frobbing josephine_derive-0.1.0 [INFO] frobbed toml for josephine_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/josephine_derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting josephine_derive-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/josephine_derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59c1d6e6e88aa7ef655210226e1015e349c4e1a4f92bcd9a19ac3b530048ea91 [INFO] running `"docker" "start" "-a" "59c1d6e6e88aa7ef655210226e1015e349c4e1a4f92bcd9a19ac3b530048ea91"` [INFO] [stderr] Checking synstructure v0.5.2 [INFO] [stderr] Checking josephine_derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let ref lifetimes_and_d: Vec<_> = ast.generics.lifetimes.iter().map(|lifetime| lifetime.lifetime.ident.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | let lifetimes_and_d: &Vec<_> = &ast.generics.lifetimes.iter().map(|lifetime| lifetime.lifetime.ident.clone()) [INFO] [stderr] 92 | .chain(iter::once(syn::Ident::from("D"))) [INFO] [stderr] 93 | .collect::>(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `synstructure::each_field` doesn't need a mutable reference [INFO] [stderr] --> lib.rs:182:47 [INFO] [stderr] | [INFO] [stderr] 182 | let match_body = synstructure::each_field(&mut type_, &style, |binding| { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let ref lifetimes_and_d: Vec<_> = ast.generics.lifetimes.iter().map(|lifetime| lifetime.lifetime.ident.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | let lifetimes_and_d: &Vec<_> = &ast.generics.lifetimes.iter().map(|lifetime| lifetime.lifetime.ident.clone()) [INFO] [stderr] 92 | .chain(iter::once(syn::Ident::from("D"))) [INFO] [stderr] 93 | .collect::>(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `synstructure::each_field` doesn't need a mutable reference [INFO] [stderr] --> lib.rs:182:47 [INFO] [stderr] | [INFO] [stderr] 182 | let match_body = synstructure::each_field(&mut type_, &style, |binding| { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `"docker" "inspect" "59c1d6e6e88aa7ef655210226e1015e349c4e1a4f92bcd9a19ac3b530048ea91"` [INFO] running `"docker" "rm" "-f" "59c1d6e6e88aa7ef655210226e1015e349c4e1a4f92bcd9a19ac3b530048ea91"` [INFO] [stdout] 59c1d6e6e88aa7ef655210226e1015e349c4e1a4f92bcd9a19ac3b530048ea91