[INFO] crate jobpool 0.3.8 is already in cache [INFO] extracting crate jobpool 0.3.8 into work/ex/clippy-test-run/sources/stable/reg/jobpool/0.3.8 [INFO] extracting crate jobpool 0.3.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jobpool/0.3.8 [INFO] validating manifest of jobpool-0.3.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jobpool-0.3.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jobpool-0.3.8 [INFO] finished frobbing jobpool-0.3.8 [INFO] frobbed toml for jobpool-0.3.8 written to work/ex/clippy-test-run/sources/stable/reg/jobpool/0.3.8/Cargo.toml [INFO] started frobbing jobpool-0.3.8 [INFO] finished frobbing jobpool-0.3.8 [INFO] frobbed toml for jobpool-0.3.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jobpool/0.3.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jobpool-0.3.8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/jobpool/0.3.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf6ad6c2239523720b6fef49e86394dfb0aadba753dea089838962d674cbfd6d [INFO] running `"docker" "start" "-a" "bf6ad6c2239523720b6fef49e86394dfb0aadba753dea089838962d674cbfd6d"` [INFO] [stderr] Checking jobpool v0.3.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jobpool.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jobpool.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/jobpool.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / if auto_grow { [INFO] [stderr] 124 | | if guard.workers.len() > *min_size && guard.busy_workers < *min_size { [INFO] [stderr] 125 | | let worker = guard.workers.remove(&id); [INFO] [stderr] 126 | | if let Some(worker) = worker { [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 123 | if auto_grow && guard.workers.len() > *min_size && guard.busy_workers < *min_size { [INFO] [stderr] 124 | let worker = guard.workers.remove(&id); [INFO] [stderr] 125 | if let Some(worker) = worker { [INFO] [stderr] 126 | if let Some(handle) = worker.handle { [INFO] [stderr] 127 | guard.removed_handles.push(Some(handle)); [INFO] [stderr] 128 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/jobpool.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | / if auto_grow { [INFO] [stderr] 124 | | if guard.workers.len() > *min_size && guard.busy_workers < *min_size { [INFO] [stderr] 125 | | let worker = guard.workers.remove(&id); [INFO] [stderr] 126 | | if let Some(worker) = worker { [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 123 | if auto_grow && guard.workers.len() > *min_size && guard.busy_workers < *min_size { [INFO] [stderr] 124 | let worker = guard.workers.remove(&id); [INFO] [stderr] 125 | if let Some(worker) = worker { [INFO] [stderr] 126 | if let Some(handle) = worker.handle { [INFO] [stderr] 127 | guard.removed_handles.push(Some(handle)); [INFO] [stderr] 128 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/jobpool.rs:451:32 [INFO] [stderr] | [INFO] [stderr] 451 | for (_, worker) in &mut guard.workers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 451 | for worker in guard.workers.values_mut() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/jobpool.rs:516:28 [INFO] [stderr] | [INFO] [stderr] 516 | for (_, worker) in &mut guard.workers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 516 | for worker in guard.workers.values_mut() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/jobpool.rs:451:32 [INFO] [stderr] | [INFO] [stderr] 451 | for (_, worker) in &mut guard.workers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 451 | for worker in guard.workers.values_mut() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/jobpool.rs:516:28 [INFO] [stderr] | [INFO] [stderr] 516 | for (_, worker) in &mut guard.workers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 516 | for worker in guard.workers.values_mut() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | pair: (Mutex::new(false), Condvar::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/queue.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `jobpool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "bf6ad6c2239523720b6fef49e86394dfb0aadba753dea089838962d674cbfd6d"` [INFO] running `"docker" "rm" "-f" "bf6ad6c2239523720b6fef49e86394dfb0aadba753dea089838962d674cbfd6d"` [INFO] [stdout] bf6ad6c2239523720b6fef49e86394dfb0aadba753dea089838962d674cbfd6d