[INFO] crate irc_message 1.0.0 is already in cache [INFO] extracting crate irc_message 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/irc_message/1.0.0 [INFO] extracting crate irc_message 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/irc_message/1.0.0 [INFO] validating manifest of irc_message-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of irc_message-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing irc_message-1.0.0 [INFO] finished frobbing irc_message-1.0.0 [INFO] frobbed toml for irc_message-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/irc_message/1.0.0/Cargo.toml [INFO] started frobbing irc_message-1.0.0 [INFO] finished frobbing irc_message-1.0.0 [INFO] frobbed toml for irc_message-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/irc_message/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting irc_message-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/irc_message/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0eb6342a37d02b1546980f23bc94b3ee620614e286f0ca9f9392ddfb1381139 [INFO] running `"docker" "start" "-a" "f0eb6342a37d02b1546980f23bc94b3ee620614e286f0ca9f9392ddfb1381139"` [INFO] [stderr] Checking irc_message v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | return Some(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(message)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:9:36 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:9:36 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(topic.prefix, Some(("test!me@test.ing"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:42:35 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(topic.prefix, Some(("test!me@test.ing"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:43:36 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:43:36 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(topic.command, Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(topic.prefix, Some(("test"))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:115:36 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:115:36 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(topic.command, Some(("PRIVMSG"))); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:127:42 [INFO] [stderr] | [INFO] [stderr] 127 | assert!(topic.tags[("best")] == Some(("super"))); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:127:42 [INFO] [stderr] | [INFO] [stderr] 127 | assert!(topic.tags[("best")] == Some(("super"))); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | assert!(topic.prefix == Some(("test!me@test.ing"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | assert!(topic.prefix == Some(("test!me@test.ing"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:130:35 [INFO] [stderr] | [INFO] [stderr] 130 | assert!(topic.command == Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests.rs:130:35 [INFO] [stderr] | [INFO] [stderr] 130 | assert!(topic.command == Some(("FOO"))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | return Some(message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(message)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match v { [INFO] [stderr] 34 | | &None => { [INFO] [stderr] 35 | | try!(fmt.write_str(k.as_ref())); [INFO] [stderr] 36 | | try!(fmt.write_str(";")); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *v { [INFO] [stderr] 34 | None => { [INFO] [stderr] 35 | try!(fmt.write_str(k.as_ref())); [INFO] [stderr] 36 | try!(fmt.write_str(";")); [INFO] [stderr] 37 | }, [INFO] [stderr] 38 | Some(ref val) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | None if line.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match v { [INFO] [stderr] 34 | | &None => { [INFO] [stderr] 35 | | try!(fmt.write_str(k.as_ref())); [INFO] [stderr] 36 | | try!(fmt.write_str(";")); [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *v { [INFO] [stderr] 34 | None => { [INFO] [stderr] 35 | try!(fmt.write_str(k.as_ref())); [INFO] [stderr] 36 | try!(fmt.write_str(";")); [INFO] [stderr] 37 | }, [INFO] [stderr] 38 | Some(ref val) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | None if line.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "f0eb6342a37d02b1546980f23bc94b3ee620614e286f0ca9f9392ddfb1381139"` [INFO] running `"docker" "rm" "-f" "f0eb6342a37d02b1546980f23bc94b3ee620614e286f0ca9f9392ddfb1381139"` [INFO] [stdout] f0eb6342a37d02b1546980f23bc94b3ee620614e286f0ca9f9392ddfb1381139