[INFO] crate immutable-map 0.1.2 is already in cache [INFO] extracting crate immutable-map 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/immutable-map/0.1.2 [INFO] extracting crate immutable-map 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable-map/0.1.2 [INFO] validating manifest of immutable-map-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of immutable-map-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing immutable-map-0.1.2 [INFO] finished frobbing immutable-map-0.1.2 [INFO] frobbed toml for immutable-map-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/immutable-map/0.1.2/Cargo.toml [INFO] started frobbing immutable-map-0.1.2 [INFO] finished frobbing immutable-map-0.1.2 [INFO] frobbed toml for immutable-map-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable-map/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting immutable-map-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/immutable-map/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 16c88f91a99dc23cc3a07d8207c3879cc210364ec092a7ef64446fd558c3aea3 [INFO] running `"docker" "start" "-a" "16c88f91a99dc23cc3a07d8207c3879cc210364ec092a7ef64446fd558c3aea3"` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking immutable-map v0.1.2 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | right: right [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:472:16 [INFO] [stderr] | [INFO] [stderr] 472 | Keys { src: src } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:511:18 [INFO] [stderr] | [INFO] [stderr] 511 | Values { src: src } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `winapi-build`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/tree.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | let TreeNode { elem: r_elem, size: _, left: rl, right: rr } = right; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TreeNode { elem: r_elem, left: rl, right: rr, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tree.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 277 | | if let Some(ref rl_node) = rl { [INFO] [stderr] 278 | | let new_l = TreeNode::new(elem, left.clone(), rl_node.left.clone()); [INFO] [stderr] 279 | | let new_r = TreeNode::new(r_elem, rl_node.right.clone(), rr); [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 276 | } else if let Some(ref rl_node) = rl { [INFO] [stderr] 277 | let new_l = TreeNode::new(elem, left.clone(), rl_node.left.clone()); [INFO] [stderr] 278 | let new_r = TreeNode::new(r_elem, rl_node.right.clone(), rr); [INFO] [stderr] 279 | TreeNode::new( [INFO] [stderr] 280 | rl_node.elem.clone(), [INFO] [stderr] 281 | Some(Rc::new(new_l)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/tree.rs:313:38 [INFO] [stderr] | [INFO] [stderr] 313 | let TreeNode { elem: l_elem, size: _, left: ll, right: lr } = left; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `TreeNode { elem: l_elem, left: ll, right: lr, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tree.rs:321:16 [INFO] [stderr] | [INFO] [stderr] 321 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 322 | | if let Some(ref lr_node) = lr { [INFO] [stderr] 323 | | let new_l = TreeNode::new(l_elem, ll, lr_node.left.clone()); [INFO] [stderr] 324 | | let new_r = TreeNode::new(elem, lr_node.right.clone(), right.clone()); [INFO] [stderr] ... | [INFO] [stderr] 332 | | } [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 321 | } else if let Some(ref lr_node) = lr { [INFO] [stderr] 322 | let new_l = TreeNode::new(l_elem, ll, lr_node.left.clone()); [INFO] [stderr] 323 | let new_r = TreeNode::new(elem, lr_node.right.clone(), right.clone()); [INFO] [stderr] 324 | TreeNode::new( [INFO] [stderr] 325 | lr_node.elem.clone(), [INFO] [stderr] 326 | Some(Rc::new(new_l)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/set.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn iter<'r>(&'r self) -> TreeSetIter<'r, V> { [INFO] [stderr] 102 | | tree::Keys::new(tree::Iter::new(&self.root)) [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/set.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn rev_iter<'r>(&'r self) -> TreeSetRevIter<'r, V> { [INFO] [stderr] 122 | | tree::Keys::new(tree::RevIter::new(&self.root)) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/set.rs:552:9 [INFO] [stderr] | [INFO] [stderr] 552 | / loop { [INFO] [stderr] 553 | | let cmp = match (self.a.peek(), self.b.peek()) { [INFO] [stderr] 554 | | (_, None) => Ordering::Less, [INFO] [stderr] 555 | | (None, _) => Ordering::Greater, [INFO] [stderr] ... | [INFO] [stderr] 570 | | } [INFO] [stderr] 571 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/map.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn iter<'r>(&'r self) -> TreeMapIter<'r, K, V> { [INFO] [stderr] 108 | | tree::Iter::new(&self.root) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/map.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn rev_iter<'r>(&'r self) -> TreeMapRevIter<'r, K, V> { [INFO] [stderr] 128 | | tree::RevIter::new(&self.root) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/map.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn keys<'r>(&'r self) -> TreeMapKeys<'r, K, V> { [INFO] [stderr] 148 | | tree::Keys::new(tree::Iter::new(&self.root)) [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/map.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | / pub fn values<'r>(&'r self) -> TreeMapValues<'r, K, V> { [INFO] [stderr] 168 | | tree::Values::new(tree::Iter::new(&self.root)) [INFO] [stderr] 169 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/map.rs:379:33 [INFO] [stderr] | [INFO] [stderr] 379 | pub fn delete_min(&self) -> Option<(TreeMap, (&K, &V))> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/map.rs:411:33 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn delete_max(&self) -> Option<(TreeMap, (&K, &V))> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn delete_min(node: &TreeNode) -> (Option>>, &(K, V)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree.rs:60:51 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn delete_max(node: &TreeNode) -> (Option>>, &(K, V)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tree.rs:190:12 [INFO] [stderr] | [INFO] [stderr] 190 | -> Option<(Option>>, &'r (K, V))> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `immutable-map`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "16c88f91a99dc23cc3a07d8207c3879cc210364ec092a7ef64446fd558c3aea3"` [INFO] running `"docker" "rm" "-f" "16c88f91a99dc23cc3a07d8207c3879cc210364ec092a7ef64446fd558c3aea3"` [INFO] [stdout] 16c88f91a99dc23cc3a07d8207c3879cc210364ec092a7ef64446fd558c3aea3