[INFO] crate imagemeta 0.1.0 is already in cache [INFO] extracting crate imagemeta 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/imagemeta/0.1.0 [INFO] extracting crate imagemeta 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imagemeta/0.1.0 [INFO] validating manifest of imagemeta-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of imagemeta-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing imagemeta-0.1.0 [INFO] finished frobbing imagemeta-0.1.0 [INFO] frobbed toml for imagemeta-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/imagemeta/0.1.0/Cargo.toml [INFO] started frobbing imagemeta-0.1.0 [INFO] finished frobbing imagemeta-0.1.0 [INFO] frobbed toml for imagemeta-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imagemeta/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting imagemeta-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/imagemeta/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d4b1b55cbd5fb03e5eadb2d40852da113e2bccffb667739d144e4f63cbdcad6 [INFO] running `"docker" "start" "-a" "4d4b1b55cbd5fb03e5eadb2d40852da113e2bccffb667739d144e4f63cbdcad6"` [INFO] [stderr] Checking imagemeta v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | PosWriter{ inner: inner, pos: 0 } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(Exif{ ifds: ifds }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | PosWriter{ inner: inner, pos: 0 } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(Exif{ ifds: ifds }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exif/mod.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/exif/jpeg.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if &hdr == &[b'E', b'x', b'i', b'f', 0x00, 0x00] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 31 | if hdr == [b'E', b'x', b'i', b'f', 0x00, 0x00] { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/exif/jpeg.rs:41:49 [INFO] [stderr] | [INFO] [stderr] 41 | try!(rdr.seek(SeekFrom::Current(len as i64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/exif/mod.rs:130:55 [INFO] [stderr] | [INFO] [stderr] 130 | try!(rdr.seek(SeekFrom::Start(off as u64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/exif/jpeg.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if &hdr == &[b'E', b'x', b'i', b'f', 0x00, 0x00] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 31 | if hdr == [b'E', b'x', b'i', b'f', 0x00, 0x00] { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/exif/jpeg.rs:41:49 [INFO] [stderr] | [INFO] [stderr] 41 | try!(rdr.seek(SeekFrom::Current(len as i64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/exif/mod.rs:347:34 [INFO] [stderr] | [INFO] [stderr] 347 | try!(w.write_all(&mut &pbuf[..pad as usize])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/exif/mod.rs:130:55 [INFO] [stderr] | [INFO] [stderr] 130 | try!(rdr.seek(SeekFrom::Start(off as u64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(off)` [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/exif/mod.rs:428:47 [INFO] [stderr] | [INFO] [stderr] 428 | try!(rdr.seek(SeekFrom::Start(o as u64))); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/exif/mod.rs:438:42 [INFO] [stderr] | [INFO] [stderr] 438 | .ok_or(io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/exif/mod.rs:347:34 [INFO] [stderr] | [INFO] [stderr] 347 | try!(w.write_all(&mut &pbuf[..pad as usize])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/exif/mod.rs:428:47 [INFO] [stderr] | [INFO] [stderr] 428 | try!(rdr.seek(SeekFrom::Start(o as u64))); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/exif/mod.rs:438:42 [INFO] [stderr] | [INFO] [stderr] 438 | .ok_or(io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `"docker" "inspect" "4d4b1b55cbd5fb03e5eadb2d40852da113e2bccffb667739d144e4f63cbdcad6"` [INFO] running `"docker" "rm" "-f" "4d4b1b55cbd5fb03e5eadb2d40852da113e2bccffb667739d144e4f63cbdcad6"` [INFO] [stdout] 4d4b1b55cbd5fb03e5eadb2d40852da113e2bccffb667739d144e4f63cbdcad6