[INFO] crate ihex 1.1.2 is already in cache [INFO] extracting crate ihex 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/ihex/1.1.2 [INFO] extracting crate ihex 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ihex/1.1.2 [INFO] validating manifest of ihex-1.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ihex-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ihex-1.1.2 [INFO] finished frobbing ihex-1.1.2 [INFO] frobbed toml for ihex-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/ihex/1.1.2/Cargo.toml [INFO] started frobbing ihex-1.1.2 [INFO] finished frobbing ihex-1.1.2 [INFO] frobbed toml for ihex-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ihex/1.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ihex-1.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ihex/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef599e829133e6f319edac0a22527df92d58ff2013d7766a0a71d2688849a47a [INFO] running `"docker" "start" "-a" "ef599e829133e6f319edac0a22527df92d58ff2013d7766a0a71d2688849a47a"` [INFO] [stderr] Checking ihex v1.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:204:58 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(Record::StartSegmentAddress { cs: cs, ip: ip }) [INFO] [stderr] | ^^^^^^ help: replace it with: `cs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:204:66 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(Record::StartSegmentAddress { cs: cs, ip: ip }) [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | stop_after_first_error: stop_after_first_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stop_after_first_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | stop_after_eof: stop_after_eof, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stop_after_eof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:204:58 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(Record::StartSegmentAddress { cs: cs, ip: ip }) [INFO] [stderr] | ^^^^^^ help: replace it with: `cs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:204:66 [INFO] [stderr] | [INFO] [stderr] 204 | Ok(Record::StartSegmentAddress { cs: cs, ip: ip }) [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | stop_after_first_error: stop_after_first_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stop_after_first_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | stop_after_eof: stop_after_eof, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stop_after_eof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/checksum.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | checksum [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/checksum.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | let checksum = (0 as u8).wrapping_sub(sum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | ((address & 0xFF000000) >> 24) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | ((address & 0x00FF0000) >> 16) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:96:33 [INFO] [stderr] | [INFO] [stderr] 96 | ((address & 0x0000FF00) >> 8) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:97:33 [INFO] [stderr] | [INFO] [stderr] 97 | ((address & 0x000000FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/checksum.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | checksum [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/checksum.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | let checksum = (0 as u8).wrapping_sub(sum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reader.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:94:33 [INFO] [stderr] | [INFO] [stderr] 94 | ((address & 0xFF000000) >> 24) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | ((address & 0x00FF0000) >> 16) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:96:33 [INFO] [stderr] | [INFO] [stderr] 96 | ((address & 0x0000FF00) >> 8) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:97:33 [INFO] [stderr] | [INFO] [stderr] 97 | ((address & 0x000000FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &ReaderError::MissingStartCode => write!(f, "missing start code ':'"), [INFO] [stderr] 50 | | &ReaderError::RecordTooShort => write!(f, "too short"), [INFO] [stderr] 51 | | &ReaderError::RecordTooLong => write!(f, "too long"), [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | ReaderError::MissingStartCode => write!(f, "missing start code ':'"), [INFO] [stderr] 50 | ReaderError::RecordTooShort => write!(f, "too short"), [INFO] [stderr] 51 | ReaderError::RecordTooLong => write!(f, "too long"), [INFO] [stderr] 52 | ReaderError::RecordNotEvenLength => { [INFO] [stderr] 53 | write!(f, "record does not contain a whole number of bytes") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/reader.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | if data_portion.chars().all(|character| character.is_ascii_hexdigit()) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!data_portion.chars().all(|character| character.is_ascii_hexdigit())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | ((validated_region_bytes[1] as u16) << 8) | ((validated_region_bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(validated_region_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(validated_region_bytes[2] as u16)` [INFO] [stderr] --> src/reader.rs:152:57 [INFO] [stderr] | [INFO] [stderr] 152 | ((validated_region_bytes[1] as u16) << 8) | ((validated_region_bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:152:58 [INFO] [stderr] | [INFO] [stderr] 152 | ((validated_region_bytes[1] as u16) << 8) | ((validated_region_bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(validated_region_bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:182:42 [INFO] [stderr] | [INFO] [stderr] 182 | let address_hi = (payload_bytes[0] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[1] as u16)` [INFO] [stderr] --> src/reader.rs:183:42 [INFO] [stderr] | [INFO] [stderr] 183 | let address_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:183:42 [INFO] [stderr] | [INFO] [stderr] 183 | let address_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:197:37 [INFO] [stderr] | [INFO] [stderr] 197 | let cs_hi = (payload_bytes[0] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[1] as u16)` [INFO] [stderr] --> src/reader.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | let cs_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | let cs_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:199:37 [INFO] [stderr] | [INFO] [stderr] 199 | let ip_hi = (payload_bytes[2] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[3] as u16)` [INFO] [stderr] --> src/reader.rs:200:37 [INFO] [stderr] | [INFO] [stderr] 200 | let ip_lo = (payload_bytes[3] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:200:37 [INFO] [stderr] | [INFO] [stderr] 200 | let ip_lo = (payload_bytes[3] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:215:38 [INFO] [stderr] | [INFO] [stderr] 215 | let ela_hi = (payload_bytes[0] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[1] as u16)` [INFO] [stderr] --> src/reader.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | let ela_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | let ela_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:230:37 [INFO] [stderr] | [INFO] [stderr] 230 | let sla_4 = (payload_bytes[0] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:231:37 [INFO] [stderr] | [INFO] [stderr] 231 | let sla_3 = (payload_bytes[1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | let sla_2 = (payload_bytes[2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[3] as u32)` [INFO] [stderr] --> src/reader.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | let sla_1 = (payload_bytes[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | let sla_1 = (payload_bytes[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:303:16 [INFO] [stderr] | [INFO] [stderr] 303 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reader.rs:335:24 [INFO] [stderr] | [INFO] [stderr] 335 | if let Err(_) = parse_result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 336 | | if self.stop_after_first_error { [INFO] [stderr] 337 | | self.finished = true; [INFO] [stderr] 338 | | } [INFO] [stderr] 339 | | } [INFO] [stderr] | |_________________- help: try this: `if parse_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/record.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &Record::Data { .. } => types::DATA, [INFO] [stderr] 71 | | &Record::EndOfFile => types::END_OF_FILE, [INFO] [stderr] 72 | | &Record::ExtendedSegmentAddress(..) => types::EXTENDED_SEGMENT_ADDRESS, [INFO] [stderr] ... | [INFO] [stderr] 75 | | &Record::StartLinearAddress(..) => types::START_LINEAR_ADDRESS, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | Record::Data { .. } => types::DATA, [INFO] [stderr] 71 | Record::EndOfFile => types::END_OF_FILE, [INFO] [stderr] 72 | Record::ExtendedSegmentAddress(..) => types::EXTENDED_SEGMENT_ADDRESS, [INFO] [stderr] 73 | Record::StartSegmentAddress { .. } => types::START_SEGMENT_ADDRESS, [INFO] [stderr] 74 | Record::ExtendedLinearAddress(..) => types::EXTENDED_LINEAR_ADDRESS, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &WriterError::DataExceedsMaximumLength(bytes) => { [INFO] [stderr] 37 | | write!(f, "record has {} bytes (max 255)", bytes) [INFO] [stderr] 38 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | WriterError::DataExceedsMaximumLength(bytes) => { [INFO] [stderr] 37 | write!(f, "record has {} bytes (max 255)", bytes) [INFO] [stderr] 38 | } [INFO] [stderr] 39 | WriterError::MissingEndOfFileRecord => { [INFO] [stderr] 40 | write!(f, "object is missing end of file record") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &Record::Data { offset, ref value } => { [INFO] [stderr] 56 | | format_record(self.record_type(), offset, value.as_slice()) [INFO] [stderr] 57 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | ), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | Record::Data { offset, ref value } => { [INFO] [stderr] 56 | format_record(self.record_type(), offset, value.as_slice()) [INFO] [stderr] 57 | } [INFO] [stderr] 58 | [INFO] [stderr] 59 | Record::EndOfFile => format_record(self.record_type(), 0x0000, &[]), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x00FF)` [INFO] [stderr] --> src/writer.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | ((address & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(cs & 0x00FF)` [INFO] [stderr] --> src/writer.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | ((cs & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ip & 0x00FF)` [INFO] [stderr] --> src/writer.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | ((ip & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x00FF)` [INFO] [stderr] --> src/writer.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | ((address & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x000000FF)` [INFO] [stderr] --> src/writer.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | ((address & 0x000000FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x00FF)` [INFO] [stderr] --> src/writer.rs:126:22 [INFO] [stderr] | [INFO] [stderr] 126 | data_region.push(((address & 0x00FF) >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / if let &Record::EndOfFile = x { [INFO] [stderr] 179 | | true [INFO] [stderr] 180 | | } else { [INFO] [stderr] 181 | | false [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | if let Record::EndOfFile = *x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &ReaderError::MissingStartCode => write!(f, "missing start code ':'"), [INFO] [stderr] 50 | | &ReaderError::RecordTooShort => write!(f, "too short"), [INFO] [stderr] 51 | | &ReaderError::RecordTooLong => write!(f, "too long"), [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | ReaderError::MissingStartCode => write!(f, "missing start code ':'"), [INFO] [stderr] 50 | ReaderError::RecordTooShort => write!(f, "too short"), [INFO] [stderr] 51 | ReaderError::RecordTooLong => write!(f, "too long"), [INFO] [stderr] 52 | ReaderError::RecordNotEvenLength => { [INFO] [stderr] 53 | write!(f, "record does not contain a whole number of bytes") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/reader.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | if data_portion.chars().all(|character| character.is_ascii_hexdigit()) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!data_portion.chars().all(|character| character.is_ascii_hexdigit())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | ((validated_region_bytes[1] as u16) << 8) | ((validated_region_bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(validated_region_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(validated_region_bytes[2] as u16)` [INFO] [stderr] --> src/reader.rs:152:57 [INFO] [stderr] | [INFO] [stderr] 152 | ((validated_region_bytes[1] as u16) << 8) | ((validated_region_bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:152:58 [INFO] [stderr] | [INFO] [stderr] 152 | ((validated_region_bytes[1] as u16) << 8) | ((validated_region_bytes[2] as u16) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(validated_region_bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:182:42 [INFO] [stderr] | [INFO] [stderr] 182 | let address_hi = (payload_bytes[0] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[1] as u16)` [INFO] [stderr] --> src/reader.rs:183:42 [INFO] [stderr] | [INFO] [stderr] 183 | let address_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:183:42 [INFO] [stderr] | [INFO] [stderr] 183 | let address_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:197:37 [INFO] [stderr] | [INFO] [stderr] 197 | let cs_hi = (payload_bytes[0] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[1] as u16)` [INFO] [stderr] --> src/reader.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | let cs_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | let cs_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:199:37 [INFO] [stderr] | [INFO] [stderr] 199 | let ip_hi = (payload_bytes[2] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[3] as u16)` [INFO] [stderr] --> src/reader.rs:200:37 [INFO] [stderr] | [INFO] [stderr] 200 | let ip_lo = (payload_bytes[3] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:200:37 [INFO] [stderr] | [INFO] [stderr] 200 | let ip_lo = (payload_bytes[3] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:215:38 [INFO] [stderr] | [INFO] [stderr] 215 | let ela_hi = (payload_bytes[0] as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[1] as u16)` [INFO] [stderr] --> src/reader.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | let ela_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | let ela_lo = (payload_bytes[1] as u16) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:230:37 [INFO] [stderr] | [INFO] [stderr] 230 | let sla_4 = (payload_bytes[0] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:231:37 [INFO] [stderr] | [INFO] [stderr] 231 | let sla_3 = (payload_bytes[1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | let sla_2 = (payload_bytes[2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(payload_bytes[3] as u32)` [INFO] [stderr] --> src/reader.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | let sla_1 = (payload_bytes[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | let sla_1 = (payload_bytes[3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(payload_bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/reader.rs:303:16 [INFO] [stderr] | [INFO] [stderr] 303 | if line.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reader.rs:335:24 [INFO] [stderr] | [INFO] [stderr] 335 | if let Err(_) = parse_result { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 336 | | if self.stop_after_first_error { [INFO] [stderr] 337 | | self.finished = true; [INFO] [stderr] 338 | | } [INFO] [stderr] 339 | | } [INFO] [stderr] | |_________________- help: try this: `if parse_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/record.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &Record::Data { .. } => types::DATA, [INFO] [stderr] 71 | | &Record::EndOfFile => types::END_OF_FILE, [INFO] [stderr] 72 | | &Record::ExtendedSegmentAddress(..) => types::EXTENDED_SEGMENT_ADDRESS, [INFO] [stderr] ... | [INFO] [stderr] 75 | | &Record::StartLinearAddress(..) => types::START_LINEAR_ADDRESS, [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | Record::Data { .. } => types::DATA, [INFO] [stderr] 71 | Record::EndOfFile => types::END_OF_FILE, [INFO] [stderr] 72 | Record::ExtendedSegmentAddress(..) => types::EXTENDED_SEGMENT_ADDRESS, [INFO] [stderr] 73 | Record::StartSegmentAddress { .. } => types::START_SEGMENT_ADDRESS, [INFO] [stderr] 74 | Record::ExtendedLinearAddress(..) => types::EXTENDED_LINEAR_ADDRESS, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &WriterError::DataExceedsMaximumLength(bytes) => { [INFO] [stderr] 37 | | write!(f, "record has {} bytes (max 255)", bytes) [INFO] [stderr] 38 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | WriterError::DataExceedsMaximumLength(bytes) => { [INFO] [stderr] 37 | write!(f, "record has {} bytes (max 255)", bytes) [INFO] [stderr] 38 | } [INFO] [stderr] 39 | WriterError::MissingEndOfFileRecord => { [INFO] [stderr] 40 | write!(f, "object is missing end of file record") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &Record::Data { offset, ref value } => { [INFO] [stderr] 56 | | format_record(self.record_type(), offset, value.as_slice()) [INFO] [stderr] 57 | | } [INFO] [stderr] ... | [INFO] [stderr] 99 | | ), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | Record::Data { offset, ref value } => { [INFO] [stderr] 56 | format_record(self.record_type(), offset, value.as_slice()) [INFO] [stderr] 57 | } [INFO] [stderr] 58 | [INFO] [stderr] 59 | Record::EndOfFile => format_record(self.record_type(), 0x0000, &[]), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x00FF)` [INFO] [stderr] --> src/writer.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | ((address & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(cs & 0x00FF)` [INFO] [stderr] --> src/writer.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | ((cs & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ip & 0x00FF)` [INFO] [stderr] --> src/writer.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | ((ip & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x00FF)` [INFO] [stderr] --> src/writer.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | ((address & 0x00FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x000000FF)` [INFO] [stderr] --> src/writer.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | ((address & 0x000000FF) >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(address & 0x00FF)` [INFO] [stderr] --> src/writer.rs:126:22 [INFO] [stderr] | [INFO] [stderr] 126 | data_region.push(((address & 0x00FF) >> 0) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | / if let &Record::EndOfFile = x { [INFO] [stderr] 179 | | true [INFO] [stderr] 180 | | } else { [INFO] [stderr] 181 | | false [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | if let Record::EndOfFile = *x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_reader.rs:298:39 [INFO] [stderr] | [INFO] [stderr] 298 | Ok(Record::StartLinearAddress(0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_reader.rs:302:39 [INFO] [stderr] | [INFO] [stderr] 302 | Ok(Record::StartLinearAddress(0x12345678)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_reader.rs:328:46 [INFO] [stderr] | [INFO] [stderr] 328 | let sla_rec = Record::StartLinearAddress(0x000000CD); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00CD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_writer.rs:119:51 [INFO] [stderr] | [INFO] [stderr] 119 | let sla_record_1 = Record::StartLinearAddress(0x000000CD); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00CD` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_writer.rs:125:51 [INFO] [stderr] | [INFO] [stderr] 125 | let sla_record_2 = Record::StartLinearAddress(0x11223344); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_writer.rs:192:36 [INFO] [stderr] | [INFO] [stderr] 192 | Record::StartLinearAddress(0x000000CD), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00CD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_writer.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let expected_result = String::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 197 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 198 | | + &":020000021200EA\n" [INFO] [stderr] 199 | | + &":0400000300003800C1\n" [INFO] [stderr] 200 | | + &":02000004FFFFFC\n" [INFO] [stderr] 201 | | + &":04000005000000CD2A\n" [INFO] [stderr] 202 | | + &":00000001FF"; [INFO] [stderr] | |___________-------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_writer.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let expected_result = String::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 197 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 198 | | + &":020000021200EA\n" [INFO] [stderr] 199 | | + &":0400000300003800C1\n" [INFO] [stderr] 200 | | + &":02000004FFFFFC\n" [INFO] [stderr] 201 | | + &":04000005000000CD2A\n" [INFO] [stderr] | |___________-----------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":04000005000000CD2A\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_writer.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let expected_result = String::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 197 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 198 | | + &":020000021200EA\n" [INFO] [stderr] 199 | | + &":0400000300003800C1\n" [INFO] [stderr] 200 | | + &":02000004FFFFFC\n" [INFO] [stderr] | |___________-------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":02000004FFFFFC\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_writer.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let expected_result = String::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 197 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 198 | | + &":020000021200EA\n" [INFO] [stderr] 199 | | + &":0400000300003800C1\n" [INFO] [stderr] | |___________-----------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_writer.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let expected_result = String::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 197 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 198 | | + &":020000021200EA\n" [INFO] [stderr] | |___________-------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":020000021200EA\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_writer.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | let expected_result = String::new() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 197 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] | |___________-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | let shortest_invalid_string = longest_valid_string.clone() + &"0"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"0"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 309 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 310 | | + &":020000021200EA\n" [INFO] [stderr] 311 | | + &":0400000300003800C1\n" [INFO] [stderr] 312 | | + &":02000004FFFFFC\n" [INFO] [stderr] 313 | | + &":04000005000000CD2A\n" [INFO] [stderr] 314 | | + &":00000001FF"; [INFO] [stderr] | |___________-------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 309 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 310 | | + &":020000021200EA\n" [INFO] [stderr] 311 | | + &":0400000300003800C1\n" [INFO] [stderr] 312 | | + &":02000004FFFFFC\n" [INFO] [stderr] 313 | | + &":04000005000000CD2A\n" [INFO] [stderr] | |___________-----------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":04000005000000CD2A\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 309 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 310 | | + &":020000021200EA\n" [INFO] [stderr] 311 | | + &":0400000300003800C1\n" [INFO] [stderr] 312 | | + &":02000004FFFFFC\n" [INFO] [stderr] | |___________-------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":02000004FFFFFC\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 309 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 310 | | + &":020000021200EA\n" [INFO] [stderr] 311 | | + &":0400000300003800C1\n" [INFO] [stderr] | |___________-----------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 309 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 310 | | + &":020000021200EA\n" [INFO] [stderr] | |___________-------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":020000021200EA\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:308:17 [INFO] [stderr] | [INFO] [stderr] 308 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 309 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] | |___________-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | String::new() + &":0B0010006164647265737320676170A7\n" + &":\n" + &":0400000300003800C1\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | String::new() + &":0B0010006164647265737320676170A7\n" + &":\n" + &":0400000300003800C1\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | String::new() + &":0B0010006164647265737320676170A7\n" + &":\n" + &":0400000300003800C1\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | String::new() + &":0B0010006164647265737320676170A7\n" + &":\n" + &":0400000300003800C1\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | String::new() + &":0B0010006164647265737320676170A7\n" + &":\n" + &":0400000300003800C1\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | String::new() + &":0B0010006164647265737320676170A7\n" + &":\n" + &":0400000300003800C1\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 385 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 386 | | + &":00000001FF\n" [INFO] [stderr] 387 | | + &":0400000300003800C1\n"; [INFO] [stderr] | |___________-----------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 385 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 386 | | + &":00000001FF\n" [INFO] [stderr] | |___________---------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:384:17 [INFO] [stderr] | [INFO] [stderr] 384 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 385 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] | |___________-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 410 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 411 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 412 | | + &":00000001FF\n" [INFO] [stderr] 413 | | + &":0400000300003800C1\n"; [INFO] [stderr] | |___________-----------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 410 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 411 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 412 | | + &":00000001FF\n" [INFO] [stderr] | |___________---------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 410 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 411 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] | |___________-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:431:17 [INFO] [stderr] | [INFO] [stderr] 431 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 432 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 433 | | + &":00000001FF\n" [INFO] [stderr] 434 | | + &":0400000300003800C1"; [INFO] [stderr] | |___________---------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:431:17 [INFO] [stderr] | [INFO] [stderr] 431 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 432 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 433 | | + &":00000001FF\n" [INFO] [stderr] | |___________---------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:431:17 [INFO] [stderr] | [INFO] [stderr] 431 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 432 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] | |___________-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:452:17 [INFO] [stderr] | [INFO] [stderr] 452 | let input = String::new() + [INFO] [stderr] | _________________^ [INFO] [stderr] 453 | | &":0B0010006164647265737320676170A7\n" + // Unix LF [INFO] [stderr] 454 | | &":0B0010006164647265737320676170A7\r\n" + // Windows CRLF [INFO] [stderr] 455 | | &":00000001FF\r"; // MacOS CR [INFO] [stderr] | |_____---------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF\r"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:452:17 [INFO] [stderr] | [INFO] [stderr] 452 | let input = String::new() + [INFO] [stderr] | _________________^ [INFO] [stderr] 453 | | &":0B0010006164647265737320676170A7\n" + // Unix LF [INFO] [stderr] 454 | | &":0B0010006164647265737320676170A7\r\n" + // Windows CRLF [INFO] [stderr] | |_____---------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\r\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:452:17 [INFO] [stderr] | [INFO] [stderr] 452 | let input = String::new() + [INFO] [stderr] | _________________^ [INFO] [stderr] 453 | | &":0B0010006164647265737320676170A7\n" + // Unix LF [INFO] [stderr] | |_____-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 497 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 498 | | + &":00000001FF\n\n\n" [INFO] [stderr] 499 | | + &":0400000300003800C1\n\n"; [INFO] [stderr] | |___________-------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0400000300003800C1\n\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 497 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] 498 | | + &":00000001FF\n\n\n" [INFO] [stderr] | |___________-------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":00000001FF\n\n\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> tests/test_reader.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | let input = String::new() [INFO] [stderr] | _________________^ [INFO] [stderr] 497 | | + &":0B0010006164647265737320676170A7\n" [INFO] [stderr] | |___________-------------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":0B0010006164647265737320676170A7\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.48s [INFO] running `"docker" "inspect" "ef599e829133e6f319edac0a22527df92d58ff2013d7766a0a71d2688849a47a"` [INFO] running `"docker" "rm" "-f" "ef599e829133e6f319edac0a22527df92d58ff2013d7766a0a71d2688849a47a"` [INFO] [stdout] ef599e829133e6f319edac0a22527df92d58ff2013d7766a0a71d2688849a47a