[INFO] crate idna 0.1.5 is already in cache [INFO] extracting crate idna 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/idna/0.1.5 [INFO] extracting crate idna 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/idna/0.1.5 [INFO] validating manifest of idna-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of idna-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing idna-0.1.5 [INFO] removed 2 missing tests [INFO] finished frobbing idna-0.1.5 [INFO] frobbed toml for idna-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/idna/0.1.5/Cargo.toml [INFO] started frobbing idna-0.1.5 [INFO] removed 2 missing tests [INFO] finished frobbing idna-0.1.5 [INFO] frobbed toml for idna-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/idna/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting idna-0.1.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/idna/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49cec2444f157c91ebdd4027b8e7699150dfde9981f1edfa5151186931fff924 [INFO] running `"docker" "start" "-a" "49cec2444f157c91ebdd4027b8e7699150dfde9981f1edfa5151186931fff924"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/unit.rs [INFO] [stderr] * /opt/crater/workdir/tests/tests.rs [INFO] [stderr] * /opt/crater/workdir/tests/uts46.rs [INFO] [stderr] * /opt/crater/workdir/tests/punycode.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking idna v0.1.5 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `semver-parser`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uts46.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/uts46.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | PunycodeError, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/punycode.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | let digit = match byte { [INFO] [stderr] | _________________________^ [INFO] [stderr] 85 | | byte @ b'0' ... b'9' => byte - b'0' + 26, [INFO] [stderr] 86 | | byte @ b'A' ... b'Z' => byte - b'A', [INFO] [stderr] 87 | | byte @ b'a' ... b'z' => byte - b'a', [INFO] [stderr] 88 | | _ => return None [INFO] [stderr] 89 | | } as u32; [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 84 | let digit = u32::from(match byte { [INFO] [stderr] 85 | byte @ b'0' ... b'9' => byte - b'0' + 26, [INFO] [stderr] 86 | byte @ b'A' ... b'Z' => byte - b'A', [INFO] [stderr] 87 | byte @ b'a' ... b'z' => byte - b'a', [INFO] [stderr] 88 | _ => return None [INFO] [stderr] 89 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/punycode.rs:209:36 [INFO] [stderr] | [INFO] [stderr] 209 | 0 ... 25 => (value as u8 + 'a' as u8) as char, // a..z [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/punycode.rs:210:42 [INFO] [stderr] | [INFO] [stderr] 210 | 26 ... 35 => (value as u8 - 26 + '0' as u8) as char, // 0..9 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/uts46.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / loop { [INFO] [stderr] 136 | | match chars.next() { [INFO] [stderr] 137 | | Some(c) => { [INFO] [stderr] 138 | | if !matches!(bidi_class(c), [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(c) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/uts46.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | / loop { [INFO] [stderr] 180 | | match chars.next() { [INFO] [stderr] 181 | | Some(c) => { [INFO] [stderr] 182 | | let char_class = bidi_class(c); [INFO] [stderr] ... | [INFO] [stderr] 200 | | } [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(c) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/uts46.rs:269:52 [INFO] [stderr] | [INFO] [stderr] 269 | else if is_combining_mark(first_char.unwrap()) { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 270 | | errors.push(Error::ValidityCriteria); [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/uts46.rs:260:60 [INFO] [stderr] | [INFO] [stderr] 260 | else if label.starts_with("-") || label.ends_with("-") { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 261 | | errors.push(Error::ValidityCriteria); [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/uts46.rs:260:31 [INFO] [stderr] | [INFO] [stderr] 260 | else if label.starts_with("-") || label.ends_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/uts46.rs:260:55 [INFO] [stderr] | [INFO] [stderr] 260 | else if label.starts_with("-") || label.ends_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/uts46.rs:405:42 [INFO] [stderr] | [INFO] [stderr] 405 | let domain = if result.ends_with(".") { &result[..result.len()-1] } else { &*result }; [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/uts46.rs:406:12 [INFO] [stderr] | [INFO] [stderr] 406 | if domain.len() < 1 || domain.split('.').any(|label| label.len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `domain.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/uts46.rs:406:62 [INFO] [stderr] | [INFO] [stderr] 406 | if domain.len() < 1 || domain.split('.').any(|label| label.len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `label.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `idna`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "49cec2444f157c91ebdd4027b8e7699150dfde9981f1edfa5151186931fff924"` [INFO] running `"docker" "rm" "-f" "49cec2444f157c91ebdd4027b8e7699150dfde9981f1edfa5151186931fff924"` [INFO] [stdout] 49cec2444f157c91ebdd4027b8e7699150dfde9981f1edfa5151186931fff924