[INFO] crate humantime 1.2.0 is already in cache [INFO] extracting crate humantime 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/humantime/1.2.0 [INFO] extracting crate humantime 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/humantime/1.2.0 [INFO] validating manifest of humantime-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of humantime-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing humantime-1.2.0 [INFO] finished frobbing humantime-1.2.0 [INFO] frobbed toml for humantime-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/humantime/1.2.0/Cargo.toml [INFO] started frobbing humantime-1.2.0 [INFO] finished frobbing humantime-1.2.0 [INFO] frobbed toml for humantime-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/humantime/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting humantime-1.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/humantime/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba7f66407fab009a8e18bc62e67623888f153813d74d13cd3a50080e16f333f9 [INFO] running `"docker" "start" "-a" "ba7f66407fab009a8e18bc62e67623888f153813d74d13cd3a50080e16f333f9"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking humantime v1.2.0 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `num-traits`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `num-integer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/duration.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/duration.rs:110:59 [INFO] [stderr] | [INFO] [stderr] 110 | "millis" | "msec" | "ms" => (0u64, try!(n.mul(1000_000))), [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/duration.rs:117:53 [INFO] [stderr] | [INFO] [stderr] 117 | "months" | "month" | "M" => (try!(n.mul(2630016)), 0), // 30.44d [INFO] [stderr] | ^^^^^^^ help: consider: `2_630_016` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/duration.rs:118:51 [INFO] [stderr] | [INFO] [stderr] 118 | "years" | "year" | "y" => (try!(n.mul(31557600)), 0), // 365.25d [INFO] [stderr] | ^^^^^^^^ help: consider: `31_557_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/duration.rs:122:19 [INFO] [stderr] | [INFO] [stderr] 122 | if nsec > 1000_000_000 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/duration.rs:123:39 [INFO] [stderr] | [INFO] [stderr] 123 | sec = try!(sec.add(nsec / 1000_000_000)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/duration.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | nsec %= 1000_000_000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/duration.rs:273:28 [INFO] [stderr] | [INFO] [stderr] 273 | let years = secs / 31557600; // 365.25d [INFO] [stderr] | ^^^^^^^^ help: consider: `31_557_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/duration.rs:274:28 [INFO] [stderr] | [INFO] [stderr] 274 | let ydays = secs % 31557600; [INFO] [stderr] | ^^^^^^^^ help: consider: `31_557_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/duration.rs:275:30 [INFO] [stderr] | [INFO] [stderr] 275 | let months = ydays / 2630016; // 30.44d [INFO] [stderr] | ^^^^^^^ help: consider: `2_630_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/duration.rs:276:29 [INFO] [stderr] | [INFO] [stderr] 276 | let mdays = ydays % 2630016; [INFO] [stderr] | ^^^^^^^ help: consider: `2_630_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | pub const SECONDS: u64 = 253402300800-1; // last second of year 9999 [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `253_402_300_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/date.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | pub const TIMESTAMP: &'static str = "9999-12-31T23:59:59Z"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return parse_rfc3339_weak(s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_rfc3339_weak(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | return Ok(UNIX_EPOCH + Duration::new(total_seconds, nanos)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(UNIX_EPOCH + Duration::new(total_seconds, nanos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/date.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 174 | | if b.len() != 19 && (b.len() > 20 || b[19] != b'Z') { [INFO] [stderr] 175 | | return Err(Error::InvalidFormat); [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if b.len() != 19 && (b.len() > 20 || b[19] != b'Z') { [INFO] [stderr] 174 | return Err(Error::InvalidFormat); [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return Rfc3339Timestamp(system_time, Precision::Smart); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rfc3339Timestamp(system_time, Precision::Smart)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | return Rfc3339Timestamp(system_time, Precision::Seconds); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rfc3339Timestamp(system_time, Precision::Seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return Rfc3339Timestamp(system_time, Precision::Nanos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rfc3339Timestamp(system_time, Precision::Nanos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | if secs_since_epoch >= 253402300800 { // year 9999 [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `253_402_300_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/duration.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | let ref mut started = false; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------- help: try: `let started = &mut false;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/date.rs:69:8 [INFO] [stderr] | [INFO] [stderr] 69 | Ok(((b1 - b'0')*10 + (b2 - b'0')) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((b1 - b'0')*10 + (b2 - b'0'))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date.rs:170:29 [INFO] [stderr] | [INFO] [stderr] 170 | nanos += mult * (b[idx] - b'0') as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[idx] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/date.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | y % 4 == 0 && (!(y % 100 == 0) || y % 400 == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `y % 4 == 0 && (y % 100 != 0 || y % 400 == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `nanos` [INFO] [stderr] --> src/date.rs:315:31 [INFO] [stderr] | [INFO] [stderr] 315 | buf[28] = b'0' + (nanos / 1 % 10) as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ba7f66407fab009a8e18bc62e67623888f153813d74d13cd3a50080e16f333f9"` [INFO] running `"docker" "rm" "-f" "ba7f66407fab009a8e18bc62e67623888f153813d74d13cd3a50080e16f333f9"` [INFO] [stdout] ba7f66407fab009a8e18bc62e67623888f153813d74d13cd3a50080e16f333f9