[INFO] crate huffman-coding 0.1.2 is already in cache [INFO] extracting crate huffman-coding 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/huffman-coding/0.1.2 [INFO] extracting crate huffman-coding 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/huffman-coding/0.1.2 [INFO] validating manifest of huffman-coding-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of huffman-coding-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing huffman-coding-0.1.2 [INFO] finished frobbing huffman-coding-0.1.2 [INFO] frobbed toml for huffman-coding-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/huffman-coding/0.1.2/Cargo.toml [INFO] started frobbing huffman-coding-0.1.2 [INFO] finished frobbing huffman-coding-0.1.2 [INFO] frobbed toml for huffman-coding-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/huffman-coding/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting huffman-coding-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/huffman-coding/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b90e1684f34dc61181ef74ff7a955a7e655abdccd8d46d431ee7da9e8759f87 [INFO] running `"docker" "start" "-a" "4b90e1684f34dc61181ef74ff7a955a7e655abdccd8d46d431ee7da9e8759f87"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/util.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking bitstream-rs v0.1.2 [INFO] [stderr] Checking huffman-coding v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 327 | | if &self.tree != state { [INFO] [stderr] 328 | | return Err(IOError::from(IOErrorKind::InvalidData)) [INFO] [stderr] 329 | | } else { [INFO] [stderr] 330 | | break; [INFO] [stderr] 331 | | } [INFO] [stderr] 332 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 327 | | if &self.tree != state { [INFO] [stderr] 328 | | return Err(IOError::from(IOErrorKind::InvalidData)) [INFO] [stderr] 329 | | } else { [INFO] [stderr] 330 | | break; [INFO] [stderr] 331 | | } [INFO] [stderr] 332 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 326 | } else if &self.tree != state { [INFO] [stderr] 327 | return Err(IOError::from(IOErrorKind::InvalidData)) [INFO] [stderr] 328 | } else { [INFO] [stderr] 329 | break; [INFO] [stderr] 330 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:334:12 [INFO] [stderr] | [INFO] [stderr] 334 | Ok((pos)) [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:334:12 [INFO] [stderr] | [INFO] [stderr] 334 | Ok((pos)) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 326 | } else if &self.tree != state { [INFO] [stderr] 327 | return Err(IOError::from(IOErrorKind::InvalidData)) [INFO] [stderr] 328 | } else { [INFO] [stderr] 329 | break; [INFO] [stderr] 330 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:334:12 [INFO] [stderr] | [INFO] [stderr] 334 | Ok((pos)) [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:334:12 [INFO] [stderr] | [INFO] [stderr] 334 | Ok((pos)) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `table` [INFO] [stderr] --> src/lib.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (i, ) in table.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self { [INFO] [stderr] 174 | | &HuffmanTree::Leaf(item, prob) if item == byte => Some(prob), [INFO] [stderr] 175 | | &HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] 176 | | zero.get_byte_prob(byte).or(one.get_byte_prob(byte)) [INFO] [stderr] 177 | | }, [INFO] [stderr] 178 | | _ => None [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | match *self { [INFO] [stderr] 174 | HuffmanTree::Leaf(item, prob) if item == byte => Some(prob), [INFO] [stderr] 175 | HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:176:42 [INFO] [stderr] | [INFO] [stderr] 176 | zero.get_byte_prob(byte).or(one.get_byte_prob(byte)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| one.get_byte_prob(byte))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match self { [INFO] [stderr] 195 | | &HuffmanTree::Leaf(_, prob) => prob as u16, [INFO] [stderr] 196 | | &HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] 197 | | zero.get_probability() + one.get_probability() [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *self { [INFO] [stderr] 195 | HuffmanTree::Leaf(_, prob) => prob as u16, [INFO] [stderr] 196 | HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:195:44 [INFO] [stderr] | [INFO] [stderr] 195 | &HuffmanTree::Leaf(_, prob) => prob as u16, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(prob)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / match self { [INFO] [stderr] 210 | | &HuffmanTree::Leaf(ref elem, _) => { [INFO] [stderr] 211 | | data.insert(*elem, prev); [INFO] [stderr] 212 | | }, [INFO] [stderr] ... | [INFO] [stderr] 220 | | } [INFO] [stderr] 221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 209 | match *self { [INFO] [stderr] 210 | HuffmanTree::Leaf(ref elem, _) => { [INFO] [stderr] 211 | data.insert(*elem, prev); [INFO] [stderr] 212 | }, [INFO] [stderr] 213 | HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:260:45 [INFO] [stderr] | [INFO] [stderr] 260 | let bits = self.table.get(item).ok_or(IOError::from(IOErrorKind::InvalidData))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IOError::from(IOErrorKind::InvalidData))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / match state { [INFO] [stderr] 312 | | &HuffmanTree::Leaf(x, _) => { [INFO] [stderr] 313 | | buf[pos] = x; [INFO] [stderr] 314 | | pos += 1; [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 311 | match *state { [INFO] [stderr] 312 | HuffmanTree::Leaf(x, _) => { [INFO] [stderr] 313 | buf[pos] = x; [INFO] [stderr] 314 | pos += 1; [INFO] [stderr] 315 | state = &self.tree; [INFO] [stderr] 316 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | / if let &HuffmanTree::Leaf(x, _) = state { [INFO] [stderr] 320 | | buf[pos] = x; [INFO] [stderr] 321 | | pos += 1; [INFO] [stderr] 322 | | state = &self.tree; [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 319 | if let HuffmanTree::Leaf(x, _) = *state { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `table` [INFO] [stderr] --> src/lib.rs:161:18 [INFO] [stderr] | [INFO] [stderr] 161 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (i, ) in table.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self { [INFO] [stderr] 174 | | &HuffmanTree::Leaf(item, prob) if item == byte => Some(prob), [INFO] [stderr] 175 | | &HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] 176 | | zero.get_byte_prob(byte).or(one.get_byte_prob(byte)) [INFO] [stderr] 177 | | }, [INFO] [stderr] 178 | | _ => None [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | match *self { [INFO] [stderr] 174 | HuffmanTree::Leaf(item, prob) if item == byte => Some(prob), [INFO] [stderr] 175 | HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:176:42 [INFO] [stderr] | [INFO] [stderr] 176 | zero.get_byte_prob(byte).or(one.get_byte_prob(byte)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| one.get_byte_prob(byte))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match self { [INFO] [stderr] 195 | | &HuffmanTree::Leaf(_, prob) => prob as u16, [INFO] [stderr] 196 | | &HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] 197 | | zero.get_probability() + one.get_probability() [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *self { [INFO] [stderr] 195 | HuffmanTree::Leaf(_, prob) => prob as u16, [INFO] [stderr] 196 | HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:195:44 [INFO] [stderr] | [INFO] [stderr] 195 | &HuffmanTree::Leaf(_, prob) => prob as u16, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(prob)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / match self { [INFO] [stderr] 210 | | &HuffmanTree::Leaf(ref elem, _) => { [INFO] [stderr] 211 | | data.insert(*elem, prev); [INFO] [stderr] 212 | | }, [INFO] [stderr] ... | [INFO] [stderr] 220 | | } [INFO] [stderr] 221 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 209 | match *self { [INFO] [stderr] 210 | HuffmanTree::Leaf(ref elem, _) => { [INFO] [stderr] 211 | data.insert(*elem, prev); [INFO] [stderr] 212 | }, [INFO] [stderr] 213 | HuffmanTree::Node(ref zero, ref one) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:260:45 [INFO] [stderr] | [INFO] [stderr] 260 | let bits = self.table.get(item).ok_or(IOError::from(IOErrorKind::InvalidData))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| IOError::from(IOErrorKind::InvalidData))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / match state { [INFO] [stderr] 312 | | &HuffmanTree::Leaf(x, _) => { [INFO] [stderr] 313 | | buf[pos] = x; [INFO] [stderr] 314 | | pos += 1; [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 311 | match *state { [INFO] [stderr] 312 | HuffmanTree::Leaf(x, _) => { [INFO] [stderr] 313 | buf[pos] = x; [INFO] [stderr] 314 | pos += 1; [INFO] [stderr] 315 | state = &self.tree; [INFO] [stderr] 316 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | / if let &HuffmanTree::Leaf(x, _) = state { [INFO] [stderr] 320 | | buf[pos] = x; [INFO] [stderr] 321 | | pos += 1; [INFO] [stderr] 322 | | state = &self.tree; [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 319 | if let HuffmanTree::Leaf(x, _) = *state { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `"docker" "inspect" "4b90e1684f34dc61181ef74ff7a955a7e655abdccd8d46d431ee7da9e8759f87"` [INFO] running `"docker" "rm" "-f" "4b90e1684f34dc61181ef74ff7a955a7e655abdccd8d46d431ee7da9e8759f87"` [INFO] [stdout] 4b90e1684f34dc61181ef74ff7a955a7e655abdccd8d46d431ee7da9e8759f87