[INFO] crate httpdate 0.3.2 is already in cache [INFO] extracting crate httpdate 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/httpdate/0.3.2 [INFO] extracting crate httpdate 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpdate/0.3.2 [INFO] validating manifest of httpdate-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of httpdate-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing httpdate-0.3.2 [INFO] finished frobbing httpdate-0.3.2 [INFO] frobbed toml for httpdate-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/httpdate/0.3.2/Cargo.toml [INFO] started frobbing httpdate-0.3.2 [INFO] finished frobbing httpdate-0.3.2 [INFO] frobbed toml for httpdate-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpdate/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting httpdate-0.3.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpdate/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 905cb400016f05931d140643c018728ae0ffec80c8a64925064fd555fe9e04d9 [INFO] running `"docker" "start" "-a" "905cb400016f05931d140643c018728ae0ffec80c8a64925064fd555fe9e04d9"` [INFO] [stderr] Checking httpdate v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/httpdate.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/httpdate.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | wday: wday, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `wday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/httpdate.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/httpdate.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | wday: wday, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `wday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/httpdate.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | if secs_since_epoch >= 253402300800 { // year 9999 [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `253_402_300_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/httpdate.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/httpdate.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | if secs_since_epoch >= 253402300800 { // year 9999 [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `253_402_300_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | let d = UNIX_EPOCH + Duration::from_secs(784111777); [INFO] [stderr] | ^^^^^^^^^ help: consider: `784_111_777` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:96:50 [INFO] [stderr] | [INFO] [stderr] 96 | let d = UNIX_EPOCH + Duration::from_secs(1475419451); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_475_419_451` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:112:34 [INFO] [stderr] | [INFO] [stderr] 112 | d += Duration::from_secs(2592000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:34 [INFO] [stderr] | [INFO] [stderr] 114 | d += Duration::from_secs(2592000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_592_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:116:34 [INFO] [stderr] | [INFO] [stderr] 116 | d += Duration::from_secs(31536005); [INFO] [stderr] | ^^^^^^^^ help: consider: `31_536_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:118:34 [INFO] [stderr] | [INFO] [stderr] 118 | d += Duration::from_secs(15552000); [INFO] [stderr] | ^^^^^^^^ help: consider: `15_552_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:120:34 [INFO] [stderr] | [INFO] [stderr] 120 | d += Duration::from_secs(6048000); [INFO] [stderr] | ^^^^^^^ help: consider: `6_048_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:122:34 [INFO] [stderr] | [INFO] [stderr] 122 | d += Duration::from_secs(864000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `864_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:130:50 [INFO] [stderr] | [INFO] [stderr] 130 | let d = UNIX_EPOCH + Duration::from_secs(1475419451); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_475_419_451` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/httpdate.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/httpdate.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | fn is_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | } + v.day as u64 - 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(v.day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | let days = (v.year as u64 - 1970) * 365 + leap_years as u64 + ydays; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v.year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:140:51 [INFO] [stderr] | [INFO] [stderr] 140 | let days = (v.year as u64 - 1970) * 365 + leap_years as u64 + ydays; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(leap_years)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | Duration::from_secs(v.sec as u64 + v.min as u64 * 60 + v.hour as u64 * 3600 + days * 86400) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(v.sec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | Duration::from_secs(v.sec as u64 + v.min as u64 * 60 + v.hour as u64 * 3600 + days * 86400) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(v.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:142:64 [INFO] [stderr] | [INFO] [stderr] 142 | Duration::from_secs(v.sec as u64 + v.min as u64 * 60 + v.hour as u64 * 3600 + days * 86400) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v.hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/httpdate.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | y % 4 == 0 && (!(y % 100 == 0) || y % 400 == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `y % 4 == 0 && (y % 100 != 0 || y % 400 == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/httpdate.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | fn is_valid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | } + v.day as u64 - 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(v.day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | let days = (v.year as u64 - 1970) * 365 + leap_years as u64 + ydays; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v.year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:140:51 [INFO] [stderr] | [INFO] [stderr] 140 | let days = (v.year as u64 - 1970) * 365 + leap_years as u64 + ydays; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(leap_years)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:142:29 [INFO] [stderr] | [INFO] [stderr] 142 | Duration::from_secs(v.sec as u64 + v.min as u64 * 60 + v.hour as u64 * 3600 + days * 86400) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(v.sec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | Duration::from_secs(v.sec as u64 + v.min as u64 * 60 + v.hour as u64 * 3600 + days * 86400) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(v.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/httpdate.rs:142:64 [INFO] [stderr] | [INFO] [stderr] 142 | Duration::from_secs(v.sec as u64 + v.min as u64 * 60 + v.hour as u64 * 3600 + days * 86400) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v.hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/httpdate.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | y % 4 == 0 && (!(y % 100 == 0) || y % 400 == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `y % 4 == 0 && (y % 100 != 0 || y % 400 == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "905cb400016f05931d140643c018728ae0ffec80c8a64925064fd555fe9e04d9"` [INFO] running `"docker" "rm" "-f" "905cb400016f05931d140643c018728ae0ffec80c8a64925064fd555fe9e04d9"` [INFO] [stdout] 905cb400016f05931d140643c018728ae0ffec80c8a64925064fd555fe9e04d9