[INFO] crate http-pull-parser 0.1.4 is already in cache
[INFO] extracting crate http-pull-parser 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/http-pull-parser/0.1.4
[INFO] extracting crate http-pull-parser 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http-pull-parser/0.1.4
[INFO] validating manifest of http-pull-parser-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of http-pull-parser-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing http-pull-parser-0.1.4
[INFO] finished frobbing http-pull-parser-0.1.4
[INFO] frobbed toml for http-pull-parser-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/http-pull-parser/0.1.4/Cargo.toml
[INFO] started frobbing http-pull-parser-0.1.4
[INFO] finished frobbing http-pull-parser-0.1.4
[INFO] frobbed toml for http-pull-parser-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http-pull-parser/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting http-pull-parser-0.1.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http-pull-parser/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] abd91944c2500c70418f6c5668610d8062ce97cddbae78692f5afccc3b58c65b
[INFO] running `"docker" "start" "-a" "abd91944c2500c70418f6c5668610d8062ce97cddbae78692f5afccc3b58c65b"`
[INFO] [stderr]     Checking http_parser v0.0.2
[INFO] [stderr]     Checking http-pull-parser v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser_handler.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             parser_type: parser_type,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parser_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser_handler.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             parser_type: parser_type,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parser_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser_handler.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         return Ok(ParseAction::None);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser_handler.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return Ok(ParseAction::None);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser_handler.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         return Ok(ParseAction::None);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:171:9
[INFO] [stderr]     |
[INFO] [stderr] 171 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/parser.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 58 | |             if let Some(ref e) = self.parser.errno {
[INFO] [stderr] 59 | |                 return (Err(ParserError { error: format!("{}", e) }), nparsed);
[INFO] [stderr] 60 | |             } else {
[INFO] [stderr] 61 | |                 return (Ok(None), nparsed);
[INFO] [stderr] 62 | |             }
[INFO] [stderr] 63 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 57 |         } else if let Some(ref e) = self.parser.errno {
[INFO] [stderr] 58 |     return (Err(ParserError { error: format!("{}", e) }), nparsed);
[INFO] [stderr] 59 | } else {
[INFO] [stderr] 60 |     return (Ok(None), nparsed);
[INFO] [stderr] 61 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser_handler.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         return Ok(ParseAction::None);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser_handler.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return Ok(ParseAction::None);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser_handler.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         return Ok(ParseAction::None);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:171:9
[INFO] [stderr]     |
[INFO] [stderr] 171 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser_handler.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         return Ok(ParseAction::None);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParseAction::None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/parser.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 58 | |             if let Some(ref e) = self.parser.errno {
[INFO] [stderr] 59 | |                 return (Err(ParserError { error: format!("{}", e) }), nparsed);
[INFO] [stderr] 60 | |             } else {
[INFO] [stderr] 61 | |                 return (Ok(None), nparsed);
[INFO] [stderr] 62 | |             }
[INFO] [stderr] 63 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 57 |         } else if let Some(ref e) = self.parser.errno {
[INFO] [stderr] 58 |     return (Err(ParserError { error: format!("{}", e) }), nparsed);
[INFO] [stderr] 59 | } else {
[INFO] [stderr] 60 |     return (Ok(None), nparsed);
[INFO] [stderr] 61 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/parser_handler.rs:18:23
[INFO] [stderr]    |
[INFO] [stderr] 18 |     String::from_utf8(bytes.iter().cloned().collect::<Vec<_>>()).unwrap()
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/parser_handler.rs:170:47
[INFO] [stderr]     |
[INFO] [stderr] 170 |         self.tokens.push_back(HttpToken::Body(body.iter().cloned().collect()));
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:49:20
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 if data.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/parser_handler.rs:18:23
[INFO] [stderr]    |
[INFO] [stderr] 18 |     String::from_utf8(bytes.iter().cloned().collect::<Vec<_>>()).unwrap()
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_cloned_collect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]    --> src/parser_handler.rs:170:47
[INFO] [stderr]     |
[INFO] [stderr] 170 |         self.tokens.push_back(HttpToken::Body(body.iter().cloned().collect()));
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:49:20
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 if data.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stderr]   --> src/parser.rs:76:40
[INFO] [stderr]    |
[INFO] [stderr] 76 |           let mut http_request: Vec<_> = b"GET /te".iter()
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 77 | |             .cloned().collect();
[INFO] [stderr]    | |_______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.20s
[INFO] running `"docker" "inspect" "abd91944c2500c70418f6c5668610d8062ce97cddbae78692f5afccc3b58c65b"`
[INFO] running `"docker" "rm" "-f" "abd91944c2500c70418f6c5668610d8062ce97cddbae78692f5afccc3b58c65b"`
[INFO] [stdout] abd91944c2500c70418f6c5668610d8062ce97cddbae78692f5afccc3b58c65b