[INFO] crate html-minifier 1.1.3 is already in cache [INFO] extracting crate html-minifier 1.1.3 into work/ex/clippy-test-run/sources/stable/reg/html-minifier/1.1.3 [INFO] extracting crate html-minifier 1.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html-minifier/1.1.3 [INFO] validating manifest of html-minifier-1.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of html-minifier-1.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing html-minifier-1.1.3 [INFO] finished frobbing html-minifier-1.1.3 [INFO] frobbed toml for html-minifier-1.1.3 written to work/ex/clippy-test-run/sources/stable/reg/html-minifier/1.1.3/Cargo.toml [INFO] started frobbing html-minifier-1.1.3 [INFO] finished frobbing html-minifier-1.1.3 [INFO] frobbed toml for html-minifier-1.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html-minifier/1.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting html-minifier-1.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html-minifier/1.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28215a726a7c1bb343fb4b7d0734511e7596ae5e11f9649f1d5387f4a40c36fd [INFO] running `"docker" "start" "-a" "28215a726a7c1bb343fb4b7d0734511e7596ae5e11f9649f1d5387f4a40c36fd"` [INFO] [stderr] Checking macro-utils v0.1.2 [INFO] [stderr] Checking minifier v0.0.20 [INFO] [stderr] Checking html-minifier v1.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:223:24 [INFO] [stderr] | [INFO] [stderr] 223 | } else if c == '>' { [INFO] [stderr] | ________________________^ [INFO] [stderr] 224 | | if self.counter >= 2 { [INFO] [stderr] 225 | | self.is_comment = false; [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 223 | } else if c == '>' && self.counter >= 2 { [INFO] [stderr] 224 | self.is_comment = false; [INFO] [stderr] 225 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:262:24 [INFO] [stderr] | [INFO] [stderr] 262 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 263 | | if self.counter == 1 || self.counter == 2 || self.counter == 5 { [INFO] [stderr] 264 | | if !is_ascii_control!(c) { [INFO] [stderr] 265 | | self.counter = 0; [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 262 | } else if self.counter == 1 || self.counter == 2 || self.counter == 5 { [INFO] [stderr] 263 | if !is_ascii_control!(c) { [INFO] [stderr] 264 | self.counter = 0; [INFO] [stderr] 265 | } [INFO] [stderr] 266 | } else { [INFO] [stderr] 267 | self.counter = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 324 | | if self.counter == 1 || self.counter == 2 || self.counter == 8 { [INFO] [stderr] 325 | | if !is_ascii_control!(c) { [INFO] [stderr] 326 | | self.counter = 0; [INFO] [stderr] ... | [INFO] [stderr] 330 | | } [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 323 | } else if self.counter == 1 || self.counter == 2 || self.counter == 8 { [INFO] [stderr] 324 | if !is_ascii_control!(c) { [INFO] [stderr] 325 | self.counter = 0; [INFO] [stderr] 326 | } [INFO] [stderr] 327 | } else { [INFO] [stderr] 328 | self.counter = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:384:24 [INFO] [stderr] | [INFO] [stderr] 384 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 385 | | if self.counter == 1 || self.counter == 2 || self.counter == 7 { [INFO] [stderr] 386 | | if !is_ascii_control!(c) { [INFO] [stderr] 387 | | self.counter = 0; [INFO] [stderr] ... | [INFO] [stderr] 391 | | } [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 384 | } else if self.counter == 1 || self.counter == 2 || self.counter == 7 { [INFO] [stderr] 385 | if !is_ascii_control!(c) { [INFO] [stderr] 386 | self.counter = 0; [INFO] [stderr] 387 | } [INFO] [stderr] 388 | } else { [INFO] [stderr] 389 | self.counter = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:409:28 [INFO] [stderr] | [INFO] [stderr] 409 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 410 | | if self.last_space { [INFO] [stderr] 411 | | continue; [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 409 | } else if self.last_space { [INFO] [stderr] 410 | continue; [INFO] [stderr] 411 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | / if self.attribute.eq(&"class".to_string()) { [INFO] [stderr] 405 | | if self.last_space { [INFO] [stderr] 406 | | continue; [INFO] [stderr] 407 | | } [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 404 | if self.attribute.eq(&"class".to_string()) && self.last_space { [INFO] [stderr] 405 | continue; [INFO] [stderr] 406 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:492:33 [INFO] [stderr] | [INFO] [stderr] 492 | / if self.last_space { [INFO] [stderr] 493 | | if !is_space_or_new_line!(*self.out.last().unwrap()) { [INFO] [stderr] 494 | | self.last_space = false; [INFO] [stderr] 495 | | } [INFO] [stderr] 496 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 492 | if self.last_space && !is_space_or_new_line!(*self.out.last().unwrap()) { [INFO] [stderr] 493 | self.last_space = false; [INFO] [stderr] 494 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:516:28 [INFO] [stderr] | [INFO] [stderr] 516 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 517 | | if c == '>' { [INFO] [stderr] 518 | | if self.last_space { [INFO] [stderr] 519 | | let end = self.out.len() - 1; [INFO] [stderr] ... | [INFO] [stderr] 543 | | } [INFO] [stderr] 544 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 516 | } else if c == '>' { [INFO] [stderr] 517 | if self.last_space { [INFO] [stderr] 518 | let end = self.out.len() - 1; [INFO] [stderr] 519 | self.out.remove(end); [INFO] [stderr] 520 | } [INFO] [stderr] 521 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:546:21 [INFO] [stderr] | [INFO] [stderr] 546 | / if self.is_just_finish_tagging { [INFO] [stderr] 547 | | if self.last_space && self.line_space { [INFO] [stderr] 548 | | let end = self.out.len() - 1; [INFO] [stderr] 549 | | self.out.remove(end); [INFO] [stderr] 550 | | } [INFO] [stderr] 551 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 546 | if self.is_just_finish_tagging && self.last_space && self.line_space { [INFO] [stderr] 547 | let end = self.out.len() - 1; [INFO] [stderr] 548 | self.out.remove(end); [INFO] [stderr] 549 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:223:24 [INFO] [stderr] | [INFO] [stderr] 223 | } else if c == '>' { [INFO] [stderr] | ________________________^ [INFO] [stderr] 224 | | if self.counter >= 2 { [INFO] [stderr] 225 | | self.is_comment = false; [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 223 | } else if c == '>' && self.counter >= 2 { [INFO] [stderr] 224 | self.is_comment = false; [INFO] [stderr] 225 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:262:24 [INFO] [stderr] | [INFO] [stderr] 262 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 263 | | if self.counter == 1 || self.counter == 2 || self.counter == 5 { [INFO] [stderr] 264 | | if !is_ascii_control!(c) { [INFO] [stderr] 265 | | self.counter = 0; [INFO] [stderr] ... | [INFO] [stderr] 269 | | } [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 262 | } else if self.counter == 1 || self.counter == 2 || self.counter == 5 { [INFO] [stderr] 263 | if !is_ascii_control!(c) { [INFO] [stderr] 264 | self.counter = 0; [INFO] [stderr] 265 | } [INFO] [stderr] 266 | } else { [INFO] [stderr] 267 | self.counter = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 324 | | if self.counter == 1 || self.counter == 2 || self.counter == 8 { [INFO] [stderr] 325 | | if !is_ascii_control!(c) { [INFO] [stderr] 326 | | self.counter = 0; [INFO] [stderr] ... | [INFO] [stderr] 330 | | } [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 323 | } else if self.counter == 1 || self.counter == 2 || self.counter == 8 { [INFO] [stderr] 324 | if !is_ascii_control!(c) { [INFO] [stderr] 325 | self.counter = 0; [INFO] [stderr] 326 | } [INFO] [stderr] 327 | } else { [INFO] [stderr] 328 | self.counter = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:384:24 [INFO] [stderr] | [INFO] [stderr] 384 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 385 | | if self.counter == 1 || self.counter == 2 || self.counter == 7 { [INFO] [stderr] 386 | | if !is_ascii_control!(c) { [INFO] [stderr] 387 | | self.counter = 0; [INFO] [stderr] ... | [INFO] [stderr] 391 | | } [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 384 | } else if self.counter == 1 || self.counter == 2 || self.counter == 7 { [INFO] [stderr] 385 | if !is_ascii_control!(c) { [INFO] [stderr] 386 | self.counter = 0; [INFO] [stderr] 387 | } [INFO] [stderr] 388 | } else { [INFO] [stderr] 389 | self.counter = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:409:28 [INFO] [stderr] | [INFO] [stderr] 409 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 410 | | if self.last_space { [INFO] [stderr] 411 | | continue; [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 409 | } else if self.last_space { [INFO] [stderr] 410 | continue; [INFO] [stderr] 411 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:404:25 [INFO] [stderr] | [INFO] [stderr] 404 | / if self.attribute.eq(&"class".to_string()) { [INFO] [stderr] 405 | | if self.last_space { [INFO] [stderr] 406 | | continue; [INFO] [stderr] 407 | | } [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 404 | if self.attribute.eq(&"class".to_string()) && self.last_space { [INFO] [stderr] 405 | continue; [INFO] [stderr] 406 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:492:33 [INFO] [stderr] | [INFO] [stderr] 492 | / if self.last_space { [INFO] [stderr] 493 | | if !is_space_or_new_line!(*self.out.last().unwrap()) { [INFO] [stderr] 494 | | self.last_space = false; [INFO] [stderr] 495 | | } [INFO] [stderr] 496 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 492 | if self.last_space && !is_space_or_new_line!(*self.out.last().unwrap()) { [INFO] [stderr] 493 | self.last_space = false; [INFO] [stderr] 494 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:516:28 [INFO] [stderr] | [INFO] [stderr] 516 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 517 | | if c == '>' { [INFO] [stderr] 518 | | if self.last_space { [INFO] [stderr] 519 | | let end = self.out.len() - 1; [INFO] [stderr] ... | [INFO] [stderr] 543 | | } [INFO] [stderr] 544 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 516 | } else if c == '>' { [INFO] [stderr] 517 | if self.last_space { [INFO] [stderr] 518 | let end = self.out.len() - 1; [INFO] [stderr] 519 | self.out.remove(end); [INFO] [stderr] 520 | } [INFO] [stderr] 521 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:546:21 [INFO] [stderr] | [INFO] [stderr] 546 | / if self.is_just_finish_tagging { [INFO] [stderr] 547 | | if self.last_space && self.line_space { [INFO] [stderr] 548 | | let end = self.out.len() - 1; [INFO] [stderr] 549 | | self.out.remove(end); [INFO] [stderr] 550 | | } [INFO] [stderr] 551 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 546 | if self.is_just_finish_tagging && self.last_space && self.line_space { [INFO] [stderr] 547 | let end = self.out.len() - 1; [INFO] [stderr] 548 | self.out.remove(end); [INFO] [stderr] 549 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HTMLMinifier` [INFO] [stderr] --> src/lib.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / pub fn new() -> HTMLMinifier { [INFO] [stderr] 190 | | HTMLMinifier { [INFO] [stderr] 191 | | out: Vec::new(), [INFO] [stderr] 192 | | buffer: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 101 [INFO] [stderr] --> src/lib.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn digest>(&mut self, text: S) -> Result<(), &'static str> { [INFO] [stderr] 217 | | for c in text.as_ref().chars() { [INFO] [stderr] 218 | | if is_ascii_control!(c) { [INFO] [stderr] 219 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 561 | | Ok(()) [INFO] [stderr] 562 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | self.counter = self.counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:250:34 [INFO] [stderr] | [INFO] [stderr] 250 | let c = *out.get(e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `out[e]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:258:25 [INFO] [stderr] | [INFO] [stderr] 258 | e = e - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `e -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:301:34 [INFO] [stderr] | [INFO] [stderr] 301 | let c = *buffer.get(e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `buffer[e]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:312:25 [INFO] [stderr] | [INFO] [stderr] 312 | e = e - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `e -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:362:34 [INFO] [stderr] | [INFO] [stderr] 362 | let c = *buffer.get(e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `buffer[e]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:373:25 [INFO] [stderr] | [INFO] [stderr] 373 | e = e - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `e -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:400:47 [INFO] [stderr] | [INFO] [stderr] 400 | } else if self.in_end_tagging { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 401 | | self.in_start_tagging = false; [INFO] [stderr] 402 | | } else if self.is_tagging { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:398:49 [INFO] [stderr] | [INFO] [stderr] 398 | } else if self.in_start_tagging { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 399 | | self.in_start_tagging = false; [INFO] [stderr] 400 | | } else if self.in_end_tagging { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | len = len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `len -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `html-minifier`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `HTMLMinifier` [INFO] [stderr] --> src/lib.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / pub fn new() -> HTMLMinifier { [INFO] [stderr] 190 | | HTMLMinifier { [INFO] [stderr] 191 | | out: Vec::new(), [INFO] [stderr] 192 | | buffer: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 101 [INFO] [stderr] --> src/lib.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn digest>(&mut self, text: S) -> Result<(), &'static str> { [INFO] [stderr] 217 | | for c in text.as_ref().chars() { [INFO] [stderr] 218 | | if is_ascii_control!(c) { [INFO] [stderr] 219 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 561 | | Ok(()) [INFO] [stderr] 562 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | self.counter = self.counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:250:34 [INFO] [stderr] | [INFO] [stderr] 250 | let c = *out.get(e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `out[e]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:258:25 [INFO] [stderr] | [INFO] [stderr] 258 | e = e - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `e -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:301:34 [INFO] [stderr] | [INFO] [stderr] 301 | let c = *buffer.get(e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `buffer[e]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:312:25 [INFO] [stderr] | [INFO] [stderr] 312 | e = e - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `e -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:362:34 [INFO] [stderr] | [INFO] [stderr] 362 | let c = *buffer.get(e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `buffer[e]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:373:25 [INFO] [stderr] | [INFO] [stderr] 373 | e = e - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `e -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:400:47 [INFO] [stderr] | [INFO] [stderr] 400 | } else if self.in_end_tagging { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 401 | | self.in_start_tagging = false; [INFO] [stderr] 402 | | } else if self.is_tagging { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:398:49 [INFO] [stderr] | [INFO] [stderr] 398 | } else if self.in_start_tagging { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 399 | | self.in_start_tagging = false; [INFO] [stderr] 400 | | } else if self.in_end_tagging { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | len = len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `len -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `html-minifier`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "28215a726a7c1bb343fb4b7d0734511e7596ae5e11f9649f1d5387f4a40c36fd"` [INFO] running `"docker" "rm" "-f" "28215a726a7c1bb343fb4b7d0734511e7596ae5e11f9649f1d5387f4a40c36fd"` [INFO] [stdout] 28215a726a7c1bb343fb4b7d0734511e7596ae5e11f9649f1d5387f4a40c36fd