[INFO] crate hmac-sha1 0.1.3 is already in cache [INFO] extracting crate hmac-sha1 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/hmac-sha1/0.1.3 [INFO] extracting crate hmac-sha1 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hmac-sha1/0.1.3 [INFO] validating manifest of hmac-sha1-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hmac-sha1-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hmac-sha1-0.1.3 [INFO] finished frobbing hmac-sha1-0.1.3 [INFO] frobbed toml for hmac-sha1-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/hmac-sha1/0.1.3/Cargo.toml [INFO] started frobbing hmac-sha1-0.1.3 [INFO] finished frobbing hmac-sha1-0.1.3 [INFO] frobbed toml for hmac-sha1-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hmac-sha1/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hmac-sha1-0.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hmac-sha1/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2fc4602f0b3f31838d81be2e4b079328ec36ce614eff9027d157c29b30a92da [INFO] running `"docker" "start" "-a" "f2fc4602f0b3f31838d81be2e4b079328ec36ce614eff9027d157c29b30a92da"` [INFO] [stderr] Checking hmac-sha1 v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut auth_key: &mut [u8; SHA1_KEY_BYTES] = &mut [key_pad_byte; SHA1_KEY_BYTES]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: omit braces around single expression condition [INFO] [stderr] --> src/lib.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if { key.len() > SHA1_KEY_BYTES } { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_expr)] on by default [INFO] [stderr] = help: try [INFO] [stderr] if key.len() > SHA1_KEY_BYTES { [INFO] [stderr] // derive new authentication from provided key [INFO] [stderr] sha1_ctx.update(key); [INFO] [stderr] [INFO] [stderr] // assign derived authentication key [INFO] [stderr] auth_key[..SHA1_DIGEST_BYTES].copy_from_slice(&(sha1_ctx.digest().bytes())); [INFO] [stderr] [INFO] [stderr] // reset hash for reuse [INFO] [stderr] sha1_ctx.reset(); [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut auth_key: &mut [u8; SHA1_KEY_BYTES] = &mut [key_pad_byte; SHA1_KEY_BYTES]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: omit braces around single expression condition [INFO] [stderr] --> src/lib.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if { key.len() > SHA1_KEY_BYTES } { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_expr)] on by default [INFO] [stderr] = help: try [INFO] [stderr] if key.len() > SHA1_KEY_BYTES { [INFO] [stderr] // derive new authentication from provided key [INFO] [stderr] sha1_ctx.update(key); [INFO] [stderr] [INFO] [stderr] // assign derived authentication key [INFO] [stderr] auth_key[..SHA1_DIGEST_BYTES].copy_from_slice(&(sha1_ctx.digest().bytes())); [INFO] [stderr] [INFO] [stderr] // reset hash for reuse [INFO] [stderr] sha1_ctx.reset(); [INFO] [stderr] } ... [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_expr [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | let data = "Hi There".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hi There"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | let data = "what do ya want for nothing?".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"what do ya want for nothing?"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let key = "Jefe".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Jefe"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "f2fc4602f0b3f31838d81be2e4b079328ec36ce614eff9027d157c29b30a92da"` [INFO] running `"docker" "rm" "-f" "f2fc4602f0b3f31838d81be2e4b079328ec36ce614eff9027d157c29b30a92da"` [INFO] [stdout] f2fc4602f0b3f31838d81be2e4b079328ec36ce614eff9027d157c29b30a92da