[INFO] crate hexf-parse 0.1.0 is already in cache [INFO] extracting crate hexf-parse 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/hexf-parse/0.1.0 [INFO] extracting crate hexf-parse 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexf-parse/0.1.0 [INFO] validating manifest of hexf-parse-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hexf-parse-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hexf-parse-0.1.0 [INFO] finished frobbing hexf-parse-0.1.0 [INFO] frobbed toml for hexf-parse-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/hexf-parse/0.1.0/Cargo.toml [INFO] started frobbing hexf-parse-0.1.0 [INFO] finished frobbing hexf-parse-0.1.0 [INFO] frobbed toml for hexf-parse-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexf-parse/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hexf-parse-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexf-parse/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 104329fe93250bc1e54b4b7b8b1f049818093f568f16afcadefa46395277dfff [INFO] running `"docker" "start" "-a" "104329fe93250bc1e54b4b7b8b1f049818093f568f16afcadefa46395277dfff"` [INFO] [stderr] Checking hexf-parse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:224:73 [INFO] [stderr] | [INFO] [stderr] 224 | assert_eq!(parse(b"0x4.00001000000000000000p55", false), Ok((false, 0x400001, 55 - 20))); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:305:68 [INFO] [stderr] | [INFO] [stderr] 305 | assert_eq!(convert_hexf32(false, 0x0000_0000_00ff_ffff, 0), Ok(16777215.0)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `16_777_215.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:307:70 [INFO] [stderr] | [INFO] [stderr] 307 | assert_eq!(convert_hexf32(false, 0xffff_ff00_0000_0000, -40), Ok(16777215.0)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `16_777_215.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:352:68 [INFO] [stderr] | [INFO] [stderr] 352 | assert_eq!(convert_hexf64(false, 0x001f_ffff_ffff_ffff, 0), Ok(9007199254740991.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:354:70 [INFO] [stderr] | [INFO] [stderr] 354 | assert_eq!(convert_hexf64(false, 0xffff_ffff_ffff_f800, -11), Ok(9007199254740991.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | acc = acc << 4 | digit as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(digit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:45 [INFO] [stderr] | [INFO] [stderr] 138 | acc = acc << (nnewdigits * 4) | digit as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(digit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | acc = acc << 4 | digit as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(digit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:45 [INFO] [stderr] | [INFO] [stderr] 138 | acc = acc << (nnewdigits * 4) | digit as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(digit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lib.rs:203:1 [INFO] [stderr] | [INFO] [stderr] 203 | / fn test_parse() { [INFO] [stderr] 204 | | assert_eq!(parse(b"", false), Err(EMPTY)); [INFO] [stderr] 205 | | assert_eq!(parse(b" ", false), Err(INVALID)); [INFO] [stderr] 206 | | assert_eq!(parse(b"3.14", false), Err(INVALID)); [INFO] [stderr] ... | [INFO] [stderr] 236 | | assert_eq!(parse(b"-0x3____.1_4___p+______", true), Err(INVALID)); [INFO] [stderr] 237 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/lib.rs:291:1 [INFO] [stderr] | [INFO] [stderr] 291 | / fn test_convert_hexf32() { [INFO] [stderr] 292 | | assert_eq!(convert_hexf32(false, 0, 0), Ok(0.0)); [INFO] [stderr] 293 | | assert_eq!(convert_hexf32(false, 1, 0), Ok(1.0)); [INFO] [stderr] 294 | | assert_eq!(convert_hexf32(false, 10, 0), Ok(10.0)); [INFO] [stderr] ... | [INFO] [stderr] 334 | | assert_eq!(convert_hexf32(false, 0xffff_ff80_0000_0000, 64), Err(INEXACT)); [INFO] [stderr] 335 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | assert_eq!(convert_hexf32(false, 0, 0).unwrap().signum(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | assert_eq!(convert_hexf32(false, 0, 0).unwrap().signum(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | assert_eq!(convert_hexf32(true, 0, 0).unwrap().signum(), -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | assert_eq!(convert_hexf32(true, 0, 0).unwrap().signum(), -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/lib.rs:338:1 [INFO] [stderr] | [INFO] [stderr] 338 | / fn test_convert_hexf64() { [INFO] [stderr] 339 | | assert_eq!(convert_hexf64(false, 0, 0), Ok(0.0)); [INFO] [stderr] 340 | | assert_eq!(convert_hexf64(false, 1, 0), Ok(1.0)); [INFO] [stderr] 341 | | assert_eq!(convert_hexf64(false, 10, 0), Ok(10.0)); [INFO] [stderr] ... | [INFO] [stderr] 381 | | assert_eq!(convert_hexf64(false, 0xffff_ffff_ffff_fc00, 960), Err(INEXACT)); [INFO] [stderr] 382 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | assert_eq!(convert_hexf64(false, 0, 0).unwrap().signum(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | assert_eq!(convert_hexf64(false, 0, 0).unwrap().signum(), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | assert_eq!(convert_hexf64(true, 0, 0).unwrap().signum(), -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:349:5 [INFO] [stderr] | [INFO] [stderr] 349 | assert_eq!(convert_hexf64(true, 0, 0).unwrap().signum(), -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hexf-parse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "104329fe93250bc1e54b4b7b8b1f049818093f568f16afcadefa46395277dfff"` [INFO] running `"docker" "rm" "-f" "104329fe93250bc1e54b4b7b8b1f049818093f568f16afcadefa46395277dfff"` [INFO] [stdout] 104329fe93250bc1e54b4b7b8b1f049818093f568f16afcadefa46395277dfff