[INFO] crate heme 0.3.1 is already in cache [INFO] extracting crate heme 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/heme/0.3.1 [INFO] extracting crate heme 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/heme/0.3.1 [INFO] validating manifest of heme-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of heme-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing heme-0.3.1 [INFO] finished frobbing heme-0.3.1 [INFO] frobbed toml for heme-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/heme/0.3.1/Cargo.toml [INFO] started frobbing heme-0.3.1 [INFO] finished frobbing heme-0.3.1 [INFO] frobbed toml for heme-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/heme/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting heme-0.3.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/heme/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b055dd88573bbee219fb4a75f1aa7207a83bc3646ff378f0962268b238bddcb9 [INFO] running `"docker" "start" "-a" "b055dd88573bbee219fb4a75f1aa7207a83bc3646ff378f0962268b238bddcb9"` [INFO] [stderr] Checking heme v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/sampling.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sampling.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | protocol [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sampling.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | let protocol = Protocol { [INFO] [stderr] | ____________________^ [INFO] [stderr] 24 | | components: vec![ [INFO] [stderr] 25 | | // go ahread, try it, it's fun! [INFO] [stderr] 26 | | Box::new(ScoreOnlyMove {}), [INFO] [stderr] ... | [INFO] [stderr] 29 | | ] [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/sampling.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sampling.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | protocol [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sampling.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | let protocol = Protocol { [INFO] [stderr] | ____________________^ [INFO] [stderr] 24 | | components: vec![ [INFO] [stderr] 25 | | // go ahread, try it, it's fun! [INFO] [stderr] 26 | | Box::new(ScoreOnlyMove {}), [INFO] [stderr] ... | [INFO] [stderr] 29 | | ] [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `protocol_name` [INFO] [stderr] --> src/sampling.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn get_protocol(protocol_name: &str) -> Protocol { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_protocol_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a1` [INFO] [stderr] --> src/scoring.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn calculate_lennard_jones_energy(a1: &Atom, a2: &Atom, r: f64) -> f64 { [INFO] [stderr] | ^^ help: consider using `_a1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a2` [INFO] [stderr] --> src/scoring.rs:24:50 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn calculate_lennard_jones_energy(a1: &Atom, a2: &Atom, r: f64) -> f64 { [INFO] [stderr] | ^^ help: consider using `_a2` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `atoms` [INFO] [stderr] --> src/conformation.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | atoms: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `residue_name` [INFO] [stderr] --> src/conformation.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | residue_name: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `residue_index` [INFO] [stderr] --> src/conformation.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | residue_index: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/conformation.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn clone(&self) -> XYZ { [INFO] [stderr] 31 | | let x = self.x.clone(); [INFO] [stderr] 32 | | let y = self.y.clone(); [INFO] [stderr] 33 | | let z = self.z.clone(); [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | XYZ { x, y, z } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let x = self.x.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let y = self.y.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let z = self.z.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | let charge = record.charge.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `record.charge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/scoring.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 51 | | // these atoms are greater than 12 Å apart, ignore that they interact [INFO] [stderr] 52 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/scoring.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | if r == 0.0 { [INFO] [stderr] | _________________________^ [INFO] [stderr] 49 | | // these are the same atom // do nothing [INFO] [stderr] 50 | | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/scoring.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(r.max(6.0) - 6.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/scoring.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `heme`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `protocol_name` [INFO] [stderr] --> src/sampling.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn get_protocol(protocol_name: &str) -> Protocol { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_protocol_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a1` [INFO] [stderr] --> src/scoring.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn calculate_lennard_jones_energy(a1: &Atom, a2: &Atom, r: f64) -> f64 { [INFO] [stderr] | ^^ help: consider using `_a1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a2` [INFO] [stderr] --> src/scoring.rs:24:50 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn calculate_lennard_jones_energy(a1: &Atom, a2: &Atom, r: f64) -> f64 { [INFO] [stderr] | ^^ help: consider using `_a2` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `atoms` [INFO] [stderr] --> src/conformation.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | atoms: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `residue_name` [INFO] [stderr] --> src/conformation.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | residue_name: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `residue_index` [INFO] [stderr] --> src/conformation.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | residue_index: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/conformation.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn clone(&self) -> XYZ { [INFO] [stderr] 31 | | let x = self.x.clone(); [INFO] [stderr] 32 | | let y = self.y.clone(); [INFO] [stderr] 33 | | let z = self.z.clone(); [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | XYZ { x, y, z } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let x = self.x.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let y = self.y.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let z = self.z.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/conformation.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | let charge = record.charge.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `record.charge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/scoring.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 51 | | // these atoms are greater than 12 Å apart, ignore that they interact [INFO] [stderr] 52 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/scoring.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | if r == 0.0 { [INFO] [stderr] | _________________________^ [INFO] [stderr] 49 | | // these are the same atom // do nothing [INFO] [stderr] 50 | | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/scoring.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(r.max(6.0) - 6.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/scoring.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | } else if r.max(6.0) == 6.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(atom.xyz.x, 28.042); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(atom.xyz.x, 28.042); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: function `H` should have a snake case name such as `h` [INFO] [stderr] --> src/io.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / fn H(l: &f64) -> f64 { [INFO] [stderr] 153 | | [INFO] [stderr] 154 | | // bounds of N choose lN [INFO] [stderr] 155 | | // can be found by 2^(n*H(l)) [INFO] [stderr] ... | [INFO] [stderr] 161 | | l.ln() - value * value.ln() [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | fn H(l: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `heme`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b055dd88573bbee219fb4a75f1aa7207a83bc3646ff378f0962268b238bddcb9"` [INFO] running `"docker" "rm" "-f" "b055dd88573bbee219fb4a75f1aa7207a83bc3646ff378f0962268b238bddcb9"` [INFO] [stdout] b055dd88573bbee219fb4a75f1aa7207a83bc3646ff378f0962268b238bddcb9