[INFO] crate hd44780 0.2.2 is already in cache
[INFO] extracting crate hd44780 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/hd44780/0.2.2
[INFO] extracting crate hd44780 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780/0.2.2
[INFO] validating manifest of hd44780-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hd44780-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hd44780-0.2.2
[INFO] finished frobbing hd44780-0.2.2
[INFO] frobbed toml for hd44780-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/hd44780/0.2.2/Cargo.toml
[INFO] started frobbing hd44780-0.2.2
[INFO] finished frobbing hd44780-0.2.2
[INFO] frobbed toml for hd44780-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hd44780-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c2fc578b5d8a9b400daacedac2963abdfc7e0db7f2b14d5656061935c6a4482c
[INFO] running `"docker" "start" "-a" "c2fc578b5d8a9b400daacedac2963abdfc7e0db7f2b14d5656061935c6a4482c"`
[INFO] [stderr]     Checking hd44780 v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/core.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |         return HD44780 {host: h};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HD44780 {host: h}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 | /         return RaspberryPiBPlus{rs: None, enable: None,
[INFO] [stderr] 34 | |             data4: None, data5: None, data6: None, data7: None};
[INFO] [stderr]    | |________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 33 |         RaspberryPiBPlus{rs: None, enable: None,
[INFO] [stderr] 34 |             data4: None, data5: None, data6: None, data7: None}
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/hosts.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/hosts.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             ()
[INFO] [stderr]     |             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/hosts.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:136:34
[INFO] [stderr]     |
[INFO] [stderr] 136 |     fn rs(&mut self, mode: Mode) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:142:35
[INFO] [stderr]     |
[INFO] [stderr] 142 |     fn enable(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:145:34
[INFO] [stderr]     |
[INFO] [stderr] 145 |     fn data4(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:148:34
[INFO] [stderr]     |
[INFO] [stderr] 148 |     fn data5(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:151:34
[INFO] [stderr]     |
[INFO] [stderr] 151 |     fn data6(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:154:34
[INFO] [stderr]     |
[INFO] [stderr] 154 |     fn data7(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/core.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |         return HD44780 {host: h};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HD44780 {host: h}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 | /         return RaspberryPiBPlus{rs: None, enable: None,
[INFO] [stderr] 34 | |             data4: None, data5: None, data6: None, data7: None};
[INFO] [stderr]    | |________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 33 |         RaspberryPiBPlus{rs: None, enable: None,
[INFO] [stderr] 34 |             data4: None, data5: None, data6: None, data7: None}
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hosts.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/hosts.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/hosts.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             ()
[INFO] [stderr]     |             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/hosts.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:136:34
[INFO] [stderr]     |
[INFO] [stderr] 136 |     fn rs(&mut self, mode: Mode) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:142:35
[INFO] [stderr]     |
[INFO] [stderr] 142 |     fn enable(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:145:34
[INFO] [stderr]     |
[INFO] [stderr] 145 |     fn data4(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:148:34
[INFO] [stderr]     |
[INFO] [stderr] 148 |     fn data5(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:151:34
[INFO] [stderr]     |
[INFO] [stderr] 151 |     fn data6(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/hosts.rs:154:34
[INFO] [stderr]     |
[INFO] [stderr] 154 |     fn data7(&mut self, b: bool) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]    --> src/core.rs:109:18
[INFO] [stderr]     |
[INFO] [stderr] 109 |         for i in 0..len {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 109 |         for <item> in bytes.iter().take(len) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hosts::RaspberryPiBPlus`
[INFO] [stderr]   --> src/hosts.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn new() -> RaspberryPiBPlus {
[INFO] [stderr] 33 | |         return RaspberryPiBPlus{rs: None, enable: None,
[INFO] [stderr] 34 | |             data4: None, data5: None, data6: None, data7: None};
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`.
[INFO] [stderr]    --> src/core.rs:109:18
[INFO] [stderr]     |
[INFO] [stderr] 109 |         for i in 0..len {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 109 |         for <item> in bytes.iter().take(len) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hosts::RaspberryPiBPlus`
[INFO] [stderr]   --> src/hosts.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn new() -> RaspberryPiBPlus {
[INFO] [stderr] 33 | |         return RaspberryPiBPlus{rs: None, enable: None,
[INFO] [stderr] 34 | |             data4: None, data5: None, data6: None, data7: None};
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.73s
[INFO] running `"docker" "inspect" "c2fc578b5d8a9b400daacedac2963abdfc7e0db7f2b14d5656061935c6a4482c"`
[INFO] running `"docker" "rm" "-f" "c2fc578b5d8a9b400daacedac2963abdfc7e0db7f2b14d5656061935c6a4482c"`
[INFO] [stdout] c2fc578b5d8a9b400daacedac2963abdfc7e0db7f2b14d5656061935c6a4482c