[INFO] crate handletree-rs 0.2.0 is already in cache [INFO] extracting crate handletree-rs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/handletree-rs/0.2.0 [INFO] extracting crate handletree-rs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/handletree-rs/0.2.0 [INFO] validating manifest of handletree-rs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of handletree-rs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing handletree-rs-0.2.0 [INFO] finished frobbing handletree-rs-0.2.0 [INFO] frobbed toml for handletree-rs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/handletree-rs/0.2.0/Cargo.toml [INFO] started frobbing handletree-rs-0.2.0 [INFO] finished frobbing handletree-rs-0.2.0 [INFO] frobbed toml for handletree-rs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/handletree-rs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting handletree-rs-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/handletree-rs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49ef2c9807b495ec2b5dc9f92d079049998df8db678f1b53e351fd542cf1ce5d [INFO] running `"docker" "start" "-a" "49ef2c9807b495ec2b5dc9f92d079049998df8db678f1b53e351fd542cf1ce5d"` [INFO] [stderr] Checking handletree-rs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 80 | | match &self.release_policy { [INFO] [stderr] 81 | | ReleasePolicy::DontTrack => self.simple_allocate(), [INFO] [stderr] 82 | | ReleasePolicy::Tracked => { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | if self.freed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.freed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | / match self.freed.iter().find(|x| **x == id) { [INFO] [stderr] 114 | | Some(_) => false, [INFO] [stderr] 115 | | None => true, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________________^ help: try this: `self.freed.iter().find(|x| **x == id).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 80 | | match &self.release_policy { [INFO] [stderr] 81 | | ReleasePolicy::DontTrack => self.simple_allocate(), [INFO] [stderr] 82 | | ReleasePolicy::Tracked => { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | if self.freed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.freed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | / match self.freed.iter().find(|x| **x == id) { [INFO] [stderr] 114 | | Some(_) => false, [INFO] [stderr] 115 | | None => true, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________________^ help: try this: `self.freed.iter().find(|x| **x == id).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "49ef2c9807b495ec2b5dc9f92d079049998df8db678f1b53e351fd542cf1ce5d"` [INFO] running `"docker" "rm" "-f" "49ef2c9807b495ec2b5dc9f92d079049998df8db678f1b53e351fd542cf1ce5d"` [INFO] [stdout] 49ef2c9807b495ec2b5dc9f92d079049998df8db678f1b53e351fd542cf1ce5d