[INFO] crate gtrie 0.4.0 is already in cache [INFO] extracting crate gtrie 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/gtrie/0.4.0 [INFO] extracting crate gtrie 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtrie/0.4.0 [INFO] validating manifest of gtrie-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gtrie-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gtrie-0.4.0 [INFO] finished frobbing gtrie-0.4.0 [INFO] frobbed toml for gtrie-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/gtrie/0.4.0/Cargo.toml [INFO] started frobbing gtrie-0.4.0 [INFO] finished frobbing gtrie-0.4.0 [INFO] frobbed toml for gtrie-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtrie/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gtrie-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gtrie/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa409f43522aceda2f208fd9e8af5df026544070088b93bdc99ec29ca7363181 [INFO] running `"docker" "start" "-a" "aa409f43522aceda2f208fd9e8af5df026544070088b93bdc99ec29ca7363181"` [INFO] [stderr] Checking gtrie v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/trie_node.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | return Some(self.children[idx].1.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.children[idx].1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/trie_node.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.value.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Trie` [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> Trie { [INFO] [stderr] 86 | | Trie { [INFO] [stderr] 87 | | nodes: Vec::>::new(), [INFO] [stderr] 88 | | values: Vec::::new(), [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / let mut node_id = 0usize; [INFO] [stderr] 121 | | [INFO] [stderr] 122 | | if self.is_empty() { [INFO] [stderr] 123 | | node_id = self.create_new_node(); [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let node_id = if self.is_empty() { self.create_new_node() } else { 0usize };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | / if self.nodes[node_id].may_be_leaf() { [INFO] [stderr] 194 | | true [INFO] [stderr] 195 | | } else { [INFO] [stderr] 196 | | false [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.nodes[node_id].may_be_leaf()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/trie_node.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | return Some(self.children[idx].1.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.children[idx].1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/trie_node.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | self.value.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Trie` [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> Trie { [INFO] [stderr] 86 | | Trie { [INFO] [stderr] 87 | | nodes: Vec::>::new(), [INFO] [stderr] 88 | | values: Vec::::new(), [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / let mut node_id = 0usize; [INFO] [stderr] 121 | | [INFO] [stderr] 122 | | if self.is_empty() { [INFO] [stderr] 123 | | node_id = self.create_new_node(); [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let node_id = if self.is_empty() { self.create_new_node() } else { 0usize };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | / if self.nodes[node_id].may_be_leaf() { [INFO] [stderr] 194 | | true [INFO] [stderr] 195 | | } else { [INFO] [stderr] 196 | | false [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.nodes[node_id].may_be_leaf()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/basic_benchmark.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `gtrie`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "aa409f43522aceda2f208fd9e8af5df026544070088b93bdc99ec29ca7363181"` [INFO] running `"docker" "rm" "-f" "aa409f43522aceda2f208fd9e8af5df026544070088b93bdc99ec29ca7363181"` [INFO] [stdout] aa409f43522aceda2f208fd9e8af5df026544070088b93bdc99ec29ca7363181