[INFO] crate greenback 0.0.3 is already in cache
[INFO] extracting crate greenback 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/greenback/0.0.3
[INFO] extracting crate greenback 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/greenback/0.0.3
[INFO] validating manifest of greenback-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of greenback-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing greenback-0.0.3
[INFO] finished frobbing greenback-0.0.3
[INFO] frobbed toml for greenback-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/greenback/0.0.3/Cargo.toml
[INFO] started frobbing greenback-0.0.3
[INFO] finished frobbing greenback-0.0.3
[INFO] frobbed toml for greenback-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/greenback/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting greenback-0.0.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/greenback/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0fede700164063db1c823f2e65a0644025821545cb8374aacb71be5dc206c22c
[INFO] running `"docker" "start" "-a" "0fede700164063db1c823f2e65a0644025821545cb8374aacb71be5dc206c22c"`
[INFO] [stderr]     Checking greenback v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:176:14
[INFO] [stderr]     |
[INFO] [stderr] 176 |         test(111111, "$1,111.11");
[INFO] [stderr]     |              ^^^^^^ help: consider: `111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:177:14
[INFO] [stderr]     |
[INFO] [stderr] 177 |         test(1111111, "$11,111.11");
[INFO] [stderr]     |              ^^^^^^^ help: consider: `1_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:178:14
[INFO] [stderr]     |
[INFO] [stderr] 178 |         test(11111111, "$111,111.11");
[INFO] [stderr]     |              ^^^^^^^^ help: consider: `11_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:179:14
[INFO] [stderr]     |
[INFO] [stderr] 179 |         test(111111111, "$1,111,111.11");
[INFO] [stderr]     |              ^^^^^^^^^ help: consider: `111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:180:14
[INFO] [stderr]     |
[INFO] [stderr] 180 |         test(1111111111, "$11,111,111.11");
[INFO] [stderr]     |              ^^^^^^^^^^ help: consider: `1_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:188:15
[INFO] [stderr]     |
[INFO] [stderr] 188 |         test(-111111, "-$1,111.11");
[INFO] [stderr]     |               ^^^^^^ help: consider: `111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:189:15
[INFO] [stderr]     |
[INFO] [stderr] 189 |         test(-1111111, "-$11,111.11");
[INFO] [stderr]     |               ^^^^^^^ help: consider: `1_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:190:15
[INFO] [stderr]     |
[INFO] [stderr] 190 |         test(-11111111, "-$111,111.11");
[INFO] [stderr]     |               ^^^^^^^^ help: consider: `11_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:191:15
[INFO] [stderr]     |
[INFO] [stderr] 191 |         test(-111111111, "-$1,111,111.11");
[INFO] [stderr]     |               ^^^^^^^^^ help: consider: `111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:192:15
[INFO] [stderr]     |
[INFO] [stderr] 192 |         test(-1111111111, "-$11,111,111.11");
[INFO] [stderr]     |               ^^^^^^^^^^ help: consider: `1_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/greenback.rs:39:20
[INFO] [stderr]    |
[INFO] [stderr] 39 |     pub fn dollars(&self) -> i32 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/greenback.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn cents(&self) -> i32 {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/greenback.rs:47:22
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn raw_value(&self) -> i32 {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/greenback.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 | /     fn ne(&self, rhs: &Greenback) -> bool {
[INFO] [stderr] 123 | |         self.raw_value != rhs.raw_value
[INFO] [stderr] 124 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/greenback.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 |         self < rhs || self == rhs
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self <= rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_comparisons)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/greenback.rs:160:9
[INFO] [stderr]     |
[INFO] [stderr] 160 |         self > rhs || self == rhs
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self >= rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/util.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for _ in 1..(num_commas + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^ help: use: `1..=num_commas`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/util.rs:25:45
[INFO] [stderr]    |
[INFO] [stderr] 25 |             byte_string.insert(left_offset, ",".as_bytes()[0]);
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b","`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/greenback.rs:39:20
[INFO] [stderr]    |
[INFO] [stderr] 39 |     pub fn dollars(&self) -> i32 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/greenback.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn cents(&self) -> i32 {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/greenback.rs:47:22
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn raw_value(&self) -> i32 {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stderr]    --> src/greenback.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 | /     fn ne(&self, rhs: &Greenback) -> bool {
[INFO] [stderr] 123 | |         self.raw_value != rhs.raw_value
[INFO] [stderr] 124 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::partialeq_ne_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/greenback.rs:152:9
[INFO] [stderr]     |
[INFO] [stderr] 152 |         self < rhs || self == rhs
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self <= rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_comparisons)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/greenback.rs:160:9
[INFO] [stderr]     |
[INFO] [stderr] 160 |         self > rhs || self == rhs
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self >= rhs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/util.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for _ in 1..(num_commas + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^ help: use: `1..=num_commas`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/util.rs:25:45
[INFO] [stderr]    |
[INFO] [stderr] 25 |             byte_string.insert(left_offset, ",".as_bytes()[0]);
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b","`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         m = m * 5;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `m *= 5`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/lib.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         m = m / 5;
[INFO] [stderr]    |         ^^^^^^^^^ help: replace it with: `m /= 5`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.73s
[INFO] running `"docker" "inspect" "0fede700164063db1c823f2e65a0644025821545cb8374aacb71be5dc206c22c"`
[INFO] running `"docker" "rm" "-f" "0fede700164063db1c823f2e65a0644025821545cb8374aacb71be5dc206c22c"`
[INFO] [stdout] 0fede700164063db1c823f2e65a0644025821545cb8374aacb71be5dc206c22c