[INFO] crate gray-codes 0.1.1 is already in cache [INFO] extracting crate gray-codes 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/gray-codes/0.1.1 [INFO] extracting crate gray-codes 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gray-codes/0.1.1 [INFO] validating manifest of gray-codes-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gray-codes-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gray-codes-0.1.1 [INFO] finished frobbing gray-codes-0.1.1 [INFO] frobbed toml for gray-codes-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gray-codes/0.1.1/Cargo.toml [INFO] started frobbing gray-codes-0.1.1 [INFO] finished frobbing gray-codes-0.1.1 [INFO] frobbed toml for gray-codes-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gray-codes/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gray-codes-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gray-codes/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8e22011047ab4243613be5691d604c66828c1de91d4cc8dfb7e3b275deadd0b [INFO] running `"docker" "start" "-a" "e8e22011047ab4243613be5691d604c66828c1de91d4cc8dfb7e3b275deadd0b"` [INFO] [stderr] Checking gray-codes v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 216 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u8 values"] [INFO] [stderr] 217 | | GrayCode8, u8, 8, gray_code_8, 8); [INFO] [stderr] | |__________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 218 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u16 values"] [INFO] [stderr] 219 | | GrayCode16, u16, 16, gray_code_16, 10); [INFO] [stderr] | |_______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 220 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u32 values"] [INFO] [stderr] 221 | | GrayCode32, u32, 32, gray_code_32, 11); [INFO] [stderr] | |_______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 222 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u64 values"] [INFO] [stderr] 223 | | GrayCode64, u64, 64, gray_code_64, 12); [INFO] [stderr] | |_______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:458:16 [INFO] [stderr] | [INFO] [stderr] 458 | if let Some(_) = self.inc_ex.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 459 | | let collection = self.inc_ex.current_set.iter().enumerate().flat_map(|(i,&b)| { [INFO] [stderr] 460 | | if b { [INFO] [stderr] 461 | | Some(&self.items[i]) [INFO] [stderr] ... | [INFO] [stderr] 466 | | self.next = Some(collection); [INFO] [stderr] 467 | | } [INFO] [stderr] | |_________- help: try this: `if self.inc_ex.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 216 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u8 values"] [INFO] [stderr] 217 | | GrayCode8, u8, 8, gray_code_8, 8); [INFO] [stderr] | |__________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 218 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u16 values"] [INFO] [stderr] 219 | | GrayCode16, u16, 16, gray_code_16, 10); [INFO] [stderr] | |_______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 220 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u32 values"] [INFO] [stderr] 221 | | GrayCode32, u32, 32, gray_code_32, 11); [INFO] [stderr] | |_______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn to_index(code: $uint_ty) -> $uint_ty { [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 222 | / gray_code_impl!(#[doc="Iterator over binary reflected Gray codes as u64 values"] [INFO] [stderr] 223 | | GrayCode64, u64, 64, gray_code_64, 12); [INFO] [stderr] | |_______________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:458:16 [INFO] [stderr] | [INFO] [stderr] 458 | if let Some(_) = self.inc_ex.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 459 | | let collection = self.inc_ex.current_set.iter().enumerate().flat_map(|(i,&b)| { [INFO] [stderr] 460 | | if b { [INFO] [stderr] 461 | | Some(&self.items[i]) [INFO] [stderr] ... | [INFO] [stderr] 466 | | self.next = Some(collection); [INFO] [stderr] 467 | | } [INFO] [stderr] | |_________- help: try this: `if self.inc_ex.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "e8e22011047ab4243613be5691d604c66828c1de91d4cc8dfb7e3b275deadd0b"` [INFO] running `"docker" "rm" "-f" "e8e22011047ab4243613be5691d604c66828c1de91d4cc8dfb7e3b275deadd0b"` [INFO] [stdout] e8e22011047ab4243613be5691d604c66828c1de91d4cc8dfb7e3b275deadd0b