[INFO] crate graphy_static_util 0.3.0 is already in cache [INFO] extracting crate graphy_static_util 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/graphy_static_util/0.3.0 [INFO] extracting crate graphy_static_util 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphy_static_util/0.3.0 [INFO] validating manifest of graphy_static_util-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graphy_static_util-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graphy_static_util-0.3.0 [INFO] finished frobbing graphy_static_util-0.3.0 [INFO] frobbed toml for graphy_static_util-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/graphy_static_util/0.3.0/Cargo.toml [INFO] started frobbing graphy_static_util-0.3.0 [INFO] finished frobbing graphy_static_util-0.3.0 [INFO] frobbed toml for graphy_static_util-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphy_static_util/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graphy_static_util-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphy_static_util/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73c356df68e8019a95b98366cc7f05d3d1fe66d6c264f41b59d63b8a1146d755 [INFO] running `"docker" "start" "-a" "73c356df68e8019a95b98366cc7f05d3d1fe66d6c264f41b59d63b8a1146d755"` [INFO] [stderr] Checking graphy_static_util v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.data.deref() { [INFO] [stderr] 22 | | &Some(ref some) => some, [INFO] [stderr] 23 | | &None => panic!(), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self.data.deref() { [INFO] [stderr] 22 | Some(ref some) => some, [INFO] [stderr] 23 | None => panic!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.data.deref() { [INFO] [stderr] 33 | | &Some(ref some) => some, [INFO] [stderr] 34 | | &None => panic!(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.data.deref() { [INFO] [stderr] 33 | Some(ref some) => some, [INFO] [stderr] 34 | None => panic!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `safe_static::SafeStatic` [INFO] [stderr] --> src/safe_static.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | SafeStatic { [INFO] [stderr] 13 | | data: RwLock::new(None), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/safe_static.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/safe_static.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.data.deref() { [INFO] [stderr] 22 | | &Some(ref some) => some, [INFO] [stderr] 23 | | &None => panic!(), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/safe_static.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = mem::replace(data_ref, Some(value)) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 34 | | panic!(); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________- help: try this: `if mem::replace(data_ref, Some(value)).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self.data.deref() { [INFO] [stderr] 22 | Some(ref some) => some, [INFO] [stderr] 23 | None => panic!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.data.deref() { [INFO] [stderr] 33 | | &Some(ref some) => some, [INFO] [stderr] 34 | | &None => panic!(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.data.deref() { [INFO] [stderr] 33 | Some(ref some) => some, [INFO] [stderr] 34 | None => panic!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `safe_static::SafeStatic` [INFO] [stderr] --> src/safe_static.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | SafeStatic { [INFO] [stderr] 13 | | data: RwLock::new(None), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/safe_static.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/safe_static.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/safe_static.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = mem::replace(data_ref, Some(value)) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 34 | | panic!(); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________- help: try this: `if mem::replace(data_ref, Some(value)).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "73c356df68e8019a95b98366cc7f05d3d1fe66d6c264f41b59d63b8a1146d755"` [INFO] running `"docker" "rm" "-f" "73c356df68e8019a95b98366cc7f05d3d1fe66d6c264f41b59d63b8a1146d755"` [INFO] [stdout] 73c356df68e8019a95b98366cc7f05d3d1fe66d6c264f41b59d63b8a1146d755