[INFO] crate graphify 0.1.0 is already in cache [INFO] extracting crate graphify 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/graphify/0.1.0 [INFO] extracting crate graphify 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphify/0.1.0 [INFO] validating manifest of graphify-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graphify-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graphify-0.1.0 [INFO] finished frobbing graphify-0.1.0 [INFO] frobbed toml for graphify-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/graphify/0.1.0/Cargo.toml [INFO] started frobbing graphify-0.1.0 [INFO] finished frobbing graphify-0.1.0 [INFO] frobbed toml for graphify-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphify/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graphify-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphify/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab46921a8278789c24faa2e6b874a4d5c4ed131a912e6a0c47cae36a5670dca3 [INFO] running `"docker" "start" "-a" "ab46921a8278789c24faa2e6b874a4d5c4ed131a912e6a0c47cae36a5670dca3"` [INFO] [stderr] Checking graphify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/vertex.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | Vertex{ information: information, inputs: Vec::new(), outputs: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `information` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/vertex.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | Vertex{ information: information, inputs: inputs.into_iter().collect(), outputs: outputs.into_iter().collect() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `information` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphify_graph/graphify_graph.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | GraphifyGraph{ graph: Graph::new(), all_graph_information: all_graph_information } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `all_graph_information` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/vertex.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | Vertex{ information: information, inputs: Vec::new(), outputs: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `information` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/vertex.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | Vertex{ information: information, inputs: inputs.into_iter().collect(), outputs: outputs.into_iter().collect() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `information` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphify_graph/graphify_graph.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | GraphifyGraph{ graph: Graph::new(), all_graph_information: all_graph_information } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `all_graph_information` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: #[test] attribute is only allowed on non associated functions [INFO] [stderr] --> src/graph/graph.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn get_vertices_test(&self) -> &Vec>> { [INFO] [stderr] 86 | | &self.vertices [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `graphify`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/graph/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod graph; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph/graph.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | end_vertex_ids [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph/graph.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | / vertices [INFO] [stderr] 168 | | .into_iter() [INFO] [stderr] 169 | | .zip(0..vertices_len) [INFO] [stderr] 170 | | .filter( [INFO] [stderr] ... | [INFO] [stderr] 185 | | ) [INFO] [stderr] 186 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph/graph.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | start_vertex_ids [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph/graph.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | / vertices [INFO] [stderr] 197 | | .into_iter() [INFO] [stderr] 198 | | .zip(0..vertices_len) [INFO] [stderr] 199 | | .filter( [INFO] [stderr] ... | [INFO] [stderr] 214 | | ) [INFO] [stderr] 215 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph/graph.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | vertex_ids [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph/graph.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | / vertices [INFO] [stderr] 230 | | .into_iter() [INFO] [stderr] 231 | | .zip(0..vertices_len) [INFO] [stderr] 232 | | .filter( [INFO] [stderr] ... | [INFO] [stderr] 243 | | ) [INFO] [stderr] 244 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/graphify_graph/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod graphify_graph; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities/static_cast.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return from_as_to; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_as_to` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `graph::graph::Graph` [INFO] [stderr] --> src/graph/graph.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn new() -> Graph { [INFO] [stderr] 68 | | Graph{ vertices: Vec::new() } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/graph/graph.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | visited_vertex_counter = visited_vertex_counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `visited_vertex_counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:112:69 [INFO] [stderr] | [INFO] [stderr] 112 | for output_vertex_id in current_vertex.get_output_ids().into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/graph.rs:113:31 [INFO] [stderr] | [INFO] [stderr] 113 | if !visit_vec[output_vertex_id.clone()] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*output_vertex_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:143:69 [INFO] [stderr] | [INFO] [stderr] 143 | for output_vertex_id in current_vertex.get_output_ids().into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/graph.rs:144:31 [INFO] [stderr] | [INFO] [stderr] 144 | if !visit_vec[output_vertex_id.clone()] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*output_vertex_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:168:18 [INFO] [stderr] | [INFO] [stderr] 168 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/graph/graph.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | / if let &Some(ref vertex) = vertex_option { [INFO] [stderr] 174 | | vertex.is_end_vertex() [INFO] [stderr] 175 | | } else { [INFO] [stderr] 176 | | false [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 173 | if let Some(ref vertex) = *vertex_option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:197:18 [INFO] [stderr] | [INFO] [stderr] 197 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/graph/graph.rs:202:25 [INFO] [stderr] | [INFO] [stderr] 202 | / if let &Some(ref vertex) = vertex_option { [INFO] [stderr] 203 | | vertex.is_start_vertex() [INFO] [stderr] 204 | | } else { [INFO] [stderr] 205 | | false [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 202 | if let Some(ref vertex) = *vertex_option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:252:63 [INFO] [stderr] | [INFO] [stderr] 252 | let input_vertex_ids = removed_vertex.get_input_ids().into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:257:65 [INFO] [stderr] | [INFO] [stderr] 257 | let output_vertex_ids = removed_vertex.get_output_ids().into_iter().cloned(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/graph/graph.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/graph/graph.rs:287:5 [INFO] [stderr] | [INFO] [stderr] 287 | / fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut TInformation { [INFO] [stderr] 288 | | self.inner_get_vertex_mut(vertex_id).get_information_mut() [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/vertex.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/vertex.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | vertex_id == input_vertex_id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*input_vertex_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/graph/vertex.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/vertex.rs:114:38 [INFO] [stderr] | [INFO] [stderr] 114 | vertex_id == output_vertex_id.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*output_vertex_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphify_graph::graphify_graph::GraphifyGraph` [INFO] [stderr] --> src/graphify_graph/graphify_graph.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> GraphifyGraph { [INFO] [stderr] 13 | | GraphifyGraph{ graph: Graph::new(), all_graph_information: Vec::new() } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for graphify_graph::graphify_graph::GraphifyGraph { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/graphify_graph/graphify_graph.rs:26:58 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn get_information_store(&self, index: usize) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&GeneralGraphInformation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/graphify_graph/graphify_graph.rs:30:66 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn get_information_store_mut(&mut self, index: usize) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut GeneralGraphInformation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/graphify_graph/graphify_graph.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | self.graph.add_vertex(information) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 37 | self.graph.add_vertex(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `information::b_tree_map_graph_information::BTreeMapGraphInformation` [INFO] [stderr] --> src/information/b_tree_map_graph_information.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | BTreeMapGraphInformation{ information: BTreeMap::::new() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/information/b_tree_map_graph_information.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | self.information.get(&vertex_id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.information[&vertex_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/b_tree_map_graph_information.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut TInformation { [INFO] [stderr] 56 | | self.information.get_mut(&vertex_id).unwrap() [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/information/general_graph_information.rs:22:37 [INFO] [stderr] | [INFO] [stderr] 22 | let self_as_base = unsafe { mem::transmute::<&mut GeneralGraphInformation, &mut GeneralInformationAssociator>(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut (dyn information::general_graph_information::GeneralGraphInformation + 'static) as *mut dyn information::general_information_associator::GeneralInformationAssociator)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/information/general_graph_information.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | let self_as_base = unsafe { mem::transmute::<&GeneralGraphInformation, &GeneralInformationProvider>(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const (dyn information::general_graph_information::GeneralGraphInformation + 'static) as *const dyn information::general_information_provider::GeneralInformationProvider)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/information/general_graph_information.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | let self_as_base = unsafe { mem::transmute::<&mut GeneralGraphInformation, &mut GeneralInformationProvider>(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut (dyn information::general_graph_information::GeneralGraphInformation + 'static) as *mut (dyn information::general_information_provider::GeneralInformationProvider + 'a))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/information/general_graph_information.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | let self_as_base = unsafe { mem::transmute::<&GeneralGraphInformation, &GeneralInformationProvider>(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const (dyn information::general_graph_information::GeneralGraphInformation + 'static) as *const dyn information::general_information_provider::GeneralInformationProvider)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/general_graph_information.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / pub fn get_information_mut<'a, TInformation>(&'a mut self, vertex_id: usize) -> &'a mut TInformation [INFO] [stderr] 65 | | where TInformation: Any { [INFO] [stderr] 66 | | let self_as_base = unsafe { mem::transmute::<&mut GeneralGraphInformation, &mut GeneralInformationProvider>(self) }; [INFO] [stderr] 67 | | let result = self_as_base.get_information_mut(vertex_id).downcast_mut::(); [INFO] [stderr] 68 | | result.expect("You attempted to cast something from an information provider into an invalid type. Aborting.") [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/information/general_graph_information.rs:66:37 [INFO] [stderr] | [INFO] [stderr] 66 | let self_as_base = unsafe { mem::transmute::<&mut GeneralGraphInformation, &mut GeneralInformationProvider>(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut (dyn information::general_graph_information::GeneralGraphInformation + 'static) as *mut (dyn information::general_information_provider::GeneralInformationProvider + 'a))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/general_information_provider.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut Any; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/general_information_provider.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut Any { [INFO] [stderr] 40 | | let self_as_base = self as &mut InformationProvider; [INFO] [stderr] 41 | | self_as_base.get_information_mut(vertex_id) as &mut Any [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `information::hash_map_graph_information::HashMapGraphInformation` [INFO] [stderr] --> src/information/hash_map_graph_information.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | HashMapGraphInformation{ information: HashMap::::new() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/information/hash_map_graph_information.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | self.information.get(&vertex_id).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.information[&vertex_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/hash_map_graph_information.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut TInformation { [INFO] [stderr] 56 | | self.information.get_mut(&vertex_id).unwrap() [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/information/information_organizer.rs:2:64 [INFO] [stderr] | [INFO] [stderr] 2 | fn reorganize_information(&mut self, new_vertex_id_layout: &Vec); [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/information_provider.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut TInformation; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `information::vec_graph_information::VecGraphInformation` [INFO] [stderr] --> src/information/vec_graph_information.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | VecGraphInformation{ information: Vec::>::new() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/information/vec_graph_information.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/information/vec_graph_information.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/information/vec_graph_information.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / fn get_information_mut<'a>(&'a mut self, vertex_id: usize) -> &'a mut TInformation { [INFO] [stderr] 60 | | self.information[vertex_id].as_mut().unwrap() [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `old_vertex_id` is used to index `new_vertex_id_layout` [INFO] [stderr] --> src/information/vec_graph_information.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | for old_vertex_id in 0..amount_of_old_information { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for (old_vertex_id, ) in new_vertex_id_layout.iter().enumerate().take(amount_of_old_information) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ab46921a8278789c24faa2e6b874a4d5c4ed131a912e6a0c47cae36a5670dca3"` [INFO] running `"docker" "rm" "-f" "ab46921a8278789c24faa2e6b874a4d5c4ed131a912e6a0c47cae36a5670dca3"` [INFO] [stdout] ab46921a8278789c24faa2e6b874a4d5c4ed131a912e6a0c47cae36a5670dca3