[INFO] crate graphic 0.0.1-alpha.2 is already in cache
[INFO] extracting crate graphic 0.0.1-alpha.2 into work/ex/clippy-test-run/sources/stable/reg/graphic/0.0.1-alpha.2
[INFO] extracting crate graphic 0.0.1-alpha.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphic/0.0.1-alpha.2
[INFO] validating manifest of graphic-0.0.1-alpha.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of graphic-0.0.1-alpha.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing graphic-0.0.1-alpha.2
[INFO] finished frobbing graphic-0.0.1-alpha.2
[INFO] frobbed toml for graphic-0.0.1-alpha.2 written to work/ex/clippy-test-run/sources/stable/reg/graphic/0.0.1-alpha.2/Cargo.toml
[INFO] started frobbing graphic-0.0.1-alpha.2
[INFO] finished frobbing graphic-0.0.1-alpha.2
[INFO] frobbed toml for graphic-0.0.1-alpha.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphic/0.0.1-alpha.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting graphic-0.0.1-alpha.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphic/0.0.1-alpha.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0088a0a9213ca108f479f537285c5c1339257b93de2c4f244e86f6b50b3514c4
[INFO] running `"docker" "start" "-a" "0088a0a9213ca108f479f537285c5c1339257b93de2c4f244e86f6b50b3514c4"`
[INFO] [stderr] Checking graphic v0.0.1-alpha.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:65:37
[INFO] [stderr] |
[INFO] [stderr] 65 | self.vertices.push(Vertex { value: value, arcs_out: Vec::new(), arcs_in: Vec::new(), id: id });
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:65:94
[INFO] [stderr] |
[INFO] [stderr] 65 | self.vertices.push(Vertex { value: value, arcs_out: Vec::new(), arcs_in: Vec::new(), id: id });
[INFO] [stderr] | ^^^^^^ help: replace it with: `id`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:74:48
[INFO] [stderr] |
[INFO] [stderr] 74 | let arc = Arc { other: to, weight: weight };
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:83:50
[INFO] [stderr] |
[INFO] [stderr] 83 | let arc = Arc { other: from, weight: weight };
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:103:13
[INFO] [stderr] |
[INFO] [stderr] 103 | visited: visited,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `visited`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:104:13
[INFO] [stderr] |
[INFO] [stderr] 104 | q: q
[INFO] [stderr] | ^^^^ help: replace it with: `q`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:119:13
[INFO] [stderr] |
[INFO] [stderr] 119 | visited: visited,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `visited`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:120:13
[INFO] [stderr] |
[INFO] [stderr] 120 | stack: stack
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stack`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:207:49
[INFO] [stderr] |
[INFO] [stderr] 207 | Some(TopologicalIter { graph: self, order: order })
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:65:37
[INFO] [stderr] |
[INFO] [stderr] 65 | self.vertices.push(Vertex { value: value, arcs_out: Vec::new(), arcs_in: Vec::new(), id: id });
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:65:94
[INFO] [stderr] |
[INFO] [stderr] 65 | self.vertices.push(Vertex { value: value, arcs_out: Vec::new(), arcs_in: Vec::new(), id: id });
[INFO] [stderr] | ^^^^^^ help: replace it with: `id`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:74:48
[INFO] [stderr] |
[INFO] [stderr] 74 | let arc = Arc { other: to, weight: weight };
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:83:50
[INFO] [stderr] |
[INFO] [stderr] 83 | let arc = Arc { other: from, weight: weight };
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:103:13
[INFO] [stderr] |
[INFO] [stderr] 103 | visited: visited,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `visited`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:104:13
[INFO] [stderr] |
[INFO] [stderr] 104 | q: q
[INFO] [stderr] | ^^^^ help: replace it with: `q`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:119:13
[INFO] [stderr] |
[INFO] [stderr] 119 | visited: visited,
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `visited`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:120:13
[INFO] [stderr] |
[INFO] [stderr] 120 | stack: stack
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stack`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/lib.rs:207:49
[INFO] [stderr] |
[INFO] [stderr] 207 | Some(TopologicalIter { graph: self, order: order })
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/lib.rs:144:13
[INFO] [stderr] |
[INFO] [stderr] 144 | return false;
[INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DirectedGraph`
[INFO] [stderr] --> src/lib.rs:38:5
[INFO] [stderr] |
[INFO] [stderr] 38 | / pub fn new() -> DirectedGraph {
[INFO] [stderr] 39 | | DirectedGraph { vertices: Vec::new() }
[INFO] [stderr] 40 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 31 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr] --> src/lib.rs:223:46
[INFO] [stderr] |
[INFO] [stderr] 223 | let other_distance = distances.get(&vertex.id).unwrap() + &arc.weight;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------
[INFO] [stderr] | |
[INFO] [stderr] | help: use the right value directly: `arc.weight`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr]
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr] --> src/lib.rs:223:46
[INFO] [stderr] |
[INFO] [stderr] 223 | let other_distance = distances.get(&vertex.id).unwrap() + &arc.weight;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&distances[&vertex.id]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr]
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr] --> src/lib.rs:224:28
[INFO] [stderr] |
[INFO] [stderr] 224 | if distances.get(&arc.other).unwrap() < &other_distance {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------
[INFO] [stderr] | |
[INFO] [stderr] | help: use the right value directly: `other_distance`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr]
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr] --> src/lib.rs:224:28
[INFO] [stderr] |
[INFO] [stderr] 224 | if distances.get(&arc.other).unwrap() < &other_distance {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&distances[&arc.other]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `UndirectedGraph`
[INFO] [stderr] --> src/lib.rs:351:5
[INFO] [stderr] |
[INFO] [stderr] 351 | / pub fn new() -> UndirectedGraph {
[INFO] [stderr] 352 | | UndirectedGraph { directed: DirectedGraph::new() }
[INFO] [stderr] 353 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 341 | impl Default for UndirectedGraph {
[INFO] [stderr] 342 | fn default() -> Self {
[INFO] [stderr] 343 | Self::new()
[INFO] [stderr] 344 | }
[INFO] [stderr] 345 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr] --> src/lib.rs:144:13
[INFO] [stderr] |
[INFO] [stderr] 144 | return false;
[INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DirectedGraph`
[INFO] [stderr] --> src/lib.rs:38:5
[INFO] [stderr] |
[INFO] [stderr] 38 | / pub fn new() -> DirectedGraph {
[INFO] [stderr] 39 | | DirectedGraph { vertices: Vec::new() }
[INFO] [stderr] 40 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 31 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr] --> src/lib.rs:223:46
[INFO] [stderr] |
[INFO] [stderr] 223 | let other_distance = distances.get(&vertex.id).unwrap() + &arc.weight;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------
[INFO] [stderr] | |
[INFO] [stderr] | help: use the right value directly: `arc.weight`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr]
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr] --> src/lib.rs:223:46
[INFO] [stderr] |
[INFO] [stderr] 223 | let other_distance = distances.get(&vertex.id).unwrap() + &arc.weight;
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&distances[&vertex.id]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr]
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr] --> src/lib.rs:224:28
[INFO] [stderr] |
[INFO] [stderr] 224 | if distances.get(&arc.other).unwrap() < &other_distance {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------
[INFO] [stderr] | |
[INFO] [stderr] | help: use the right value directly: `other_distance`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr]
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr] --> src/lib.rs:224:28
[INFO] [stderr] |
[INFO] [stderr] 224 | if distances.get(&arc.other).unwrap() < &other_distance {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&distances[&arc.other]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `UndirectedGraph`
[INFO] [stderr] --> src/lib.rs:351:5
[INFO] [stderr] |
[INFO] [stderr] 351 | / pub fn new() -> UndirectedGraph {
[INFO] [stderr] 352 | | UndirectedGraph { directed: DirectedGraph::new() }
[INFO] [stderr] 353 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 341 | impl Default for UndirectedGraph {
[INFO] [stderr] 342 | fn default() -> Self {
[INFO] [stderr] 343 | Self::new()
[INFO] [stderr] 344 | }
[INFO] [stderr] 345 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "0088a0a9213ca108f479f537285c5c1339257b93de2c4f244e86f6b50b3514c4"`
[INFO] running `"docker" "rm" "-f" "0088a0a9213ca108f479f537285c5c1339257b93de2c4f244e86f6b50b3514c4"`
[INFO] [stdout] 0088a0a9213ca108f479f537285c5c1339257b93de2c4f244e86f6b50b3514c4