[INFO] crate graphene 0.1.5 is already in cache [INFO] extracting crate graphene 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/graphene/0.1.5 [INFO] extracting crate graphene 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphene/0.1.5 [INFO] validating manifest of graphene-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of graphene-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing graphene-0.1.5 [INFO] finished frobbing graphene-0.1.5 [INFO] frobbed toml for graphene-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/graphene/0.1.5/Cargo.toml [INFO] started frobbing graphene-0.1.5 [INFO] finished frobbing graphene-0.1.5 [INFO] frobbed toml for graphene-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphene/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting graphene-0.1.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/graphene/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f58b0b72cf16e2173e04bbdb146a1dc8cdd9a8f80b9a942893cb874d36bc3e2 [INFO] running `"docker" "start" "-a" "7f58b0b72cf16e2173e04bbdb146a1dc8cdd9a8f80b9a942893cb874d36bc3e2"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking graphene v0.1.5 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common/adjacency_list/mod.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | let mut g = AdjListGraph{ edges: Vec::new(), values: values }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `memchr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `regex`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | let ref operations = self.operations; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let operations = &self.operations;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | let ref mut graph = self.graph; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let graph = &mut self.graph;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:134:7 [INFO] [stderr] | [INFO] [stderr] 134 | let ref operations = self.operations; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------- help: try: `let operations = &self.operations;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/core/constrained_graph.rs:135:7 [INFO] [stderr] | [INFO] [stderr] 135 | let ref mut graph = self.graph; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let graph = &mut self.graph;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/core/constrained_graph.rs:261:2 [INFO] [stderr] | [INFO] [stderr] 261 | fn unconstrained<'a>(&'a mut self) -> Unconstrainer< [INFO] [stderr] | _____^ [INFO] [stderr] 262 | | Self::Vertex, Self::Weight, Self::VertexIter, Self::EdgeIter, Self>{ [INFO] [stderr] 263 | | Unconstrainer::new(self) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/core/constraint/unique.rs:62:10 [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(_) = self.all_edges().into_iter().position( [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if self.all_edges().into_iter().position( [INFO] [stderr] 63 | |edge| edge.source == e.source && edge.sink == e.sink ).is_some() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/core/constraint/unique.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if let Some(_) = v1_to_v2.next(){ [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 98 | | // Invariant doesn't hold [INFO] [stderr] 99 | | return false; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________- help: try this: `if v1_to_v2.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let ref mut t_v_out = self.edges[t_v_i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------- help: try: `let t_v_out = &mut self.edges[t_v_i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t_v_out` [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..t_v_out.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for (i, ) in t_v_out.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref mut t_v_out = self.edges[t_v_i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------- help: try: `let t_v_out = &mut self.edges[t_v_i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `edge_i` is only used to index `t_v_out`. [INFO] [stderr] --> src/common/adjacency_list/impl_base_graph.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | for edge_i in 0..t_v_out.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &mut t_v_out{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/common/adjacency_list/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | Some(self.values[i].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.values[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "7f58b0b72cf16e2173e04bbdb146a1dc8cdd9a8f80b9a942893cb874d36bc3e2"` [INFO] running `"docker" "rm" "-f" "7f58b0b72cf16e2173e04bbdb146a1dc8cdd9a8f80b9a942893cb874d36bc3e2"` [INFO] [stdout] 7f58b0b72cf16e2173e04bbdb146a1dc8cdd9a8f80b9a942893cb874d36bc3e2