[INFO] crate gnuplot 0.0.26 is already in cache [INFO] extracting crate gnuplot 0.0.26 into work/ex/clippy-test-run/sources/stable/reg/gnuplot/0.0.26 [INFO] extracting crate gnuplot 0.0.26 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gnuplot/0.0.26 [INFO] validating manifest of gnuplot-0.0.26 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gnuplot-0.0.26 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gnuplot-0.0.26 [INFO] removed 0 missing examples [INFO] finished frobbing gnuplot-0.0.26 [INFO] frobbed toml for gnuplot-0.0.26 written to work/ex/clippy-test-run/sources/stable/reg/gnuplot/0.0.26/Cargo.toml [INFO] started frobbing gnuplot-0.0.26 [INFO] removed 0 missing examples [INFO] finished frobbing gnuplot-0.0.26 [INFO] frobbed toml for gnuplot-0.0.26 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gnuplot/0.0.26/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gnuplot-0.0.26 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gnuplot/0.0.26:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5928a27e27946613410ce581eadac15c36fe4a07ab390ce8c1048969ac2cdb8a [INFO] running `"docker" "start" "-a" "5928a27e27946613410ce581eadac15c36fe4a07ab390ce8c1048969ac2cdb8a"` [INFO] [stderr] Checking gnuplot v0.0.26 (/opt/crater/workdir) [INFO] [stderr] Checking argparse-rs v0.1.0 [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/axes3d.rs:346:4 [INFO] [stderr] | [INFO] [stderr] 346 | write!(w, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/axes3d.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | write!(w, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:81:4 [INFO] [stderr] | [INFO] [stderr] 81 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:83:4 [INFO] [stderr] | [INFO] [stderr] 83 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:86:4 [INFO] [stderr] | [INFO] [stderr] 86 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:123:4 [INFO] [stderr] | [INFO] [stderr] 123 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:124:4 [INFO] [stderr] | [INFO] [stderr] 124 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:126:4 [INFO] [stderr] | [INFO] [stderr] 126 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:129:4 [INFO] [stderr] | [INFO] [stderr] 129 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:170:4 [INFO] [stderr] | [INFO] [stderr] 170 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:171:4 [INFO] [stderr] | [INFO] [stderr] 171 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:173:4 [INFO] [stderr] | [INFO] [stderr] 173 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:176:4 [INFO] [stderr] | [INFO] [stderr] 176 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:210:4 [INFO] [stderr] | [INFO] [stderr] 210 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:211:4 [INFO] [stderr] | [INFO] [stderr] 211 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:212:4 [INFO] [stderr] | [INFO] [stderr] 212 | num_cols: num_cols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:213:4 [INFO] [stderr] | [INFO] [stderr] 213 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:214:4 [INFO] [stderr] | [INFO] [stderr] 214 | source_type: source_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:215:4 [INFO] [stderr] | [INFO] [stderr] 215 | is_3d: is_3d, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `is_3d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:216:4 [INFO] [stderr] | [INFO] [stderr] 216 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:633:4 [INFO] [stderr] | [INFO] [stderr] 633 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/axes_common.rs:1062:3 [INFO] [stderr] | [INFO] [stderr] 1062 | write!(writer, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/figure.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | match *&mut self.axes[l - 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.axes[l - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/figure.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | match *&mut self.axes[l - 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.axes[l - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/axes3d.rs:346:4 [INFO] [stderr] | [INFO] [stderr] 346 | write!(w, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/axes3d.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | write!(w, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:50:4 [INFO] [stderr] | [INFO] [stderr] 50 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:80:4 [INFO] [stderr] | [INFO] [stderr] 80 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:81:4 [INFO] [stderr] | [INFO] [stderr] 81 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:83:4 [INFO] [stderr] | [INFO] [stderr] 83 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:86:4 [INFO] [stderr] | [INFO] [stderr] 86 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:123:4 [INFO] [stderr] | [INFO] [stderr] 123 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:124:4 [INFO] [stderr] | [INFO] [stderr] 124 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:126:4 [INFO] [stderr] | [INFO] [stderr] 126 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:129:4 [INFO] [stderr] | [INFO] [stderr] 129 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:170:4 [INFO] [stderr] | [INFO] [stderr] 170 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:171:4 [INFO] [stderr] | [INFO] [stderr] 171 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:173:4 [INFO] [stderr] | [INFO] [stderr] 173 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:176:4 [INFO] [stderr] | [INFO] [stderr] 176 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:210:4 [INFO] [stderr] | [INFO] [stderr] 210 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:211:4 [INFO] [stderr] | [INFO] [stderr] 211 | num_rows: num_rows, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:212:4 [INFO] [stderr] | [INFO] [stderr] 212 | num_cols: num_cols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:213:4 [INFO] [stderr] | [INFO] [stderr] 213 | plot_type: plot_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plot_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:214:4 [INFO] [stderr] | [INFO] [stderr] 214 | source_type: source_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:215:4 [INFO] [stderr] | [INFO] [stderr] 215 | is_3d: is_3d, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `is_3d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:216:4 [INFO] [stderr] | [INFO] [stderr] 216 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axes_common.rs:633:4 [INFO] [stderr] | [INFO] [stderr] 633 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/axes_common.rs:1062:3 [INFO] [stderr] | [INFO] [stderr] 1062 | write!(writer, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | first_opt!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 126 | | ArrowType(s) => [INFO] [stderr] 127 | | { [INFO] [stderr] 128 | | c.write_str(match s [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let ArrowType(s) = *o { first_opt!{options, [INFO] [stderr] 12 | ArrowType(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(match s [INFO] [stderr] 15 | { [INFO] [stderr] 16 | Open => "", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | first_opt_default!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 140 | | ArrowSize(z) => [INFO] [stderr] 141 | | { [INFO] [stderr] 142 | | write!(c, "{:.12e}", z); [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let ArrowSize(z) = *o { first_opt_default!{options, [INFO] [stderr] 33 | ArrowSize(z) => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | write!(c, "{:.12e}", z); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/axes2d.rs:170:2 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn set_legend<'l>( [INFO] [stderr] | _____^ [INFO] [stderr] 171 | | &'l mut self, x: Coordinate, y: Coordinate, legend_options: &[LegendOption<&str>], text_options: &[LabelOption<&str>], [INFO] [stderr] 172 | | ) -> &'l mut Self [INFO] [stderr] 173 | | { [INFO] [stderr] ... | [INFO] [stderr] 289 | | self [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 180 | | Placement(h, v) => [INFO] [stderr] 181 | | { [INFO] [stderr] 182 | | c.write_str(match h [INFO] [stderr] ... | [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Placement(h, v) = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Placement(h, v) => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(match h [INFO] [stderr] 36 | { [INFO] [stderr] 37 | AlignLeft => " left", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 202 | | Horizontal => [INFO] [stderr] 203 | | { [INFO] [stderr] 204 | | c.write_str(" horizontal"); [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Horizontal = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Horizontal => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(" horizontal"); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 213 | | Reverse => [INFO] [stderr] 214 | | { [INFO] [stderr] 215 | | c.write_str(" reverse"); [INFO] [stderr] ... | [INFO] [stderr] 220 | | } [INFO] [stderr] 221 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Reverse = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Reverse => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(" reverse"); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 224 | | Invert => [INFO] [stderr] 225 | | { [INFO] [stderr] 226 | | c.write_str(" invert"); [INFO] [stderr] ... | [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Invert = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Invert => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(" invert"); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | first_opt!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 235 | | Title(s) => [INFO] [stderr] 236 | | { [INFO] [stderr] 237 | | c.write_str(" title \""); [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Title(s) = *o { first_opt!{legend_options, [INFO] [stderr] 12 | Title(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(" title \""); [INFO] [stderr] 15 | c.write_str(s); [INFO] [stderr] 16 | c.write_str("\""); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | first_opt!{text_options, [INFO] [stderr] | _____________- [INFO] [stderr] 244 | | Font(f, s) => [INFO] [stderr] 245 | | { [INFO] [stderr] 246 | | c.write_str(" font \""); [INFO] [stderr] ... | [INFO] [stderr] 251 | | } [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Font(f, s) = *o { first_opt!{text_options, [INFO] [stderr] 12 | Font(f, s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(" font \""); [INFO] [stderr] 15 | c.write_str(f); [INFO] [stderr] 16 | c.write_str(","); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | first_opt!{text_options, [INFO] [stderr] | _____________- [INFO] [stderr] 254 | | TextColor(s) => [INFO] [stderr] 255 | | { [INFO] [stderr] 256 | | c.write_str(" textcolor rgb \""); [INFO] [stderr] ... | [INFO] [stderr] 259 | | } [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextColor(s) = *o { first_opt!{text_options, [INFO] [stderr] 12 | TextColor(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(" textcolor rgb \""); [INFO] [stderr] 15 | c.write_str(s); [INFO] [stderr] 16 | c.write_str("\""); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | first_opt!{text_options, [INFO] [stderr] | _____________- [INFO] [stderr] 262 | | TextAlign(a) => [INFO] [stderr] 263 | | { [INFO] [stderr] 264 | | c.write_str(match a [INFO] [stderr] ... | [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextAlign(a) = *o { first_opt!{text_options, [INFO] [stderr] 12 | TextAlign(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(match a [INFO] [stderr] 15 | { [INFO] [stderr] 16 | AlignLeft => " Left", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | first_opt!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 274 | | MaxRows(r) => [INFO] [stderr] 275 | | { [INFO] [stderr] 276 | | write!(c, " maxrows {}", r as i32); [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MaxRows(r) = *o { first_opt!{legend_options, [INFO] [stderr] 12 | MaxRows(r) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, " maxrows {}", r as i32); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | first_opt!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 281 | | MaxCols(l) => [INFO] [stderr] 282 | | { [INFO] [stderr] 283 | | write!(c, " maxcols {}", l as i32); [INFO] [stderr] 284 | | } [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MaxCols(l) = *o { first_opt!{legend_options, [INFO] [stderr] 12 | MaxCols(l) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, " maxcols {}", l as i32); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/axes2d.rs:610:2 [INFO] [stderr] | [INFO] [stderr] 610 | pub fn box_and_whisker_set_width< [INFO] [stderr] | _____^ [INFO] [stderr] 611 | | 'l, [INFO] [stderr] 612 | | Tx: DataType, [INFO] [stderr] 613 | | X: IntoIterator, [INFO] [stderr] ... | [INFO] [stderr] 639 | | self [INFO] [stderr] 640 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/axes2d.rs:694:6 [INFO] [stderr] | [INFO] [stderr] 694 | if self.common.elems.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.common.elems.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:153:2 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn set_view<'l>(&'l mut self, pitch: f64, yaw: f64) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 154 | | { [INFO] [stderr] 155 | | writeln!(&mut self.common.commands, "set view {:.12e},{:.12e}", pitch, yaw); [INFO] [stderr] 156 | | self [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:160:2 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn set_view_map<'l>(&'l mut self) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 161 | | { [INFO] [stderr] 162 | | writeln!(&mut self.common.commands, "set view map"); [INFO] [stderr] 163 | | self [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:208:2 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn set_z_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 209 | | { [INFO] [stderr] 210 | | self.z_axis.set_range(min, max); [INFO] [stderr] 211 | | self [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:215:2 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn set_z_reverse<'l>(&'l mut self, reverse: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 216 | | { [INFO] [stderr] 217 | | self.z_axis.set_reverse(reverse); [INFO] [stderr] 218 | | self [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:225:2 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn set_z_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 226 | | { [INFO] [stderr] 227 | | self.z_axis.set_log(base); [INFO] [stderr] 228 | | self [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:235:2 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn set_z_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 236 | | { [INFO] [stderr] 237 | | self.z_axis.set_grid(show); [INFO] [stderr] 238 | | self [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/axes3d.rs:327:6 [INFO] [stderr] | [INFO] [stderr] 327 | if self.common.elems.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.common.elems.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/axes3d.rs:351:22 [INFO] [stderr] | [INFO] [stderr] 351 | Fix(ref s) => if s.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/axes3d.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | pt.map(|pt| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 390 | || write!(w, "points {}", clamp(pt, 2, 100)); [INFO] [stderr] 391 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(pt) = pt { $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ) }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/axes3d.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | ord.map(|ord| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 402 | || write!(w, "order {}", clamp(ord, 2, 10)); [INFO] [stderr] 403 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(ord) = ord { $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ) }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/axes_common.rs:133:2 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn new_plot6( [INFO] [stderr] | _____^ [INFO] [stderr] 134 | | plot_type: PlotType, x1: X1, x2: X2, x3: X3, x4: X4, x5: X5, x6: X6, options: Vec>, [INFO] [stderr] 135 | | ) -> PlotElement [INFO] [stderr] 136 | | where [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/axes_common.rs:220:2 [INFO] [stderr] | [INFO] [stderr] 220 | fn write_args(&self, writer: &mut Writer) [INFO] [stderr] | _____^ [INFO] [stderr] 221 | | { [INFO] [stderr] 222 | | let options = &self.options; [INFO] [stderr] 223 | | match self.source_type [INFO] [stderr] ... | [INFO] [stderr] 395 | | } [INFO] [stderr] 396 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | match self.source_type [INFO] [stderr] | _________________^ [INFO] [stderr] 253 | | { [INFO] [stderr] 254 | | SizedArray(x1, y1, x2, y2) => [INFO] [stderr] 255 | | { [INFO] [stderr] ... | [INFO] [stderr] 282 | | _ => (), [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let SizedArray(x1, y1, x2, y2) = self.source_type { [INFO] [stderr] 253 | let (x1, x2) = if x1 > x2 { (x2, x1) } else { (x1, x2) }; [INFO] [stderr] 254 | [INFO] [stderr] 255 | let (y1, y2) = if y1 > y2 { (y2, y1) } else { (y1, y2) }; [INFO] [stderr] 256 | write!(writer, "origin=({:.12e},{:.12e}", x1, y1); [INFO] [stderr] 257 | if self.is_3d [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:307:4 [INFO] [stderr] | [INFO] [stderr] 307 | match self.plot_type [INFO] [stderr] | _____________^ [INFO] [stderr] 308 | | { [INFO] [stderr] 309 | | FillBetween => [INFO] [stderr] 310 | | { [INFO] [stderr] ... | [INFO] [stderr] 329 | | _ => (), [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | if let FillBetween = self.plot_type { [INFO] [stderr] 308 | let mut found = false; [INFO] [stderr] 309 | first_opt!{options, [INFO] [stderr] 310 | FillRegion(d) => [INFO] [stderr] 311 | { [INFO] [stderr] 312 | found = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:312:21 [INFO] [stderr] | [INFO] [stderr] 312 | first_opt!{options, [INFO] [stderr] | _____________________- [INFO] [stderr] 313 | | FillRegion(d) => [INFO] [stderr] 314 | | { [INFO] [stderr] 315 | | found = true; [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let FillRegion(d) = *o { first_opt!{options, [INFO] [stderr] 12 | FillRegion(d) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | found = true; [INFO] [stderr] 15 | writer.write_str(match d [INFO] [stderr] 16 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | first_opt!{self.options, [INFO] [stderr] | _____________- [INFO] [stderr] 335 | | FillAlpha(a) => [INFO] [stderr] 336 | | { [INFO] [stderr] 337 | | write!(writer, "{:.12e}", a); [INFO] [stderr] 338 | | } [INFO] [stderr] 339 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let FillAlpha(a) = *o { first_opt!{self.options, [INFO] [stderr] 12 | FillAlpha(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, "{:.12e}", a); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:344:17 [INFO] [stderr] | [INFO] [stderr] 344 | first_opt!{self.options, [INFO] [stderr] | _________________- [INFO] [stderr] 345 | | BorderColor(ref s) => [INFO] [stderr] 346 | | { [INFO] [stderr] 347 | | write!(writer, r#" rgb "{}""#, s); [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let BorderColor(ref s) = *o { first_opt!{self.options, [INFO] [stderr] 12 | BorderColor(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, r#" rgb "{}""#, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | first_opt!{self.options, [INFO] [stderr] | _____________- [INFO] [stderr] 365 | | PointSymbol(s) => [INFO] [stderr] 366 | | { [INFO] [stderr] 367 | | write!(writer, " pt {}", char_to_symbol(s)); [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let PointSymbol(s) = *o { first_opt!{self.options, [INFO] [stderr] 12 | PointSymbol(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, " pt {}", char_to_symbol(s)); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | first_opt!{self.options, [INFO] [stderr] | _____________- [INFO] [stderr] 372 | | PointSize(z) => [INFO] [stderr] 373 | | { [INFO] [stderr] 374 | | write!(writer, " ps {}", z); [INFO] [stderr] 375 | | } [INFO] [stderr] 376 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let PointSize(z) = *o { first_opt!{self.options, [INFO] [stderr] 12 | PointSize(z) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, " ps {}", z); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | first_opt!{self.options, [INFO] [stderr] | _________- [INFO] [stderr] 383 | | Caption(ref s) => [INFO] [stderr] 384 | | { [INFO] [stderr] 385 | | writer.write_str(&s); [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Caption(ref s) = *o { first_opt!{self.options, [INFO] [stderr] 12 | Caption(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | writer.write_str(&s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | first_opt!{self.options, [INFO] [stderr] | _________- [INFO] [stderr] 391 | | WhiskerBars(f) => [INFO] [stderr] 392 | | { [INFO] [stderr] 393 | | write!(writer, " whiskerbars {}", f); [INFO] [stderr] 394 | | } [INFO] [stderr] 395 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let WhiskerBars(f) = *o { first_opt!{self.options, [INFO] [stderr] 12 | WhiskerBars(f) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, " whiskerbars {}", f); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:434:2 [INFO] [stderr] | [INFO] [stderr] 434 | match label_type [INFO] [stderr] | _____^ [INFO] [stderr] 435 | | { [INFO] [stderr] 436 | | Label(x, y) => [INFO] [stderr] 437 | | { [INFO] [stderr] ... | [INFO] [stderr] 440 | | _ => (), [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 434 | if let Label(x, y) = label_type { [INFO] [stderr] 435 | write!(w, " at {},{} front", x, y); [INFO] [stderr] 436 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:443:5 [INFO] [stderr] | [INFO] [stderr] 443 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 444 | | TextOffset(x, y) => [INFO] [stderr] 445 | | { [INFO] [stderr] 446 | | write!(w, " offset character {:.12e},{:.12e}", x, y); [INFO] [stderr] 447 | | } [INFO] [stderr] 448 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextOffset(x, y) = *o { first_opt!{options, [INFO] [stderr] 12 | TextOffset(x, y) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " offset character {:.12e},{:.12e}", x, y); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:450:5 [INFO] [stderr] | [INFO] [stderr] 450 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 451 | | TextColor(ref s) => [INFO] [stderr] 452 | | { [INFO] [stderr] 453 | | write!(w, r#" tc rgb "{}""#, s); [INFO] [stderr] 454 | | } [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextColor(ref s) = *o { first_opt!{options, [INFO] [stderr] 12 | TextColor(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" tc rgb "{}""#, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 458 | | Font(ref f, s) => [INFO] [stderr] 459 | | { [INFO] [stderr] 460 | | write!(w, r#" font "{},{}""#, f, s); [INFO] [stderr] 461 | | } [INFO] [stderr] 462 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Font(ref f, s) = *o { first_opt!{options, [INFO] [stderr] 12 | Font(ref f, s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" font "{},{}""#, f, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 465 | | Rotate(a) => [INFO] [stderr] 466 | | { [INFO] [stderr] 467 | | write!(w, " rotate by {:.12e}", a); [INFO] [stderr] 468 | | } [INFO] [stderr] 469 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Rotate(a) = *o { first_opt!{options, [INFO] [stderr] 12 | Rotate(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " rotate by {:.12e}", a); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:474:9 [INFO] [stderr] | [INFO] [stderr] 474 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 475 | | MarkerSymbol(s) => [INFO] [stderr] 476 | | { [INFO] [stderr] 477 | | write!(w, " point pt {}", char_to_symbol(s)); [INFO] [stderr] 478 | | have_point = true; [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MarkerSymbol(s) = *o { first_opt!{options, [INFO] [stderr] 12 | MarkerSymbol(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " point pt {}", char_to_symbol(s)); [INFO] [stderr] 15 | have_point = true; [INFO] [stderr] 16 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | first_opt!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 485 | | MarkerColor(ref s) => [INFO] [stderr] 486 | | { [INFO] [stderr] 487 | | write!(w, r#" lc rgb "{}""#, s); [INFO] [stderr] 488 | | } [INFO] [stderr] 489 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MarkerColor(ref s) = *o { first_opt!{options, [INFO] [stderr] 12 | MarkerColor(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" lc rgb "{}""#, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | first_opt!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 492 | | MarkerSize(z) => [INFO] [stderr] 493 | | { [INFO] [stderr] 494 | | write!(w, " ps {:.12e}", z); [INFO] [stderr] 495 | | } [INFO] [stderr] 496 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MarkerSize(z) = *o { first_opt!{options, [INFO] [stderr] 12 | MarkerSize(z) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " ps {:.12e}", z); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 500 | | TextAlign(a) => [INFO] [stderr] 501 | | { [INFO] [stderr] 502 | | write!(w, "{}", match a [INFO] [stderr] ... | [INFO] [stderr] 508 | | } [INFO] [stderr] 509 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextAlign(a) = *o { first_opt!{options, [INFO] [stderr] 12 | TextAlign(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, "{}", match a [INFO] [stderr] 15 | { [INFO] [stderr] 16 | AlignLeft => " left", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/axes_common.rs:641:2 [INFO] [stderr] | [INFO] [stderr] 641 | pub fn write_out_commands(&self, w: &mut Writer) [INFO] [stderr] | _____^ [INFO] [stderr] 642 | | { [INFO] [stderr] 643 | | let log = match self.log_base [INFO] [stderr] 644 | | { [INFO] [stderr] ... | [INFO] [stderr] 842 | | w.write_str("\n"); [INFO] [stderr] 843 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:783:13 [INFO] [stderr] | [INFO] [stderr] 783 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 784 | | OnAxis(b) => [INFO] [stderr] 785 | | { [INFO] [stderr] 786 | | w.write_str(match b [INFO] [stderr] ... | [INFO] [stderr] 791 | | } [INFO] [stderr] 792 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let OnAxis(b) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | OnAxis(b) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | w.write_str(match b [INFO] [stderr] 15 | { [INFO] [stderr] 16 | true => " axis", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/axes_common.rs:786:18 [INFO] [stderr] | [INFO] [stderr] 786 | w.write_str(match b [INFO] [stderr] | _________________________________^ [INFO] [stderr] 787 | | { [INFO] [stderr] 788 | | true => " axis", [INFO] [stderr] 789 | | false => " border", [INFO] [stderr] 790 | | }); [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if b { " axis" } else { " border" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:794:13 [INFO] [stderr] | [INFO] [stderr] 794 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 795 | | Mirror(b) => [INFO] [stderr] 796 | | { [INFO] [stderr] 797 | | w.write_str(match b [INFO] [stderr] ... | [INFO] [stderr] 802 | | } [INFO] [stderr] 803 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Mirror(b) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | Mirror(b) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | w.write_str(match b [INFO] [stderr] 15 | { [INFO] [stderr] 16 | true => " mirror", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/axes_common.rs:797:18 [INFO] [stderr] | [INFO] [stderr] 797 | w.write_str(match b [INFO] [stderr] | _________________________________^ [INFO] [stderr] 798 | | { [INFO] [stderr] 799 | | true => " mirror", [INFO] [stderr] 800 | | false => " nomirror", [INFO] [stderr] 801 | | }); [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if b { " mirror" } else { " nomirror" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:805:13 [INFO] [stderr] | [INFO] [stderr] 805 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 806 | | Inward(b) => [INFO] [stderr] 807 | | { [INFO] [stderr] 808 | | w.write_str(match b [INFO] [stderr] ... | [INFO] [stderr] 813 | | } [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Inward(b) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | Inward(b) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | w.write_str(match b [INFO] [stderr] 15 | { [INFO] [stderr] 16 | true => " in", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/axes_common.rs:808:18 [INFO] [stderr] | [INFO] [stderr] 808 | w.write_str(match b [INFO] [stderr] | _________________________________^ [INFO] [stderr] 809 | | { [INFO] [stderr] 810 | | true => " in", [INFO] [stderr] 811 | | false => " out", [INFO] [stderr] 812 | | }); [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if b { " in" } else { " out" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 820 | | MinorScale(s) => [INFO] [stderr] 821 | | { [INFO] [stderr] 822 | | minor_scale = s; [INFO] [stderr] 823 | | } [INFO] [stderr] 824 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MinorScale(s) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | MinorScale(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | minor_scale = s; [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:826:13 [INFO] [stderr] | [INFO] [stderr] 826 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 827 | | MajorScale(s) => [INFO] [stderr] 828 | | { [INFO] [stderr] 829 | | major_scale = s; [INFO] [stderr] 830 | | } [INFO] [stderr] 831 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MajorScale(s) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | MajorScale(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | major_scale = s; [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:835:13 [INFO] [stderr] | [INFO] [stderr] 835 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 836 | | Format(ref f) => [INFO] [stderr] 837 | | { [INFO] [stderr] 838 | | write!(w, r#" format "{}""#, f); [INFO] [stderr] 839 | | } [INFO] [stderr] 840 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Format(ref f) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | Format(ref f) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" format "{}""#, f); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:859:23 [INFO] [stderr] | [INFO] [stderr] 859 | self.tick_options = tick_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tick_options` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:860:24 [INFO] [stderr] | [INFO] [stderr] 860 | self.label_options = label_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `label_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:871:24 [INFO] [stderr] | [INFO] [stderr] 871 | self.tick_options = tick_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tick_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:872:25 [INFO] [stderr] | [INFO] [stderr] 872 | self.label_options = label_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `label_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `axes_common::AxesCommonData` [INFO] [stderr] --> src/axes_common.rs:947:2 [INFO] [stderr] | [INFO] [stderr] 947 | pub fn new() -> AxesCommonData [INFO] [stderr] | _____^ [INFO] [stderr] 948 | | { [INFO] [stderr] 949 | | AxesCommonData { [INFO] [stderr] 950 | | commands: vec![], [INFO] [stderr] ... | [INFO] [stderr] 960 | | } [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 945 | impl Default for axes_common::AxesCommonData { [INFO] [stderr] 946 | fn default() -> Self { [INFO] [stderr] 947 | Self::new() [INFO] [stderr] 948 | } [INFO] [stderr] 949 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:993:9 [INFO] [stderr] | [INFO] [stderr] 993 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 994 | | LineWidth(w) => [INFO] [stderr] 995 | | { [INFO] [stderr] 996 | | write!(c, "{:.12e}", w); [INFO] [stderr] 997 | | found = true; [INFO] [stderr] 998 | | } [INFO] [stderr] 999 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let LineWidth(w) = *o { first_opt!{options, [INFO] [stderr] 12 | LineWidth(w) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, "{:.12e}", w); [INFO] [stderr] 15 | found = true; [INFO] [stderr] 16 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:1007:9 [INFO] [stderr] | [INFO] [stderr] 1007 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 1008 | | LineStyle(d) => [INFO] [stderr] 1009 | | { [INFO] [stderr] 1010 | | write!(c, "{}", d.to_int()); [INFO] [stderr] 1011 | | found = true; [INFO] [stderr] 1012 | | } [INFO] [stderr] 1013 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let LineStyle(d) = *o { first_opt!{options, [INFO] [stderr] 12 | LineStyle(d) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, "{}", d.to_int()); [INFO] [stderr] 15 | found = true; [INFO] [stderr] 16 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:1023:9 [INFO] [stderr] | [INFO] [stderr] 1023 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 1024 | | Color(ref s) => [INFO] [stderr] 1025 | | { [INFO] [stderr] 1026 | | col = Some(&s) [INFO] [stderr] 1027 | | } [INFO] [stderr] 1028 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Color(ref s) = *o { first_opt!{options, [INFO] [stderr] 12 | Color(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | col = Some(&s) [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:1029:3 [INFO] [stderr] | [INFO] [stderr] 1029 | match col [INFO] [stderr] | _________^ [INFO] [stderr] 1030 | | { [INFO] [stderr] 1031 | | Some(s) => [INFO] [stderr] 1032 | | { [INFO] [stderr] ... | [INFO] [stderr] 1035 | | None => (), [INFO] [stderr] 1036 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1029 | if let Some(s) = col { [INFO] [stderr] 1030 | write!(c, r#" lc rgb "{}""#, s); [INFO] [stderr] 1031 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1113:2 [INFO] [stderr] | [INFO] [stderr] 1113 | fn set_pos_grid<'l>(&'l mut self, nrow: u32, ncol: u32, pos: u32) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1114 | | { [INFO] [stderr] 1115 | | assert!(nrow > 0); [INFO] [stderr] 1116 | | assert!(ncol > 0); [INFO] [stderr] ... | [INFO] [stderr] 1124 | | self [INFO] [stderr] 1125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1132:2 [INFO] [stderr] | [INFO] [stderr] 1132 | fn set_pos<'l>(&'l mut self, x: f64, y: f64) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1133 | | { [INFO] [stderr] 1134 | | self.get_common_data_mut().grid_pos = None; [INFO] [stderr] 1135 | | writeln!(&mut self.get_common_data_mut().commands, "set origin {:.12e},{:.12e}", x, y); [INFO] [stderr] 1136 | | self [INFO] [stderr] 1137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1143:2 [INFO] [stderr] | [INFO] [stderr] 1143 | fn set_size<'l>(&'l mut self, w: f64, h: f64) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1144 | | { [INFO] [stderr] 1145 | | writeln!(&mut self.get_common_data_mut().commands, "set size {:.12e},{:.12e}", w, h); [INFO] [stderr] 1146 | | self [INFO] [stderr] 1147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1152:2 [INFO] [stderr] | [INFO] [stderr] 1152 | fn set_aspect_ratio<'l>(&'l mut self, ratio: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1153 | | { [INFO] [stderr] 1154 | | { [INFO] [stderr] 1155 | | let c = &mut self.get_common_data_mut().commands as &mut Writer; [INFO] [stderr] ... | [INFO] [stderr] 1169 | | self [INFO] [stderr] 1170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1336:2 [INFO] [stderr] | [INFO] [stderr] 1336 | fn set_x_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1337 | | { [INFO] [stderr] 1338 | | self.get_common_data_mut().x_axis.set_range(min, max); [INFO] [stderr] 1339 | | self [INFO] [stderr] 1340 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1347:2 [INFO] [stderr] | [INFO] [stderr] 1347 | fn set_y_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1348 | | { [INFO] [stderr] 1349 | | self.get_common_data_mut().y_axis.set_range(min, max); [INFO] [stderr] 1350 | | self [INFO] [stderr] 1351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1356:2 [INFO] [stderr] | [INFO] [stderr] 1356 | fn set_x_reverse<'l>(&'l mut self, reverse: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1357 | | { [INFO] [stderr] 1358 | | self.get_common_data_mut().x_axis.set_reverse(reverse); [INFO] [stderr] 1359 | | self [INFO] [stderr] 1360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1365:2 [INFO] [stderr] | [INFO] [stderr] 1365 | fn set_y_reverse<'l>(&'l mut self, reverse: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1366 | | { [INFO] [stderr] 1367 | | self.get_common_data_mut().y_axis.set_reverse(reverse); [INFO] [stderr] 1368 | | self [INFO] [stderr] 1369 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1376:2 [INFO] [stderr] | [INFO] [stderr] 1376 | fn set_cb_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1377 | | { [INFO] [stderr] 1378 | | self.get_common_data_mut().cb_axis.set_range(min, max); [INFO] [stderr] 1379 | | self [INFO] [stderr] 1380 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1386:2 [INFO] [stderr] | [INFO] [stderr] 1386 | fn set_x_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1387 | | { [INFO] [stderr] 1388 | | self.get_common_data_mut().x_axis.set_log(base); [INFO] [stderr] 1389 | | self [INFO] [stderr] 1390 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1396:2 [INFO] [stderr] | [INFO] [stderr] 1396 | fn set_y_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1397 | | { [INFO] [stderr] 1398 | | self.get_common_data_mut().y_axis.set_log(base); [INFO] [stderr] 1399 | | self [INFO] [stderr] 1400 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1406:2 [INFO] [stderr] | [INFO] [stderr] 1406 | fn set_cb_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1407 | | { [INFO] [stderr] 1408 | | self.get_common_data_mut().cb_axis.set_log(base); [INFO] [stderr] 1409 | | self [INFO] [stderr] 1410 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1416:2 [INFO] [stderr] | [INFO] [stderr] 1416 | fn set_x_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1417 | | { [INFO] [stderr] 1418 | | self.get_common_data_mut().x_axis.set_grid(show); [INFO] [stderr] 1419 | | self [INFO] [stderr] 1420 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1426:2 [INFO] [stderr] | [INFO] [stderr] 1426 | fn set_y_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1427 | | { [INFO] [stderr] 1428 | | self.get_common_data_mut().y_axis.set_grid(show); [INFO] [stderr] 1429 | | self [INFO] [stderr] 1430 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1436:2 [INFO] [stderr] | [INFO] [stderr] 1436 | fn set_cb_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1437 | | { [INFO] [stderr] 1438 | | self.get_common_data_mut().cb_axis.set_grid(show); [INFO] [stderr] 1439 | | self [INFO] [stderr] 1440 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 34 | impl_data_type!(u8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 35 | impl_data_type!(u16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 36 | impl_data_type!(u32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 40 | impl_data_type!(i8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 41 | impl_data_type!(i16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 42 | impl_data_type!(i32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 46 | impl_data_type!(f32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 49 | impl_data_type_ref!(u8); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 50 | impl_data_type_ref!(u16); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 51 | impl_data_type_ref!(u32); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_data_type_ref!(i8); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_data_type_ref!(i16); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_data_type_ref!(i32); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 61 | impl_data_type_ref!(f32); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/figure.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | Axes3DType(Axes3D), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 19 | Axes3DType(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `figure::Figure` [INFO] [stderr] --> src/figure.rs:56:2 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn new() -> Figure [INFO] [stderr] | _____^ [INFO] [stderr] 57 | | { [INFO] [stderr] 58 | | Figure { [INFO] [stderr] 59 | | axes: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:113:6 [INFO] [stderr] | [INFO] [stderr] 113 | if self.axes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.axes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/figure.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | Command::new("gnuplot") [INFO] [stderr] | _________________^ [INFO] [stderr] 122 | | .arg("-p") [INFO] [stderr] 123 | | .stdin(Stdio::piped()) [INFO] [stderr] 124 | | .spawn() [INFO] [stderr] 125 | | .ok() [INFO] [stderr] 126 | | .expect("Couldn't spawn gnuplot. Make sure it is installed and available in PATH."), [INFO] [stderr] | |_______________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/figure.rs:130:3 [INFO] [stderr] | [INFO] [stderr] 130 | self.gnuplot.borrow_mut().as_mut().map(|p| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 131 | || self.echo(p.stdin.as_mut().expect("No stdin!?")); [INFO] [stderr] 132 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(p) = self.gnuplot.borrow_mut().as_mut() { self.echo(p.stdin.as_mut().expect("No stdin!?")); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:151:6 [INFO] [stderr] | [INFO] [stderr] 151 | if self.axes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.axes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:156:6 [INFO] [stderr] | [INFO] [stderr] 156 | if self.terminal.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.terminal.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:161:6 [INFO] [stderr] | [INFO] [stderr] 161 | if self.output_file.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.output_file.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/figure.rs:180:4 [INFO] [stderr] | [INFO] [stderr] 180 | c.grid_pos.map(|pos| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 181 | || let width = 1.0 / (c.grid_cols as f64); [INFO] [stderr] 182 | || let height = 1.0 / (c.grid_rows as f64); [INFO] [stderr] 183 | || let x = (pos % c.grid_cols) as f64 * width; [INFO] [stderr] ... || [INFO] [stderr] 187 | || writeln!(w, "set size {:.12e},{:.12e}", width, height); [INFO] [stderr] 188 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(pos) = c.grid_pos { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | let width = 1.0 / (c.grid_cols as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.grid_cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | let height = 1.0 / (c.grid_rows as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.grid_rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | let x = (pos % c.grid_cols) as f64 * width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pos % c.grid_cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:184:26 [INFO] [stderr] | [INFO] [stderr] 184 | let y = 1.0 - (1.0 + (pos / c.grid_cols) as f64) * height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pos / c.grid_cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:204:6 [INFO] [stderr] | [INFO] [stderr] 204 | if self.axes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.axes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/options.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn to_int(&self) -> i32 [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/figure.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | match *&mut self.axes[l - 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.axes[l - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/figure.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | match *&mut self.axes[l - 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.axes[l - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> examples/example3.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | let x = 8.0 * (j as f64) / w as f64 - 4.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/box_and_whisker.rs:41:2 [INFO] [stderr] | [INFO] [stderr] 41 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/box_and_whisker.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/points_3d.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/points_3d.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/example2.rs:160:2 [INFO] [stderr] | [INFO] [stderr] 160 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/example2.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/lines_3d.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/lines_3d.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/example4.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | .set_custom_palette(palette.iter().map(|&x| x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `palette.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/example4.rs:129:2 [INFO] [stderr] | [INFO] [stderr] 129 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/example4.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/example3.rs:89:2 [INFO] [stderr] | [INFO] [stderr] 89 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/example3.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/lines_points_3d.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/lines_points_3d.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/common.rs:96:3 [INFO] [stderr] | [INFO] [stderr] 96 | self.term.as_ref().map(|t| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 97 | || fg.set_terminal(&t[..], ""); [INFO] [stderr] 98 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/example1.rs:208:2 [INFO] [stderr] | [INFO] [stderr] 208 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { example(c) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/example1.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | Common::new().map(|c| example(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | first_opt!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 126 | | ArrowType(s) => [INFO] [stderr] 127 | | { [INFO] [stderr] 128 | | c.write_str(match s [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let ArrowType(s) = *o { first_opt!{options, [INFO] [stderr] 12 | ArrowType(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(match s [INFO] [stderr] 15 | { [INFO] [stderr] 16 | Open => "", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | first_opt_default!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 140 | | ArrowSize(z) => [INFO] [stderr] 141 | | { [INFO] [stderr] 142 | | write!(c, "{:.12e}", z); [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let ArrowSize(z) = *o { first_opt_default!{options, [INFO] [stderr] 33 | ArrowSize(z) => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | write!(c, "{:.12e}", z); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/axes2d.rs:170:2 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn set_legend<'l>( [INFO] [stderr] | _____^ [INFO] [stderr] 171 | | &'l mut self, x: Coordinate, y: Coordinate, legend_options: &[LegendOption<&str>], text_options: &[LabelOption<&str>], [INFO] [stderr] 172 | | ) -> &'l mut Self [INFO] [stderr] 173 | | { [INFO] [stderr] ... | [INFO] [stderr] 289 | | self [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 180 | | Placement(h, v) => [INFO] [stderr] 181 | | { [INFO] [stderr] 182 | | c.write_str(match h [INFO] [stderr] ... | [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Placement(h, v) = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Placement(h, v) => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(match h [INFO] [stderr] 36 | { [INFO] [stderr] 37 | AlignLeft => " left", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 202 | | Horizontal => [INFO] [stderr] 203 | | { [INFO] [stderr] 204 | | c.write_str(" horizontal"); [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Horizontal = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Horizontal => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(" horizontal"); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 213 | | Reverse => [INFO] [stderr] 214 | | { [INFO] [stderr] 215 | | c.write_str(" reverse"); [INFO] [stderr] ... | [INFO] [stderr] 220 | | } [INFO] [stderr] 221 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Reverse = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Reverse => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(" reverse"); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | match *o [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | $P => [INFO] [stderr] 35 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => () [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | first_opt_default!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 224 | | Invert => [INFO] [stderr] 225 | | { [INFO] [stderr] 226 | | c.write_str(" invert"); [INFO] [stderr] ... | [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Invert = *o { first_opt_default!{legend_options, [INFO] [stderr] 33 | Invert => [INFO] [stderr] 34 | { [INFO] [stderr] 35 | c.write_str(" invert"); [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | _ => [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | first_opt!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 235 | | Title(s) => [INFO] [stderr] 236 | | { [INFO] [stderr] 237 | | c.write_str(" title \""); [INFO] [stderr] ... | [INFO] [stderr] 240 | | } [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Title(s) = *o { first_opt!{legend_options, [INFO] [stderr] 12 | Title(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(" title \""); [INFO] [stderr] 15 | c.write_str(s); [INFO] [stderr] 16 | c.write_str("\""); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | first_opt!{text_options, [INFO] [stderr] | _____________- [INFO] [stderr] 244 | | Font(f, s) => [INFO] [stderr] 245 | | { [INFO] [stderr] 246 | | c.write_str(" font \""); [INFO] [stderr] ... | [INFO] [stderr] 251 | | } [INFO] [stderr] 252 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Font(f, s) = *o { first_opt!{text_options, [INFO] [stderr] 12 | Font(f, s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(" font \""); [INFO] [stderr] 15 | c.write_str(f); [INFO] [stderr] 16 | c.write_str(","); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | first_opt!{text_options, [INFO] [stderr] | _____________- [INFO] [stderr] 254 | | TextColor(s) => [INFO] [stderr] 255 | | { [INFO] [stderr] 256 | | c.write_str(" textcolor rgb \""); [INFO] [stderr] ... | [INFO] [stderr] 259 | | } [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextColor(s) = *o { first_opt!{text_options, [INFO] [stderr] 12 | TextColor(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(" textcolor rgb \""); [INFO] [stderr] 15 | c.write_str(s); [INFO] [stderr] 16 | c.write_str("\""); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | first_opt!{text_options, [INFO] [stderr] | _____________- [INFO] [stderr] 262 | | TextAlign(a) => [INFO] [stderr] 263 | | { [INFO] [stderr] 264 | | c.write_str(match a [INFO] [stderr] ... | [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextAlign(a) = *o { first_opt!{text_options, [INFO] [stderr] 12 | TextAlign(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | c.write_str(match a [INFO] [stderr] 15 | { [INFO] [stderr] 16 | AlignLeft => " Left", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | first_opt!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 274 | | MaxRows(r) => [INFO] [stderr] 275 | | { [INFO] [stderr] 276 | | write!(c, " maxrows {}", r as i32); [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MaxRows(r) = *o { first_opt!{legend_options, [INFO] [stderr] 12 | MaxRows(r) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, " maxrows {}", r as i32); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes2d.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | first_opt!{legend_options, [INFO] [stderr] | _____________- [INFO] [stderr] 281 | | MaxCols(l) => [INFO] [stderr] 282 | | { [INFO] [stderr] 283 | | write!(c, " maxcols {}", l as i32); [INFO] [stderr] 284 | | } [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MaxCols(l) = *o { first_opt!{legend_options, [INFO] [stderr] 12 | MaxCols(l) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, " maxcols {}", l as i32); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/axes2d.rs:610:2 [INFO] [stderr] | [INFO] [stderr] 610 | pub fn box_and_whisker_set_width< [INFO] [stderr] | _____^ [INFO] [stderr] 611 | | 'l, [INFO] [stderr] 612 | | Tx: DataType, [INFO] [stderr] 613 | | X: IntoIterator, [INFO] [stderr] ... | [INFO] [stderr] 639 | | self [INFO] [stderr] 640 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/axes2d.rs:694:6 [INFO] [stderr] | [INFO] [stderr] 694 | if self.common.elems.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.common.elems.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:153:2 [INFO] [stderr] | [INFO] [stderr] 153 | pub fn set_view<'l>(&'l mut self, pitch: f64, yaw: f64) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 154 | | { [INFO] [stderr] 155 | | writeln!(&mut self.common.commands, "set view {:.12e},{:.12e}", pitch, yaw); [INFO] [stderr] 156 | | self [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:160:2 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn set_view_map<'l>(&'l mut self) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 161 | | { [INFO] [stderr] 162 | | writeln!(&mut self.common.commands, "set view map"); [INFO] [stderr] 163 | | self [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:208:2 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn set_z_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 209 | | { [INFO] [stderr] 210 | | self.z_axis.set_range(min, max); [INFO] [stderr] 211 | | self [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:215:2 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn set_z_reverse<'l>(&'l mut self, reverse: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 216 | | { [INFO] [stderr] 217 | | self.z_axis.set_reverse(reverse); [INFO] [stderr] 218 | | self [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:225:2 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn set_z_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 226 | | { [INFO] [stderr] 227 | | self.z_axis.set_log(base); [INFO] [stderr] 228 | | self [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes3d.rs:235:2 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn set_z_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 236 | | { [INFO] [stderr] 237 | | self.z_axis.set_grid(show); [INFO] [stderr] 238 | | self [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/axes3d.rs:327:6 [INFO] [stderr] | [INFO] [stderr] 327 | if self.common.elems.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.common.elems.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/axes3d.rs:351:22 [INFO] [stderr] | [INFO] [stderr] 351 | Fix(ref s) => if s.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/axes3d.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | pt.map(|pt| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 390 | || write!(w, "points {}", clamp(pt, 2, 100)); [INFO] [stderr] 391 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(pt) = pt { $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ) }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/axes3d.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | ord.map(|ord| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 402 | || write!(w, "order {}", clamp(ord, 2, 10)); [INFO] [stderr] 403 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(ord) = ord { $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ) }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/axes_common.rs:133:2 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn new_plot6( [INFO] [stderr] | _____^ [INFO] [stderr] 134 | | plot_type: PlotType, x1: X1, x2: X2, x3: X3, x4: X4, x5: X5, x6: X6, options: Vec>, [INFO] [stderr] 135 | | ) -> PlotElement [INFO] [stderr] 136 | | where [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/axes_common.rs:220:2 [INFO] [stderr] | [INFO] [stderr] 220 | fn write_args(&self, writer: &mut Writer) [INFO] [stderr] | _____^ [INFO] [stderr] 221 | | { [INFO] [stderr] 222 | | let options = &self.options; [INFO] [stderr] 223 | | match self.source_type [INFO] [stderr] ... | [INFO] [stderr] 395 | | } [INFO] [stderr] 396 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | match self.source_type [INFO] [stderr] | _________________^ [INFO] [stderr] 253 | | { [INFO] [stderr] 254 | | SizedArray(x1, y1, x2, y2) => [INFO] [stderr] 255 | | { [INFO] [stderr] ... | [INFO] [stderr] 282 | | _ => (), [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 252 | if let SizedArray(x1, y1, x2, y2) = self.source_type { [INFO] [stderr] 253 | let (x1, x2) = if x1 > x2 { (x2, x1) } else { (x1, x2) }; [INFO] [stderr] 254 | [INFO] [stderr] 255 | let (y1, y2) = if y1 > y2 { (y2, y1) } else { (y1, y2) }; [INFO] [stderr] 256 | write!(writer, "origin=({:.12e},{:.12e}", x1, y1); [INFO] [stderr] 257 | if self.is_3d [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:307:4 [INFO] [stderr] | [INFO] [stderr] 307 | match self.plot_type [INFO] [stderr] | _____________^ [INFO] [stderr] 308 | | { [INFO] [stderr] 309 | | FillBetween => [INFO] [stderr] 310 | | { [INFO] [stderr] ... | [INFO] [stderr] 329 | | _ => (), [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 307 | if let FillBetween = self.plot_type { [INFO] [stderr] 308 | let mut found = false; [INFO] [stderr] 309 | first_opt!{options, [INFO] [stderr] 310 | FillRegion(d) => [INFO] [stderr] 311 | { [INFO] [stderr] 312 | found = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:312:21 [INFO] [stderr] | [INFO] [stderr] 312 | first_opt!{options, [INFO] [stderr] | _____________________- [INFO] [stderr] 313 | | FillRegion(d) => [INFO] [stderr] 314 | | { [INFO] [stderr] 315 | | found = true; [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let FillRegion(d) = *o { first_opt!{options, [INFO] [stderr] 12 | FillRegion(d) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | found = true; [INFO] [stderr] 15 | writer.write_str(match d [INFO] [stderr] 16 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | first_opt!{self.options, [INFO] [stderr] | _____________- [INFO] [stderr] 335 | | FillAlpha(a) => [INFO] [stderr] 336 | | { [INFO] [stderr] 337 | | write!(writer, "{:.12e}", a); [INFO] [stderr] 338 | | } [INFO] [stderr] 339 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let FillAlpha(a) = *o { first_opt!{self.options, [INFO] [stderr] 12 | FillAlpha(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, "{:.12e}", a); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:344:17 [INFO] [stderr] | [INFO] [stderr] 344 | first_opt!{self.options, [INFO] [stderr] | _________________- [INFO] [stderr] 345 | | BorderColor(ref s) => [INFO] [stderr] 346 | | { [INFO] [stderr] 347 | | write!(writer, r#" rgb "{}""#, s); [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let BorderColor(ref s) = *o { first_opt!{self.options, [INFO] [stderr] 12 | BorderColor(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, r#" rgb "{}""#, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | first_opt!{self.options, [INFO] [stderr] | _____________- [INFO] [stderr] 365 | | PointSymbol(s) => [INFO] [stderr] 366 | | { [INFO] [stderr] 367 | | write!(writer, " pt {}", char_to_symbol(s)); [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let PointSymbol(s) = *o { first_opt!{self.options, [INFO] [stderr] 12 | PointSymbol(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, " pt {}", char_to_symbol(s)); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | first_opt!{self.options, [INFO] [stderr] | _____________- [INFO] [stderr] 372 | | PointSize(z) => [INFO] [stderr] 373 | | { [INFO] [stderr] 374 | | write!(writer, " ps {}", z); [INFO] [stderr] 375 | | } [INFO] [stderr] 376 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let PointSize(z) = *o { first_opt!{self.options, [INFO] [stderr] 12 | PointSize(z) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, " ps {}", z); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | first_opt!{self.options, [INFO] [stderr] | _________- [INFO] [stderr] 383 | | Caption(ref s) => [INFO] [stderr] 384 | | { [INFO] [stderr] 385 | | writer.write_str(&s); [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Caption(ref s) = *o { first_opt!{self.options, [INFO] [stderr] 12 | Caption(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | writer.write_str(&s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | first_opt!{self.options, [INFO] [stderr] | _________- [INFO] [stderr] 391 | | WhiskerBars(f) => [INFO] [stderr] 392 | | { [INFO] [stderr] 393 | | write!(writer, " whiskerbars {}", f); [INFO] [stderr] 394 | | } [INFO] [stderr] 395 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let WhiskerBars(f) = *o { first_opt!{self.options, [INFO] [stderr] 12 | WhiskerBars(f) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(writer, " whiskerbars {}", f); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:434:2 [INFO] [stderr] | [INFO] [stderr] 434 | match label_type [INFO] [stderr] | _____^ [INFO] [stderr] 435 | | { [INFO] [stderr] 436 | | Label(x, y) => [INFO] [stderr] 437 | | { [INFO] [stderr] ... | [INFO] [stderr] 440 | | _ => (), [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 434 | if let Label(x, y) = label_type { [INFO] [stderr] 435 | write!(w, " at {},{} front", x, y); [INFO] [stderr] 436 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:443:5 [INFO] [stderr] | [INFO] [stderr] 443 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 444 | | TextOffset(x, y) => [INFO] [stderr] 445 | | { [INFO] [stderr] 446 | | write!(w, " offset character {:.12e},{:.12e}", x, y); [INFO] [stderr] 447 | | } [INFO] [stderr] 448 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextOffset(x, y) = *o { first_opt!{options, [INFO] [stderr] 12 | TextOffset(x, y) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " offset character {:.12e},{:.12e}", x, y); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:450:5 [INFO] [stderr] | [INFO] [stderr] 450 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 451 | | TextColor(ref s) => [INFO] [stderr] 452 | | { [INFO] [stderr] 453 | | write!(w, r#" tc rgb "{}""#, s); [INFO] [stderr] 454 | | } [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextColor(ref s) = *o { first_opt!{options, [INFO] [stderr] 12 | TextColor(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" tc rgb "{}""#, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 458 | | Font(ref f, s) => [INFO] [stderr] 459 | | { [INFO] [stderr] 460 | | write!(w, r#" font "{},{}""#, f, s); [INFO] [stderr] 461 | | } [INFO] [stderr] 462 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Font(ref f, s) = *o { first_opt!{options, [INFO] [stderr] 12 | Font(ref f, s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" font "{},{}""#, f, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:464:5 [INFO] [stderr] | [INFO] [stderr] 464 | first_opt!{options, [INFO] [stderr] | _____- [INFO] [stderr] 465 | | Rotate(a) => [INFO] [stderr] 466 | | { [INFO] [stderr] 467 | | write!(w, " rotate by {:.12e}", a); [INFO] [stderr] 468 | | } [INFO] [stderr] 469 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Rotate(a) = *o { first_opt!{options, [INFO] [stderr] 12 | Rotate(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " rotate by {:.12e}", a); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:474:9 [INFO] [stderr] | [INFO] [stderr] 474 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 475 | | MarkerSymbol(s) => [INFO] [stderr] 476 | | { [INFO] [stderr] 477 | | write!(w, " point pt {}", char_to_symbol(s)); [INFO] [stderr] 478 | | have_point = true; [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MarkerSymbol(s) = *o { first_opt!{options, [INFO] [stderr] 12 | MarkerSymbol(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " point pt {}", char_to_symbol(s)); [INFO] [stderr] 15 | have_point = true; [INFO] [stderr] 16 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | first_opt!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 485 | | MarkerColor(ref s) => [INFO] [stderr] 486 | | { [INFO] [stderr] 487 | | write!(w, r#" lc rgb "{}""#, s); [INFO] [stderr] 488 | | } [INFO] [stderr] 489 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MarkerColor(ref s) = *o { first_opt!{options, [INFO] [stderr] 12 | MarkerColor(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" lc rgb "{}""#, s); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | first_opt!{options, [INFO] [stderr] | _____________- [INFO] [stderr] 492 | | MarkerSize(z) => [INFO] [stderr] 493 | | { [INFO] [stderr] 494 | | write!(w, " ps {:.12e}", z); [INFO] [stderr] 495 | | } [INFO] [stderr] 496 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MarkerSize(z) = *o { first_opt!{options, [INFO] [stderr] 12 | MarkerSize(z) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, " ps {:.12e}", z); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:499:9 [INFO] [stderr] | [INFO] [stderr] 499 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 500 | | TextAlign(a) => [INFO] [stderr] 501 | | { [INFO] [stderr] 502 | | write!(w, "{}", match a [INFO] [stderr] ... | [INFO] [stderr] 508 | | } [INFO] [stderr] 509 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let TextAlign(a) = *o { first_opt!{options, [INFO] [stderr] 12 | TextAlign(a) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, "{}", match a [INFO] [stderr] 15 | { [INFO] [stderr] 16 | AlignLeft => " left", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/axes_common.rs:641:2 [INFO] [stderr] | [INFO] [stderr] 641 | pub fn write_out_commands(&self, w: &mut Writer) [INFO] [stderr] | _____^ [INFO] [stderr] 642 | | { [INFO] [stderr] 643 | | let log = match self.log_base [INFO] [stderr] 644 | | { [INFO] [stderr] ... | [INFO] [stderr] 842 | | w.write_str("\n"); [INFO] [stderr] 843 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:783:13 [INFO] [stderr] | [INFO] [stderr] 783 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 784 | | OnAxis(b) => [INFO] [stderr] 785 | | { [INFO] [stderr] 786 | | w.write_str(match b [INFO] [stderr] ... | [INFO] [stderr] 791 | | } [INFO] [stderr] 792 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let OnAxis(b) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | OnAxis(b) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | w.write_str(match b [INFO] [stderr] 15 | { [INFO] [stderr] 16 | true => " axis", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/axes_common.rs:786:18 [INFO] [stderr] | [INFO] [stderr] 786 | w.write_str(match b [INFO] [stderr] | _________________________________^ [INFO] [stderr] 787 | | { [INFO] [stderr] 788 | | true => " axis", [INFO] [stderr] 789 | | false => " border", [INFO] [stderr] 790 | | }); [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if b { " axis" } else { " border" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:794:13 [INFO] [stderr] | [INFO] [stderr] 794 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 795 | | Mirror(b) => [INFO] [stderr] 796 | | { [INFO] [stderr] 797 | | w.write_str(match b [INFO] [stderr] ... | [INFO] [stderr] 802 | | } [INFO] [stderr] 803 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Mirror(b) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | Mirror(b) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | w.write_str(match b [INFO] [stderr] 15 | { [INFO] [stderr] 16 | true => " mirror", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/axes_common.rs:797:18 [INFO] [stderr] | [INFO] [stderr] 797 | w.write_str(match b [INFO] [stderr] | _________________________________^ [INFO] [stderr] 798 | | { [INFO] [stderr] 799 | | true => " mirror", [INFO] [stderr] 800 | | false => " nomirror", [INFO] [stderr] 801 | | }); [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if b { " mirror" } else { " nomirror" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:805:13 [INFO] [stderr] | [INFO] [stderr] 805 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 806 | | Inward(b) => [INFO] [stderr] 807 | | { [INFO] [stderr] 808 | | w.write_str(match b [INFO] [stderr] ... | [INFO] [stderr] 813 | | } [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Inward(b) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | Inward(b) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | w.write_str(match b [INFO] [stderr] 15 | { [INFO] [stderr] 16 | true => " in", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/axes_common.rs:808:18 [INFO] [stderr] | [INFO] [stderr] 808 | w.write_str(match b [INFO] [stderr] | _________________________________^ [INFO] [stderr] 809 | | { [INFO] [stderr] 810 | | true => " in", [INFO] [stderr] 811 | | false => " out", [INFO] [stderr] 812 | | }); [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if b { " in" } else { " out" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 820 | | MinorScale(s) => [INFO] [stderr] 821 | | { [INFO] [stderr] 822 | | minor_scale = s; [INFO] [stderr] 823 | | } [INFO] [stderr] 824 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MinorScale(s) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | MinorScale(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | minor_scale = s; [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:826:13 [INFO] [stderr] | [INFO] [stderr] 826 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 827 | | MajorScale(s) => [INFO] [stderr] 828 | | { [INFO] [stderr] 829 | | major_scale = s; [INFO] [stderr] 830 | | } [INFO] [stderr] 831 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let MajorScale(s) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | MajorScale(s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | major_scale = s; [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:835:13 [INFO] [stderr] | [INFO] [stderr] 835 | first_opt!{tick_options, [INFO] [stderr] | _____________- [INFO] [stderr] 836 | | Format(ref f) => [INFO] [stderr] 837 | | { [INFO] [stderr] 838 | | write!(w, r#" format "{}""#, f); [INFO] [stderr] 839 | | } [INFO] [stderr] 840 | | } [INFO] [stderr] | |_____________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Format(ref f) = *o { first_opt!{tick_options, [INFO] [stderr] 12 | Format(ref f) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(w, r#" format "{}""#, f); [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:859:23 [INFO] [stderr] | [INFO] [stderr] 859 | self.tick_options = tick_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tick_options` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:860:24 [INFO] [stderr] | [INFO] [stderr] 860 | self.label_options = label_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `label_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:871:24 [INFO] [stderr] | [INFO] [stderr] 871 | self.tick_options = tick_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tick_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/axes_common.rs:872:25 [INFO] [stderr] | [INFO] [stderr] 872 | self.label_options = label_options.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `label_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `axes_common::AxesCommonData` [INFO] [stderr] --> src/axes_common.rs:947:2 [INFO] [stderr] | [INFO] [stderr] 947 | pub fn new() -> AxesCommonData [INFO] [stderr] | _____^ [INFO] [stderr] 948 | | { [INFO] [stderr] 949 | | AxesCommonData { [INFO] [stderr] 950 | | commands: vec![], [INFO] [stderr] ... | [INFO] [stderr] 960 | | } [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 945 | impl Default for axes_common::AxesCommonData { [INFO] [stderr] 946 | fn default() -> Self { [INFO] [stderr] 947 | Self::new() [INFO] [stderr] 948 | } [INFO] [stderr] 949 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:993:9 [INFO] [stderr] | [INFO] [stderr] 993 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 994 | | LineWidth(w) => [INFO] [stderr] 995 | | { [INFO] [stderr] 996 | | write!(c, "{:.12e}", w); [INFO] [stderr] 997 | | found = true; [INFO] [stderr] 998 | | } [INFO] [stderr] 999 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let LineWidth(w) = *o { first_opt!{options, [INFO] [stderr] 12 | LineWidth(w) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, "{:.12e}", w); [INFO] [stderr] 15 | found = true; [INFO] [stderr] 16 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:1007:9 [INFO] [stderr] | [INFO] [stderr] 1007 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 1008 | | LineStyle(d) => [INFO] [stderr] 1009 | | { [INFO] [stderr] 1010 | | write!(c, "{}", d.to_int()); [INFO] [stderr] 1011 | | found = true; [INFO] [stderr] 1012 | | } [INFO] [stderr] 1013 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let LineStyle(d) = *o { first_opt!{options, [INFO] [stderr] 12 | LineStyle(d) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | write!(c, "{}", d.to_int()); [INFO] [stderr] 15 | found = true; [INFO] [stderr] 16 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | match *o [INFO] [stderr] | _____________^ [INFO] [stderr] 12 | | { [INFO] [stderr] 13 | | $P => [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 18 | | _ => () [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/axes_common.rs:1023:9 [INFO] [stderr] | [INFO] [stderr] 1023 | first_opt!{options, [INFO] [stderr] | _________- [INFO] [stderr] 1024 | | Color(ref s) => [INFO] [stderr] 1025 | | { [INFO] [stderr] 1026 | | col = Some(&s) [INFO] [stderr] 1027 | | } [INFO] [stderr] 1028 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Color(ref s) = *o { first_opt!{options, [INFO] [stderr] 12 | Color(ref s) => [INFO] [stderr] 13 | { [INFO] [stderr] 14 | col = Some(&s) [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/axes_common.rs:1029:3 [INFO] [stderr] | [INFO] [stderr] 1029 | match col [INFO] [stderr] | _________^ [INFO] [stderr] 1030 | | { [INFO] [stderr] 1031 | | Some(s) => [INFO] [stderr] 1032 | | { [INFO] [stderr] ... | [INFO] [stderr] 1035 | | None => (), [INFO] [stderr] 1036 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1029 | if let Some(s) = col { [INFO] [stderr] 1030 | write!(c, r#" lc rgb "{}""#, s); [INFO] [stderr] 1031 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1113:2 [INFO] [stderr] | [INFO] [stderr] 1113 | fn set_pos_grid<'l>(&'l mut self, nrow: u32, ncol: u32, pos: u32) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1114 | | { [INFO] [stderr] 1115 | | assert!(nrow > 0); [INFO] [stderr] 1116 | | assert!(ncol > 0); [INFO] [stderr] ... | [INFO] [stderr] 1124 | | self [INFO] [stderr] 1125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1132:2 [INFO] [stderr] | [INFO] [stderr] 1132 | fn set_pos<'l>(&'l mut self, x: f64, y: f64) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1133 | | { [INFO] [stderr] 1134 | | self.get_common_data_mut().grid_pos = None; [INFO] [stderr] 1135 | | writeln!(&mut self.get_common_data_mut().commands, "set origin {:.12e},{:.12e}", x, y); [INFO] [stderr] 1136 | | self [INFO] [stderr] 1137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1143:2 [INFO] [stderr] | [INFO] [stderr] 1143 | fn set_size<'l>(&'l mut self, w: f64, h: f64) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1144 | | { [INFO] [stderr] 1145 | | writeln!(&mut self.get_common_data_mut().commands, "set size {:.12e},{:.12e}", w, h); [INFO] [stderr] 1146 | | self [INFO] [stderr] 1147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1152:2 [INFO] [stderr] | [INFO] [stderr] 1152 | fn set_aspect_ratio<'l>(&'l mut self, ratio: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1153 | | { [INFO] [stderr] 1154 | | { [INFO] [stderr] 1155 | | let c = &mut self.get_common_data_mut().commands as &mut Writer; [INFO] [stderr] ... | [INFO] [stderr] 1169 | | self [INFO] [stderr] 1170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1336:2 [INFO] [stderr] | [INFO] [stderr] 1336 | fn set_x_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1337 | | { [INFO] [stderr] 1338 | | self.get_common_data_mut().x_axis.set_range(min, max); [INFO] [stderr] 1339 | | self [INFO] [stderr] 1340 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1347:2 [INFO] [stderr] | [INFO] [stderr] 1347 | fn set_y_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1348 | | { [INFO] [stderr] 1349 | | self.get_common_data_mut().y_axis.set_range(min, max); [INFO] [stderr] 1350 | | self [INFO] [stderr] 1351 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1356:2 [INFO] [stderr] | [INFO] [stderr] 1356 | fn set_x_reverse<'l>(&'l mut self, reverse: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1357 | | { [INFO] [stderr] 1358 | | self.get_common_data_mut().x_axis.set_reverse(reverse); [INFO] [stderr] 1359 | | self [INFO] [stderr] 1360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1365:2 [INFO] [stderr] | [INFO] [stderr] 1365 | fn set_y_reverse<'l>(&'l mut self, reverse: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1366 | | { [INFO] [stderr] 1367 | | self.get_common_data_mut().y_axis.set_reverse(reverse); [INFO] [stderr] 1368 | | self [INFO] [stderr] 1369 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1376:2 [INFO] [stderr] | [INFO] [stderr] 1376 | fn set_cb_range<'l>(&'l mut self, min: AutoOption, max: AutoOption) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1377 | | { [INFO] [stderr] 1378 | | self.get_common_data_mut().cb_axis.set_range(min, max); [INFO] [stderr] 1379 | | self [INFO] [stderr] 1380 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1386:2 [INFO] [stderr] | [INFO] [stderr] 1386 | fn set_x_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1387 | | { [INFO] [stderr] 1388 | | self.get_common_data_mut().x_axis.set_log(base); [INFO] [stderr] 1389 | | self [INFO] [stderr] 1390 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1396:2 [INFO] [stderr] | [INFO] [stderr] 1396 | fn set_y_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1397 | | { [INFO] [stderr] 1398 | | self.get_common_data_mut().y_axis.set_log(base); [INFO] [stderr] 1399 | | self [INFO] [stderr] 1400 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1406:2 [INFO] [stderr] | [INFO] [stderr] 1406 | fn set_cb_log<'l>(&'l mut self, base: Option) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1407 | | { [INFO] [stderr] 1408 | | self.get_common_data_mut().cb_axis.set_log(base); [INFO] [stderr] 1409 | | self [INFO] [stderr] 1410 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1416:2 [INFO] [stderr] | [INFO] [stderr] 1416 | fn set_x_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1417 | | { [INFO] [stderr] 1418 | | self.get_common_data_mut().x_axis.set_grid(show); [INFO] [stderr] 1419 | | self [INFO] [stderr] 1420 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1426:2 [INFO] [stderr] | [INFO] [stderr] 1426 | fn set_y_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1427 | | { [INFO] [stderr] 1428 | | self.get_common_data_mut().y_axis.set_grid(show); [INFO] [stderr] 1429 | | self [INFO] [stderr] 1430 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/axes_common.rs:1436:2 [INFO] [stderr] | [INFO] [stderr] 1436 | fn set_cb_grid<'l>(&'l mut self, show: bool) -> &'l mut Self [INFO] [stderr] | _____^ [INFO] [stderr] 1437 | | { [INFO] [stderr] 1438 | | self.get_common_data_mut().cb_axis.set_grid(show); [INFO] [stderr] 1439 | | self [INFO] [stderr] 1440 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 34 | impl_data_type!(u8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 35 | impl_data_type!(u16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 36 | impl_data_type!(u32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 40 | impl_data_type!(i8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 41 | impl_data_type!(i16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 42 | impl_data_type!(i32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | **self as f64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(**self)` [INFO] [stderr] ... [INFO] [stderr] 46 | impl_data_type!(f32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 49 | impl_data_type_ref!(u8); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 50 | impl_data_type_ref!(u16); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 51 | impl_data_type_ref!(u32); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 55 | impl_data_type_ref!(i8); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 56 | impl_data_type_ref!(i16); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 57 | impl_data_type_ref!(i32); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/datatype.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | *self as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 61 | impl_data_type_ref!(f32); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/figure.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | Axes3DType(Axes3D), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 19 | Axes3DType(Box), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `figure::Figure` [INFO] [stderr] --> src/figure.rs:56:2 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn new() -> Figure [INFO] [stderr] | _____^ [INFO] [stderr] 57 | | { [INFO] [stderr] 58 | | Figure { [INFO] [stderr] 59 | | axes: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:113:6 [INFO] [stderr] | [INFO] [stderr] 113 | if self.axes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.axes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/figure.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | Command::new("gnuplot") [INFO] [stderr] | _________________^ [INFO] [stderr] 122 | | .arg("-p") [INFO] [stderr] 123 | | .stdin(Stdio::piped()) [INFO] [stderr] 124 | | .spawn() [INFO] [stderr] 125 | | .ok() [INFO] [stderr] 126 | | .expect("Couldn't spawn gnuplot. Make sure it is installed and available in PATH."), [INFO] [stderr] | |_______________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/figure.rs:130:3 [INFO] [stderr] | [INFO] [stderr] 130 | self.gnuplot.borrow_mut().as_mut().map(|p| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 131 | || self.echo(p.stdin.as_mut().expect("No stdin!?")); [INFO] [stderr] 132 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(p) = self.gnuplot.borrow_mut().as_mut() { self.echo(p.stdin.as_mut().expect("No stdin!?")); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:151:6 [INFO] [stderr] | [INFO] [stderr] 151 | if self.axes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.axes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:156:6 [INFO] [stderr] | [INFO] [stderr] 156 | if self.terminal.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.terminal.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:161:6 [INFO] [stderr] | [INFO] [stderr] 161 | if self.output_file.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.output_file.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/figure.rs:180:4 [INFO] [stderr] | [INFO] [stderr] 180 | c.grid_pos.map(|pos| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 181 | || let width = 1.0 / (c.grid_cols as f64); [INFO] [stderr] 182 | || let height = 1.0 / (c.grid_rows as f64); [INFO] [stderr] 183 | || let x = (pos % c.grid_cols) as f64 * width; [INFO] [stderr] ... || [INFO] [stderr] 187 | || writeln!(w, "set size {:.12e},{:.12e}", width, height); [INFO] [stderr] 188 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(pos) = c.grid_pos { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:181:23 [INFO] [stderr] | [INFO] [stderr] 181 | let width = 1.0 / (c.grid_cols as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.grid_cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | let height = 1.0 / (c.grid_rows as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.grid_rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | let x = (pos % c.grid_cols) as f64 * width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pos % c.grid_cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/figure.rs:184:26 [INFO] [stderr] | [INFO] [stderr] 184 | let y = 1.0 - (1.0 + (pos / c.grid_cols) as f64) * height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pos / c.grid_cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/figure.rs:204:6 [INFO] [stderr] | [INFO] [stderr] 204 | if self.axes.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.axes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/options.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn to_int(&self) -> i32 [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "5928a27e27946613410ce581eadac15c36fe4a07ab390ce8c1048969ac2cdb8a"` [INFO] running `"docker" "rm" "-f" "5928a27e27946613410ce581eadac15c36fe4a07ab390ce8c1048969ac2cdb8a"` [INFO] [stdout] 5928a27e27946613410ce581eadac15c36fe4a07ab390ce8c1048969ac2cdb8a