[INFO] crate gitconfig 0.1.0 is already in cache
[INFO] extracting crate gitconfig 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gitconfig/0.1.0
[INFO] extracting crate gitconfig 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitconfig/0.1.0
[INFO] validating manifest of gitconfig-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gitconfig-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gitconfig-0.1.0
[INFO] finished frobbing gitconfig-0.1.0
[INFO] frobbed toml for gitconfig-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gitconfig/0.1.0/Cargo.toml
[INFO] started frobbing gitconfig-0.1.0
[INFO] finished frobbing gitconfig-0.1.0
[INFO] frobbed toml for gitconfig-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitconfig/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gitconfig-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gitconfig/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4e6b380d9b4b36440dfcbd9b9d9992df3669fba833517309737b8efd293c56ab
[INFO] running `"docker" "start" "-a" "4e6b380d9b4b36440dfcbd9b9d9992df3669fba833517309737b8efd293c56ab"`
[INFO] [stderr]     Checking gitconfig v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:55:70
[INFO] [stderr]    |
[INFO] [stderr] 55 |             EntryImpl::Vacant(vacant) => Entry::Vacant(VacantEntry { vacant: vacant }),
[INFO] [stderr]    |                                                                      ^^^^^^^^^^^^^^ help: replace it with: `vacant`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:56:78
[INFO] [stderr]    |
[INFO] [stderr] 56 |             EntryImpl::Occupied(occupied) => Entry::Occupied(OccupiedEntry { occupied: occupied }),
[INFO] [stderr]    |                                                                              ^^^^^^^^^^^^^^^^^^ help: replace it with: `occupied`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:55:70
[INFO] [stderr]    |
[INFO] [stderr] 55 |             EntryImpl::Vacant(vacant) => Entry::Vacant(VacantEntry { vacant: vacant }),
[INFO] [stderr]    |                                                                      ^^^^^^^^^^^^^^ help: replace it with: `vacant`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:56:78
[INFO] [stderr]    |
[INFO] [stderr] 56 |             EntryImpl::Occupied(occupied) => Entry::Occupied(OccupiedEntry { occupied: occupied }),
[INFO] [stderr]    |                                                                              ^^^^^^^^^^^^^^^^^^ help: replace it with: `occupied`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/value.rs:61:21
[INFO] [stderr]    |
[INFO] [stderr] 61 |                     ()
[INFO] [stderr]    |                     ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/value.rs:74:29
[INFO] [stderr]    |
[INFO] [stderr] 74 |                             ()
[INFO] [stderr]    |                             ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/value.rs:83:29
[INFO] [stderr]    |
[INFO] [stderr] 83 |                             ()
[INFO] [stderr]    |                             ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:104:37
[INFO] [stderr]     |
[INFO] [stderr] 104 |                                     ()
[INFO] [stderr]     |                                     ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:113:37
[INFO] [stderr]     |
[INFO] [stderr] 113 |                                     ()
[INFO] [stderr]     |                                     ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:129:29
[INFO] [stderr]     |
[INFO] [stderr] 129 |                             ()
[INFO] [stderr]     |                             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:239:17
[INFO] [stderr]     |
[INFO] [stderr] 239 |                 ()
[INFO] [stderr]     |                 ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/value.rs:275:59
[INFO] [stderr]     |
[INFO] [stderr] 275 |         internal2.insert("key2".to_owned(), Value::Object((internal3)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/value.rs:275:59
[INFO] [stderr]     |
[INFO] [stderr] 275 |         internal2.insert("key2".to_owned(), Value::Object((internal3)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/value.rs:295:59
[INFO] [stderr]     |
[INFO] [stderr] 295 |         internal2.insert("key2".to_owned(), Value::Object((internal3)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/value.rs:295:59
[INFO] [stderr]     |
[INFO] [stderr] 295 |         internal2.insert("key2".to_owned(), Value::Object((internal3)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/value.rs:315:69
[INFO] [stderr]     |
[INFO] [stderr] 315 |         internal2.insert("key2.key3.key4".to_owned(), Value::Object((internal3)));
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/value.rs:315:69
[INFO] [stderr]     |
[INFO] [stderr] 315 |         internal2.insert("key2.key3.key4".to_owned(), Value::Object((internal3)));
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/value.rs:61:21
[INFO] [stderr]    |
[INFO] [stderr] 61 |                     ()
[INFO] [stderr]    |                     ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/value.rs:74:29
[INFO] [stderr]    |
[INFO] [stderr] 74 |                             ()
[INFO] [stderr]    |                             ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/value.rs:83:29
[INFO] [stderr]    |
[INFO] [stderr] 83 |                             ()
[INFO] [stderr]    |                             ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:104:37
[INFO] [stderr]     |
[INFO] [stderr] 104 |                                     ()
[INFO] [stderr]     |                                     ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:113:37
[INFO] [stderr]     |
[INFO] [stderr] 113 |                                     ()
[INFO] [stderr]     |                                     ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/value.rs:129:29
[INFO] [stderr]     |
[INFO] [stderr] 129 |                             ()
[INFO] [stderr]     |                             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/value.rs:46:50
[INFO] [stderr]    |
[INFO] [stderr] 46 |         let git_configs = Vec::from_iter(s.split("\0").map(String::from));
[INFO] [stderr]    |                                                  ^^^^ help: try using a char instead: `'\0'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/value.rs:54:16
[INFO] [stderr]    |
[INFO] [stderr] 54 |             if keys.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/value.rs:57:56
[INFO] [stderr]    |
[INFO] [stderr] 57 |             let split_keys = Vec::from_iter(keys.split(".").map(String::from));
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/value.rs:323:44
[INFO] [stderr]     |
[INFO] [stderr] 323 |     let mut splitter = in_string.splitn(2, "\n");
[INFO] [stderr]     |                                            ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::Map<std::string::String, value::Value>`
[INFO] [stderr]   --> src/map.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | /     pub fn new() -> Self {
[INFO] [stderr] 18 | |         Map { map: MapImpl::new() }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/value.rs:46:50
[INFO] [stderr]    |
[INFO] [stderr] 46 |         let git_configs = Vec::from_iter(s.split("\0").map(String::from));
[INFO] [stderr]    |                                                  ^^^^ help: try using a char instead: `'\0'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/value.rs:54:16
[INFO] [stderr]    |
[INFO] [stderr] 54 |             if keys.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/value.rs:57:56
[INFO] [stderr]    |
[INFO] [stderr] 57 |             let split_keys = Vec::from_iter(keys.split(".").map(String::from));
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/value.rs:323:44
[INFO] [stderr]     |
[INFO] [stderr] 323 |     let mut splitter = in_string.splitn(2, "\n");
[INFO] [stderr]     |                                            ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `map::Map<std::string::String, value::Value>`
[INFO] [stderr]   --> src/map.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | /     pub fn new() -> Self {
[INFO] [stderr] 18 | |         Map { map: MapImpl::new() }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.70s
[INFO] running `"docker" "inspect" "4e6b380d9b4b36440dfcbd9b9d9992df3669fba833517309737b8efd293c56ab"`
[INFO] running `"docker" "rm" "-f" "4e6b380d9b4b36440dfcbd9b9d9992df3669fba833517309737b8efd293c56ab"`
[INFO] [stdout] 4e6b380d9b4b36440dfcbd9b9d9992df3669fba833517309737b8efd293c56ab