[INFO] crate geometric 0.2.0 is already in cache [INFO] extracting crate geometric 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/geometric/0.2.0 [INFO] extracting crate geometric 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geometric/0.2.0 [INFO] validating manifest of geometric-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of geometric-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing geometric-0.2.0 [INFO] finished frobbing geometric-0.2.0 [INFO] frobbed toml for geometric-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/geometric/0.2.0/Cargo.toml [INFO] started frobbing geometric-0.2.0 [INFO] finished frobbing geometric-0.2.0 [INFO] frobbed toml for geometric-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geometric/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting geometric-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/geometric/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 891a860fdecadcf2570487650ce410bd8ee110b3c9950f69b9fe2efe2bf64439 [INFO] running `"docker" "start" "-a" "891a860fdecadcf2570487650ce410bd8ee110b3c9950f69b9fe2efe2bf64439"` [INFO] [stderr] Checking geometric v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..$dim [INFO] [stderr] | ^ help: try replacing the loop by: `out.components[i][..3].clone_from_slice(&scale.components[..3])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / impl_matrix_type!(Matrix3, 3, Vector3, Vector2, { [INFO] [stderr] 23 | | id_func: mat3_id, [INFO] [stderr] 24 | | inv_func: mat3_inv, [INFO] [stderr] 25 | | det_func: mat3_det, [INFO] [stderr] ... | [INFO] [stderr] 28 | | vec_mul_func: col_mat3_transform [INFO] [stderr] 29 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..($dim-1) [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `out.components[$dim - 1][..($dim-1)].clone_from_slice(&translation.components[..($dim-1)])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / impl_matrix_type!(Matrix3, 3, Vector3, Vector2, { [INFO] [stderr] 23 | | id_func: mat3_id, [INFO] [stderr] 24 | | inv_func: mat3_inv, [INFO] [stderr] 25 | | det_func: mat3_det, [INFO] [stderr] ... | [INFO] [stderr] 28 | | vec_mul_func: col_mat3_transform [INFO] [stderr] 29 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..$dim [INFO] [stderr] | ^ help: try replacing the loop by: `out.components[i][..4].clone_from_slice(&scale.components[..4])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl_matrix_type!(Matrix4, 4, Vector4, Vector3, { [INFO] [stderr] 32 | | id_func: mat4_id, [INFO] [stderr] 33 | | inv_func: mat4_inv, [INFO] [stderr] 34 | | det_func: mat4_det, [INFO] [stderr] ... | [INFO] [stderr] 37 | | vec_mul_func: col_mat4_transform [INFO] [stderr] 38 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..($dim-1) [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `out.components[$dim - 1][..($dim-1)].clone_from_slice(&translation.components[..($dim-1)])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl_matrix_type!(Matrix4, 4, Vector4, Vector3, { [INFO] [stderr] 32 | | id_func: mat4_id, [INFO] [stderr] 33 | | inv_func: mat4_inv, [INFO] [stderr] 34 | | det_func: mat4_det, [INFO] [stderr] ... | [INFO] [stderr] 37 | | vec_mul_func: col_mat4_transform [INFO] [stderr] 38 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/vectors/macros.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..count [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output.components[..count].clone_from_slice(&slice[..count])` [INFO] [stderr] | [INFO] [stderr] ::: src/vectors/mod.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | impl_vector_type!(Vector2, 2, [x: 0, y: 1]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/vectors/macros.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..count [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output.components[..count].clone_from_slice(&slice[..count])` [INFO] [stderr] | [INFO] [stderr] ::: src/vectors/mod.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | impl_vector_type!(Vector3, 3, [x: 0, y: 1, z: 2]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/vectors/macros.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..count [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output.components[..count].clone_from_slice(&slice[..count])` [INFO] [stderr] | [INFO] [stderr] ::: src/vectors/mod.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | impl_vector_type!(Vector4, 4, [x: 0, y: 1, z: 2, w: 3]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..$dim [INFO] [stderr] | ^ help: try replacing the loop by: `out.components[i][..3].clone_from_slice(&scale.components[..3])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / impl_matrix_type!(Matrix3, 3, Vector3, Vector2, { [INFO] [stderr] 23 | | id_func: mat3_id, [INFO] [stderr] 24 | | inv_func: mat3_inv, [INFO] [stderr] 25 | | det_func: mat3_det, [INFO] [stderr] ... | [INFO] [stderr] 28 | | vec_mul_func: col_mat3_transform [INFO] [stderr] 29 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..($dim-1) [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `out.components[$dim - 1][..($dim-1)].clone_from_slice(&translation.components[..($dim-1)])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / impl_matrix_type!(Matrix3, 3, Vector3, Vector2, { [INFO] [stderr] 23 | | id_func: mat3_id, [INFO] [stderr] 24 | | inv_func: mat3_inv, [INFO] [stderr] 25 | | det_func: mat3_det, [INFO] [stderr] ... | [INFO] [stderr] 28 | | vec_mul_func: col_mat3_transform [INFO] [stderr] 29 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..$dim [INFO] [stderr] | ^ help: try replacing the loop by: `out.components[i][..4].clone_from_slice(&scale.components[..4])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl_matrix_type!(Matrix4, 4, Vector4, Vector3, { [INFO] [stderr] 32 | | id_func: mat4_id, [INFO] [stderr] 33 | | inv_func: mat4_inv, [INFO] [stderr] 34 | | det_func: mat4_det, [INFO] [stderr] ... | [INFO] [stderr] 37 | | vec_mul_func: col_mat4_transform [INFO] [stderr] 38 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/matrices/macros.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..($dim-1) [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `out.components[$dim - 1][..($dim-1)].clone_from_slice(&translation.components[..($dim-1)])` [INFO] [stderr] | [INFO] [stderr] ::: src/matrices/mod.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / impl_matrix_type!(Matrix4, 4, Vector4, Vector3, { [INFO] [stderr] 32 | | id_func: mat4_id, [INFO] [stderr] 33 | | inv_func: mat4_inv, [INFO] [stderr] 34 | | det_func: mat4_det, [INFO] [stderr] ... | [INFO] [stderr] 37 | | vec_mul_func: col_mat4_transform [INFO] [stderr] 38 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/matrices/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(m.det(), 8.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/matrices/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(m.det(), 8.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/vectors/macros.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..count [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output.components[..count].clone_from_slice(&slice[..count])` [INFO] [stderr] | [INFO] [stderr] ::: src/vectors/mod.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | impl_vector_type!(Vector2, 2, [x: 0, y: 1]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/vectors/macros.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..count [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output.components[..count].clone_from_slice(&slice[..count])` [INFO] [stderr] | [INFO] [stderr] ::: src/vectors/mod.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | impl_vector_type!(Vector3, 3, [x: 0, y: 1, z: 2]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/vectors/macros.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for i in 0..count [INFO] [stderr] | ^^^^^^^^ help: try replacing the loop by: `output.components[..count].clone_from_slice(&slice[..count])` [INFO] [stderr] | [INFO] [stderr] ::: src/vectors/mod.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | impl_vector_type!(Vector4, 4, [x: 0, y: 1, z: 2, w: 3]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vectors/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(a.mag_sq(), 25.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vectors/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(a.mag_sq(), 25.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vectors/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(a.mag(), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vectors/mod.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(a.mag(), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `geometric`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/end_user_test.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(a.dot(b), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/end_user_test.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(a.dot(b), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `geometric`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "891a860fdecadcf2570487650ce410bd8ee110b3c9950f69b9fe2efe2bf64439"` [INFO] running `"docker" "rm" "-f" "891a860fdecadcf2570487650ce410bd8ee110b3c9950f69b9fe2efe2bf64439"` [INFO] [stdout] 891a860fdecadcf2570487650ce410bd8ee110b3c9950f69b9fe2efe2bf64439