[INFO] crate genco 0.3.29 is already in cache [INFO] extracting crate genco 0.3.29 into work/ex/clippy-test-run/sources/stable/reg/genco/0.3.29 [INFO] extracting crate genco 0.3.29 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/genco/0.3.29 [INFO] validating manifest of genco-0.3.29 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of genco-0.3.29 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing genco-0.3.29 [INFO] finished frobbing genco-0.3.29 [INFO] frobbed toml for genco-0.3.29 written to work/ex/clippy-test-run/sources/stable/reg/genco/0.3.29/Cargo.toml [INFO] started frobbing genco-0.3.29 [INFO] finished frobbing genco-0.3.29 [INFO] frobbed toml for genco-0.3.29 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/genco/0.3.29/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting genco-0.3.29 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/genco/0.3.29:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 580980caeb0d300ae9526908a562a9cf91596a1bf118d7df9345b09886790b4c [INFO] running `"docker" "start" "-a" "580980caeb0d300ae9526908a562a9cf91596a1bf118d7df9345b09886790b4c"` [INFO] [stderr] Checking genco v0.3.29 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csharp/mod.rs:183:21 [INFO] [stderr] | [INFO] [stderr] 183 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csharp/mod.rs:279:17 [INFO] [stderr] | [INFO] [stderr] 279 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dart/mod.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | write: write, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/java/mod.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/java/mod.rs:238:17 [INFO] [stderr] | [INFO] [stderr] 238 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rust.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:180:22 [INFO] [stderr] | [INFO] [stderr] 180 | WalkCustom { queue: queue } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csharp/mod.rs:183:21 [INFO] [stderr] | [INFO] [stderr] 183 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csharp/mod.rs:279:17 [INFO] [stderr] | [INFO] [stderr] 279 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dart/mod.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | write: write, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/java/mod.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/java/mod.rs:238:17 [INFO] [stderr] | [INFO] [stderr] 238 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rust.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:180:22 [INFO] [stderr] | [INFO] [stderr] 180 | WalkCustom { queue: queue } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dart/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return o; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `o` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | _t [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | return toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let mut _t = $crate::Tokens::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | return toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | _t [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let mut o = toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let mut _t = $crate::Tokens::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let mut o = toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tokens.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn nested_into(&mut self, builder: B) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tokens.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn push_into(&mut self, builder: B) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dart/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return o; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `o` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | _t [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | return toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let mut _t = $crate::Tokens::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | return toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | _t [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let mut o = toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let mut _t = $crate::Tokens::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/dart/mod.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let mut o = toks!(); [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tokens.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn nested_into(&mut self, builder: B) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/tokens.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn push_into(&mut self, builder: B) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `csharp::constructor::Constructor<'el>` [INFO] [stderr] --> src/csharp/constructor.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Constructor<'el> { [INFO] [stderr] 30 | | Constructor { [INFO] [stderr] 31 | | modifiers: vec![Modifier::Public], [INFO] [stderr] 32 | | arguments: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for csharp::constructor::Constructor<'el> { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/csharp/mod.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | / self.as_optional() [INFO] [stderr] 387 | | .map(|opt| opt.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `self.as_optional().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/csharp/mod.rs:469:29 [INFO] [stderr] | [INFO] [stderr] 469 | let qualified = match inner.qualified { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 470 | | true => true, [INFO] [stderr] 471 | | false => { [INFO] [stderr] 472 | | let file_namespace = extra.namespace.as_ref().map(|p| p.as_ref()); [INFO] [stderr] ... | [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 469 | let qualified = if inner.qualified { true } else { [INFO] [stderr] 470 | let file_namespace = extra.namespace.as_ref().map(|p| p.as_ref()); [INFO] [stderr] 471 | let imported = extra [INFO] [stderr] 472 | .imported_names [INFO] [stderr] 473 | .get(inner.name.as_ref()) [INFO] [stderr] 474 | .map(String::as_str); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/csharp/mod.rs:493:33 [INFO] [stderr] | [INFO] [stderr] 493 | while let Some(n) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for n in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/csharp/mod.rs:527:31 [INFO] [stderr] | [INFO] [stderr] 527 | out.write_str(alias.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `alias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/dart/mod.rs:206:31 [INFO] [stderr] | [INFO] [stderr] 206 | out.write_str(name.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formatter.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formatter.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/go.rs:122:85 [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(module) = module.as_ref().and_then(|m| m.as_ref().split("/").last()) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `java::constructor::Constructor<'el>` [INFO] [stderr] --> src/java/constructor.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Constructor<'el> { [INFO] [stderr] 30 | | Constructor { [INFO] [stderr] 31 | | modifiers: vec![Modifier::Public], [INFO] [stderr] 32 | | annotations: Tokens::new(), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for java::constructor::Constructor<'el> { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/java/mod.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / match *java { [INFO] [stderr] 181 | | Class(ref class) => { [INFO] [stderr] 182 | | for argument in &class.arguments { [INFO] [stderr] 183 | | Self::type_imports(argument, modules); [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => {} [INFO] [stderr] 189 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | if let Class(ref class) = *java { [INFO] [stderr] 181 | for argument in &class.arguments { [INFO] [stderr] 182 | Self::type_imports(argument, modules); [INFO] [stderr] 183 | } [INFO] [stderr] 184 | [INFO] [stderr] 185 | modules.insert((class.package.as_ref(), class.name.as_ref())); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/java/mod.rs:403:35 [INFO] [stderr] | [INFO] [stderr] 403 | out.write_str(boxed.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `boxed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/java/mod.rs:405:35 [INFO] [stderr] | [INFO] [stderr] 405 | out.write_str(primitive.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `primitive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/java/mod.rs:425:41 [INFO] [stderr] | [INFO] [stderr] 425 | while let Some(n) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for n in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tokens.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | self.elements.push(Push(Borrowed(tokens.into()))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:215:25 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn to_file_with(self, mut extra: C::Extra) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn to_string_with(self, mut extra: C::Extra) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | pub fn to_file(self) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | pub fn to_string(self) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/tokens.rs:267:32 [INFO] [stderr] | [INFO] [stderr] 267 | while let Some(next) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for next in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/csharp/class.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | c.implements = vec![local("Super").into()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `local("Super")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `csharp::constructor::Constructor<'el>` [INFO] [stderr] --> src/csharp/constructor.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Constructor<'el> { [INFO] [stderr] 30 | | Constructor { [INFO] [stderr] 31 | | modifiers: vec![Modifier::Public], [INFO] [stderr] 32 | | arguments: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for csharp::constructor::Constructor<'el> { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/csharp/mod.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | / self.as_optional() [INFO] [stderr] 387 | | .map(|opt| opt.clone()) [INFO] [stderr] | |___________________________________^ help: Consider calling the dedicated `cloned` method: `self.as_optional().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/csharp/mod.rs:469:29 [INFO] [stderr] | [INFO] [stderr] 469 | let qualified = match inner.qualified { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 470 | | true => true, [INFO] [stderr] 471 | | false => { [INFO] [stderr] 472 | | let file_namespace = extra.namespace.as_ref().map(|p| p.as_ref()); [INFO] [stderr] ... | [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 469 | let qualified = if inner.qualified { true } else { [INFO] [stderr] 470 | let file_namespace = extra.namespace.as_ref().map(|p| p.as_ref()); [INFO] [stderr] 471 | let imported = extra [INFO] [stderr] 472 | .imported_names [INFO] [stderr] 473 | .get(inner.name.as_ref()) [INFO] [stderr] 474 | .map(String::as_str); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/csharp/mod.rs:493:33 [INFO] [stderr] | [INFO] [stderr] 493 | while let Some(n) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for n in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/csharp/mod.rs:527:31 [INFO] [stderr] | [INFO] [stderr] 527 | out.write_str(alias.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `alias` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/dart/mod.rs:206:31 [INFO] [stderr] | [INFO] [stderr] 206 | out.write_str(name.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formatter.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formatter.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/go.rs:122:85 [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(module) = module.as_ref().and_then(|m| m.as_ref().split("/").last()) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/java/class.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | c.implements = vec![local("Super").into()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `local("Super")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `java::constructor::Constructor<'el>` [INFO] [stderr] --> src/java/constructor.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Constructor<'el> { [INFO] [stderr] 30 | | Constructor { [INFO] [stderr] 31 | | modifiers: vec![Modifier::Public], [INFO] [stderr] 32 | | annotations: Tokens::new(), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | impl Default for java::constructor::Constructor<'el> { [INFO] [stderr] 28 | fn default() -> Self { [INFO] [stderr] 29 | Self::new() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/java/mod.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / match *java { [INFO] [stderr] 181 | | Class(ref class) => { [INFO] [stderr] 182 | | for argument in &class.arguments { [INFO] [stderr] 183 | | Self::type_imports(argument, modules); [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => {} [INFO] [stderr] 189 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 180 | if let Class(ref class) = *java { [INFO] [stderr] 181 | for argument in &class.arguments { [INFO] [stderr] 182 | Self::type_imports(argument, modules); [INFO] [stderr] 183 | } [INFO] [stderr] 184 | [INFO] [stderr] 185 | modules.insert((class.package.as_ref(), class.name.as_ref())); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/java/mod.rs:403:35 [INFO] [stderr] | [INFO] [stderr] 403 | out.write_str(boxed.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `boxed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/java/mod.rs:405:35 [INFO] [stderr] | [INFO] [stderr] 405 | out.write_str(primitive.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `primitive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/java/mod.rs:425:41 [INFO] [stderr] | [INFO] [stderr] 425 | while let Some(n) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for n in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tokens.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | self.elements.push(Push(Borrowed(tokens.into()))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:215:25 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn to_file_with(self, mut extra: C::Extra) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn to_string_with(self, mut extra: C::Extra) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | pub fn to_file(self) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/tokens.rs:236:22 [INFO] [stderr] | [INFO] [stderr] 236 | pub fn to_string(self) -> result::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/tokens.rs:267:32 [INFO] [stderr] | [INFO] [stderr] 267 | while let Some(next) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for next in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.60s [INFO] running `"docker" "inspect" "580980caeb0d300ae9526908a562a9cf91596a1bf118d7df9345b09886790b4c"` [INFO] running `"docker" "rm" "-f" "580980caeb0d300ae9526908a562a9cf91596a1bf118d7df9345b09886790b4c"` [INFO] [stdout] 580980caeb0d300ae9526908a562a9cf91596a1bf118d7df9345b09886790b4c