[INFO] crate gds 0.1.2 is already in cache [INFO] extracting crate gds 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/gds/0.1.2 [INFO] extracting crate gds 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gds/0.1.2 [INFO] validating manifest of gds-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gds-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gds-0.1.2 [INFO] finished frobbing gds-0.1.2 [INFO] frobbed toml for gds-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/gds/0.1.2/Cargo.toml [INFO] started frobbing gds-0.1.2 [INFO] finished frobbing gds-0.1.2 [INFO] frobbed toml for gds-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gds/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gds-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gds/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d08de99a94edad8241fa58384f1bc62b97aa96d60e7f1f4006558fec80102f1 [INFO] running `"docker" "start" "-a" "4d08de99a94edad8241fa58384f1bc62b97aa96d60e7f1f4006558fec80102f1"` [INFO] [stderr] Checking gds v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:17 [INFO] [stderr] | [INFO] [stderr] 447 | Library{version: version, name: name, date_mod: date_mod, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:35 [INFO] [stderr] | [INFO] [stderr] 447 | Library{version: version, name: name, date_mod: date_mod, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:47 [INFO] [stderr] | [INFO] [stderr] 447 | Library{version: version, name: name, date_mod: date_mod, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `date_mod` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | date_acc: date_acc, units_user: units_user, units_m: units_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `date_acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:33 [INFO] [stderr] | [INFO] [stderr] 448 | date_acc: date_acc, units_user: units_user, units_m: units_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `units_user` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:57 [INFO] [stderr] | [INFO] [stderr] 448 | date_acc: date_acc, units_user: units_user, units_m: units_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `units_m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | structures: structures} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:16 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:28 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:48 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:70 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:16 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:28 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:48 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:70 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:552:39 [INFO] [stderr] | [INFO] [stderr] 552 | let mut rec = Record{size: 0, rec_type: rec_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | data_type: data_type, data: vec![data]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:16 [INFO] [stderr] | [INFO] [stderr] 647 | Record{size: size, rec_type: rec_type, data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:28 [INFO] [stderr] | [INFO] [stderr] 647 | Record{size: size, rec_type: rec_type, data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:48 [INFO] [stderr] | [INFO] [stderr] 647 | Record{size: size, rec_type: rec_type, data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:648:13 [INFO] [stderr] | [INFO] [stderr] 648 | data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:17 [INFO] [stderr] | [INFO] [stderr] 447 | Library{version: version, name: name, date_mod: date_mod, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:35 [INFO] [stderr] | [INFO] [stderr] 447 | Library{version: version, name: name, date_mod: date_mod, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:47 [INFO] [stderr] | [INFO] [stderr] 447 | Library{version: version, name: name, date_mod: date_mod, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `date_mod` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | date_acc: date_acc, units_user: units_user, units_m: units_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `date_acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:33 [INFO] [stderr] | [INFO] [stderr] 448 | date_acc: date_acc, units_user: units_user, units_m: units_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `units_user` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:448:57 [INFO] [stderr] | [INFO] [stderr] 448 | date_acc: date_acc, units_user: units_user, units_m: units_m, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `units_m` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | structures: structures} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:16 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:28 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:48 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:532:70 [INFO] [stderr] | [INFO] [stderr] 532 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:16 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:28 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:48 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:543:70 [INFO] [stderr] | [INFO] [stderr] 543 | Record{size: size, rec_type: rec_type, data_type: data_type, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:552:39 [INFO] [stderr] | [INFO] [stderr] 552 | let mut rec = Record{size: 0, rec_type: rec_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | data_type: data_type, data: vec![data]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:16 [INFO] [stderr] | [INFO] [stderr] 647 | Record{size: size, rec_type: rec_type, data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:28 [INFO] [stderr] | [INFO] [stderr] 647 | Record{size: size, rec_type: rec_type, data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rec_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:647:48 [INFO] [stderr] | [INFO] [stderr] 647 | Record{size: size, rec_type: rec_type, data_type: data_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:648:13 [INFO] [stderr] | [INFO] [stderr] 648 | data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let exp: i8 = ((0b01111111 & bytes[0]) as i8) - 64 - 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | if (0b10000000 & bytes[0]) == 0{ [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | let exp: i8 = ((0b01111111 & bytes[0]) as i8) - 64 - 14; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if (0b10000000 & bytes[0]) == 0{ [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | exp |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | exp &= 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | exp |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | exp &= 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let exp: i8 = ((0b01111111 & bytes[0]) as i8) - 64 - 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | if (0b10000000 & bytes[0]) == 0{ [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | let exp: i8 = ((0b01111111 & bytes[0]) as i8) - 64 - 14; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if (0b10000000 & bytes[0]) == 0{ [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | exp |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | exp &= 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:100:16 [INFO] [stderr] | [INFO] [stderr] 100 | exp |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | exp &= 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | -man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | -man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Date` [INFO] [stderr] --> src/lib.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / pub fn new() -> Date { [INFO] [stderr] 213 | | Date{year: 1970, month: 1, day: 1, hour: 0, minute: 0, second: 0} [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 61 [INFO] [stderr] --> src/lib.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / pub fn read(s: &str) -> Library { [INFO] [stderr] 240 | | let mut file = File::open(s).unwrap(); [INFO] [stderr] 241 | | let mut version = 0; [INFO] [stderr] 242 | | let mut name: String = String::from(""); [INFO] [stderr] ... | [INFO] [stderr] 449 | | structures: structures} [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d_data` [INFO] [stderr] --> src/lib.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | for i in 0..12 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 257 | for (i, ) in d_data.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d_data` [INFO] [stderr] --> src/lib.rs:290:26 [INFO] [stderr] | [INFO] [stderr] 290 | for i in 0..12 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 290 | for (i, ) in d_data.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | / match rec.data.get(0) { [INFO] [stderr] 327 | | Some(&RecordData::Int16(x)) => [INFO] [stderr] 328 | | elem.parameters.push(ElementParameter::Layer(x)), [INFO] [stderr] 329 | | _ => {} [INFO] [stderr] 330 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push(ElementParameter::Layer(x)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:337:21 [INFO] [stderr] | [INFO] [stderr] 337 | / match rec.data.get(c) { [INFO] [stderr] 338 | | Some(&RecordData::Int32(x)) => x_coord = x, [INFO] [stderr] 339 | | _ => {} [INFO] [stderr] 340 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(&RecordData::Int32(x)) = rec.data.get(c) { x_coord = x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:341:21 [INFO] [stderr] | [INFO] [stderr] 341 | / match rec.data.get(c+1) { [INFO] [stderr] 342 | | Some(&RecordData::Int32(x)) => y_coord = x, [INFO] [stderr] 343 | | _ => {} [INFO] [stderr] 344 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(&RecordData::Int32(x)) = rec.data.get(c+1) { y_coord = x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / match rec.data.get(0) { [INFO] [stderr] 351 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 352 | | ElementParameter::Datatype(x)), [INFO] [stderr] 353 | | _ => {} [INFO] [stderr] 354 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 351 | ElementParameter::Datatype(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | / match rec.data.get(0) { [INFO] [stderr] 357 | | Some(&RecordData::Int32(x)) => elem.parameters.push( [INFO] [stderr] 358 | | ElementParameter::Width(x)), [INFO] [stderr] 359 | | _ => {} [INFO] [stderr] 360 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 356 | if let Some(&RecordData::Int32(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 357 | ElementParameter::Width(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | / match rec.data.get(0) { [INFO] [stderr] 363 | | Some(&RecordData::Str(ref x)) => elem.parameters.push( [INFO] [stderr] 364 | | ElementParameter::StructureName(x.clone())), [INFO] [stderr] 365 | | _ => {} [INFO] [stderr] 366 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | if let Some(&RecordData::Str(ref x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 363 | ElementParameter::StructureName(x.clone())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:372:21 [INFO] [stderr] | [INFO] [stderr] 372 | / match rec.data.get(c) { [INFO] [stderr] 373 | | Some(&RecordData::Int16(x)) => colrow = x, [INFO] [stderr] 374 | | _ => {} [INFO] [stderr] 375 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(&RecordData::Int16(x)) = rec.data.get(c) { colrow = x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | / match rec.data.get(0) { [INFO] [stderr] 382 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 383 | | ElementParameter::TextType(x)), [INFO] [stderr] 384 | | _ => {} [INFO] [stderr] 385 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 381 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 382 | ElementParameter::TextType(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:387:17 [INFO] [stderr] | [INFO] [stderr] 387 | / match rec.data.get(0) { [INFO] [stderr] 388 | | Some(&RecordData::Bit(x)) => elem.parameters.push( [INFO] [stderr] 389 | | ElementParameter::Presentation(x)), [INFO] [stderr] 390 | | _ => {} [INFO] [stderr] 391 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 387 | if let Some(&RecordData::Bit(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 388 | ElementParameter::Presentation(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | / match rec.data.get(0) { [INFO] [stderr] 394 | | Some(&RecordData::Str(ref x)) => elem.parameters.push( [INFO] [stderr] 395 | | ElementParameter::String(x.clone())), [INFO] [stderr] 396 | | _ => {} [INFO] [stderr] 397 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 393 | if let Some(&RecordData::Str(ref x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 394 | ElementParameter::String(x.clone())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | / match rec.data.get(0) { [INFO] [stderr] 400 | | Some(&RecordData::Bit(x)) => elem.parameters.push( [INFO] [stderr] 401 | | ElementParameter::StrTransf(x)), [INFO] [stderr] 402 | | _ => {} [INFO] [stderr] 403 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 399 | if let Some(&RecordData::Bit(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 400 | ElementParameter::StrTransf(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:405:17 [INFO] [stderr] | [INFO] [stderr] 405 | / match rec.data.get(0) { [INFO] [stderr] 406 | | Some(&RecordData::Real64(x)) => elem.parameters.push( [INFO] [stderr] 407 | | ElementParameter::Magnification(x)), [INFO] [stderr] 408 | | _ => {} [INFO] [stderr] 409 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 405 | if let Some(&RecordData::Real64(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 406 | ElementParameter::Magnification(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | / match rec.data.get(0) { [INFO] [stderr] 412 | | Some(&RecordData::Real64(x)) => elem.parameters.push( [INFO] [stderr] 413 | | ElementParameter::Angle(x)), [INFO] [stderr] 414 | | _ => {} [INFO] [stderr] 415 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 411 | if let Some(&RecordData::Real64(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 412 | ElementParameter::Angle(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | / match rec.data.get(0) { [INFO] [stderr] 418 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 419 | | ElementParameter::Pathtype(x)), [INFO] [stderr] 420 | | _=> {} [INFO] [stderr] 421 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 417 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 418 | ElementParameter::Pathtype(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | / match rec.data.get(0) { [INFO] [stderr] 424 | | Some(&RecordData::Bit(x)) => elem.parameters.push( [INFO] [stderr] 425 | | ElementParameter::EFlags(x)), [INFO] [stderr] 426 | | _ => {} [INFO] [stderr] 427 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 423 | if let Some(&RecordData::Bit(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 424 | ElementParameter::EFlags(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:429:17 [INFO] [stderr] | [INFO] [stderr] 429 | / match rec.data.get(0) { [INFO] [stderr] 430 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 431 | | ElementParameter::Nodetype(x)), [INFO] [stderr] 432 | | _ => {} [INFO] [stderr] 433 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 430 | ElementParameter::Nodetype(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | / match rec.data.get(0) { [INFO] [stderr] 436 | | Some(&RecordData::Int32(x)) => elem.parameters.push( [INFO] [stderr] 437 | | ElementParameter::BeginExt(x)), [INFO] [stderr] 438 | | _ => {} [INFO] [stderr] 439 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 435 | if let Some(&RecordData::Int32(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 436 | ElementParameter::BeginExt(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | / match i { [INFO] [stderr] 577 | | &RecordData::Str(ref x) => self.size += x.len() as u16, [INFO] [stderr] 578 | | _ => {} [INFO] [stderr] 579 | | } [INFO] [stderr] | |_________________^ help: try this: `if let &RecordData::Str(ref x) = i { self.size += x.len() as u16 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | / match i { [INFO] [stderr] 577 | | &RecordData::Str(ref x) => self.size += x.len() as u16, [INFO] [stderr] 578 | | _ => {} [INFO] [stderr] 579 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 576 | match *i { [INFO] [stderr] 577 | RecordData::Str(ref x) => self.size += x.len() as u16, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buffer_arr`. [INFO] [stderr] --> src/lib.rs:613:26 [INFO] [stderr] | [INFO] [stderr] 613 | for i in 0..data_size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 613 | for in buffer_arr.iter_mut().take(data_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | / match d { [INFO] [stderr] 659 | | &RecordData::Bit(x) => buf.extend(utils::u16_to_vec(x)), [INFO] [stderr] 660 | | &RecordData::Int16(x) => buf.extend(utils::i16_to_vec(x)), [INFO] [stderr] 661 | | &RecordData::Int32(x) => buf.extend(utils::i32_to_vec(x)), [INFO] [stderr] ... | [INFO] [stderr] 667 | | _ => {} [INFO] [stderr] 668 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 658 | match *d { [INFO] [stderr] 659 | RecordData::Bit(x) => buf.extend(utils::u16_to_vec(x)), [INFO] [stderr] 660 | RecordData::Int16(x) => buf.extend(utils::i16_to_vec(x)), [INFO] [stderr] 661 | RecordData::Int32(x) => buf.extend(utils::i32_to_vec(x)), [INFO] [stderr] 662 | RecordData::Real32(x) => [INFO] [stderr] 663 | buf.extend(utils::gds_real_32_to_bytes(x).to_vec()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Structure` [INFO] [stderr] --> src/lib.rs:684:5 [INFO] [stderr] | [INFO] [stderr] 684 | / pub fn new() -> Structure { [INFO] [stderr] 685 | | Structure{name: String::from(""), elements: Vec::new(), [INFO] [stderr] 686 | | date_mod: Date::new(), date_acc: Date::new()} [INFO] [stderr] 687 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 675 | impl Default for Structure { [INFO] [stderr] 676 | fn default() -> Self { [INFO] [stderr] 677 | Self::new() [INFO] [stderr] 678 | } [INFO] [stderr] 679 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Element` [INFO] [stderr] --> src/lib.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | / pub fn new() -> Element { [INFO] [stderr] 697 | | Element{element_type: ElementType::None, parameters: Vec::new()} [INFO] [stderr] 698 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 690 | impl Default for Element { [INFO] [stderr] 691 | fn default() -> Self { [INFO] [stderr] 692 | Self::new() [INFO] [stderr] 693 | } [INFO] [stderr] 694 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:718:13 [INFO] [stderr] | [INFO] [stderr] 718 | / match param { [INFO] [stderr] 719 | | &ElementParameter::Layer(x) => res.push(Record::new_single( [INFO] [stderr] 720 | | constants::REC_TYPE_LAYER, constants::DATA_TYPE_INT16, [INFO] [stderr] 721 | | RecordData::Int16(x))), [INFO] [stderr] ... | [INFO] [stderr] 778 | | //TODO more parameters [INFO] [stderr] 779 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 718 | match *param { [INFO] [stderr] 719 | ElementParameter::Layer(x) => res.push(Record::new_single( [INFO] [stderr] 720 | constants::REC_TYPE_LAYER, constants::DATA_TYPE_INT16, [INFO] [stderr] 721 | RecordData::Int16(x))), [INFO] [stderr] 722 | ElementParameter::XY(ref x) => { [INFO] [stderr] 723 | let mut xy_data: Vec = Vec::new(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | -man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | -man*base.powi(exp as i32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Date` [INFO] [stderr] --> src/lib.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / pub fn new() -> Date { [INFO] [stderr] 213 | | Date{year: 1970, month: 1, day: 1, hour: 0, minute: 0, second: 0} [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 61 [INFO] [stderr] --> src/lib.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / pub fn read(s: &str) -> Library { [INFO] [stderr] 240 | | let mut file = File::open(s).unwrap(); [INFO] [stderr] 241 | | let mut version = 0; [INFO] [stderr] 242 | | let mut name: String = String::from(""); [INFO] [stderr] ... | [INFO] [stderr] 449 | | structures: structures} [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d_data` [INFO] [stderr] --> src/lib.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | for i in 0..12 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 257 | for (i, ) in d_data.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d_data` [INFO] [stderr] --> src/lib.rs:290:26 [INFO] [stderr] | [INFO] [stderr] 290 | for i in 0..12 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 290 | for (i, ) in d_data.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:326:17 [INFO] [stderr] | [INFO] [stderr] 326 | / match rec.data.get(0) { [INFO] [stderr] 327 | | Some(&RecordData::Int16(x)) => [INFO] [stderr] 328 | | elem.parameters.push(ElementParameter::Layer(x)), [INFO] [stderr] 329 | | _ => {} [INFO] [stderr] 330 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push(ElementParameter::Layer(x)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:337:21 [INFO] [stderr] | [INFO] [stderr] 337 | / match rec.data.get(c) { [INFO] [stderr] 338 | | Some(&RecordData::Int32(x)) => x_coord = x, [INFO] [stderr] 339 | | _ => {} [INFO] [stderr] 340 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(&RecordData::Int32(x)) = rec.data.get(c) { x_coord = x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:341:21 [INFO] [stderr] | [INFO] [stderr] 341 | / match rec.data.get(c+1) { [INFO] [stderr] 342 | | Some(&RecordData::Int32(x)) => y_coord = x, [INFO] [stderr] 343 | | _ => {} [INFO] [stderr] 344 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(&RecordData::Int32(x)) = rec.data.get(c+1) { y_coord = x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / match rec.data.get(0) { [INFO] [stderr] 351 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 352 | | ElementParameter::Datatype(x)), [INFO] [stderr] 353 | | _ => {} [INFO] [stderr] 354 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 351 | ElementParameter::Datatype(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | / match rec.data.get(0) { [INFO] [stderr] 357 | | Some(&RecordData::Int32(x)) => elem.parameters.push( [INFO] [stderr] 358 | | ElementParameter::Width(x)), [INFO] [stderr] 359 | | _ => {} [INFO] [stderr] 360 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 356 | if let Some(&RecordData::Int32(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 357 | ElementParameter::Width(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | / match rec.data.get(0) { [INFO] [stderr] 363 | | Some(&RecordData::Str(ref x)) => elem.parameters.push( [INFO] [stderr] 364 | | ElementParameter::StructureName(x.clone())), [INFO] [stderr] 365 | | _ => {} [INFO] [stderr] 366 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | if let Some(&RecordData::Str(ref x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 363 | ElementParameter::StructureName(x.clone())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:372:21 [INFO] [stderr] | [INFO] [stderr] 372 | / match rec.data.get(c) { [INFO] [stderr] 373 | | Some(&RecordData::Int16(x)) => colrow = x, [INFO] [stderr] 374 | | _ => {} [INFO] [stderr] 375 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(&RecordData::Int16(x)) = rec.data.get(c) { colrow = x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | / match rec.data.get(0) { [INFO] [stderr] 382 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 383 | | ElementParameter::TextType(x)), [INFO] [stderr] 384 | | _ => {} [INFO] [stderr] 385 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 381 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 382 | ElementParameter::TextType(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:387:17 [INFO] [stderr] | [INFO] [stderr] 387 | / match rec.data.get(0) { [INFO] [stderr] 388 | | Some(&RecordData::Bit(x)) => elem.parameters.push( [INFO] [stderr] 389 | | ElementParameter::Presentation(x)), [INFO] [stderr] 390 | | _ => {} [INFO] [stderr] 391 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 387 | if let Some(&RecordData::Bit(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 388 | ElementParameter::Presentation(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | / match rec.data.get(0) { [INFO] [stderr] 394 | | Some(&RecordData::Str(ref x)) => elem.parameters.push( [INFO] [stderr] 395 | | ElementParameter::String(x.clone())), [INFO] [stderr] 396 | | _ => {} [INFO] [stderr] 397 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 393 | if let Some(&RecordData::Str(ref x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 394 | ElementParameter::String(x.clone())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | / match rec.data.get(0) { [INFO] [stderr] 400 | | Some(&RecordData::Bit(x)) => elem.parameters.push( [INFO] [stderr] 401 | | ElementParameter::StrTransf(x)), [INFO] [stderr] 402 | | _ => {} [INFO] [stderr] 403 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 399 | if let Some(&RecordData::Bit(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 400 | ElementParameter::StrTransf(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:405:17 [INFO] [stderr] | [INFO] [stderr] 405 | / match rec.data.get(0) { [INFO] [stderr] 406 | | Some(&RecordData::Real64(x)) => elem.parameters.push( [INFO] [stderr] 407 | | ElementParameter::Magnification(x)), [INFO] [stderr] 408 | | _ => {} [INFO] [stderr] 409 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 405 | if let Some(&RecordData::Real64(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 406 | ElementParameter::Magnification(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | / match rec.data.get(0) { [INFO] [stderr] 412 | | Some(&RecordData::Real64(x)) => elem.parameters.push( [INFO] [stderr] 413 | | ElementParameter::Angle(x)), [INFO] [stderr] 414 | | _ => {} [INFO] [stderr] 415 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 411 | if let Some(&RecordData::Real64(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 412 | ElementParameter::Angle(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | / match rec.data.get(0) { [INFO] [stderr] 418 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 419 | | ElementParameter::Pathtype(x)), [INFO] [stderr] 420 | | _=> {} [INFO] [stderr] 421 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 417 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 418 | ElementParameter::Pathtype(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | / match rec.data.get(0) { [INFO] [stderr] 424 | | Some(&RecordData::Bit(x)) => elem.parameters.push( [INFO] [stderr] 425 | | ElementParameter::EFlags(x)), [INFO] [stderr] 426 | | _ => {} [INFO] [stderr] 427 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 423 | if let Some(&RecordData::Bit(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 424 | ElementParameter::EFlags(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:429:17 [INFO] [stderr] | [INFO] [stderr] 429 | / match rec.data.get(0) { [INFO] [stderr] 430 | | Some(&RecordData::Int16(x)) => elem.parameters.push( [INFO] [stderr] 431 | | ElementParameter::Nodetype(x)), [INFO] [stderr] 432 | | _ => {} [INFO] [stderr] 433 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(&RecordData::Int16(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 430 | ElementParameter::Nodetype(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | / match rec.data.get(0) { [INFO] [stderr] 436 | | Some(&RecordData::Int32(x)) => elem.parameters.push( [INFO] [stderr] 437 | | ElementParameter::BeginExt(x)), [INFO] [stderr] 438 | | _ => {} [INFO] [stderr] 439 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 435 | if let Some(&RecordData::Int32(x)) = rec.data.get(0) { elem.parameters.push( [INFO] [stderr] 436 | ElementParameter::BeginExt(x)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | / match i { [INFO] [stderr] 577 | | &RecordData::Str(ref x) => self.size += x.len() as u16, [INFO] [stderr] 578 | | _ => {} [INFO] [stderr] 579 | | } [INFO] [stderr] | |_________________^ help: try this: `if let &RecordData::Str(ref x) = i { self.size += x.len() as u16 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | / match i { [INFO] [stderr] 577 | | &RecordData::Str(ref x) => self.size += x.len() as u16, [INFO] [stderr] 578 | | _ => {} [INFO] [stderr] 579 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 576 | match *i { [INFO] [stderr] 577 | RecordData::Str(ref x) => self.size += x.len() as u16, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buffer_arr`. [INFO] [stderr] --> src/lib.rs:613:26 [INFO] [stderr] | [INFO] [stderr] 613 | for i in 0..data_size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 613 | for in buffer_arr.iter_mut().take(data_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | / match d { [INFO] [stderr] 659 | | &RecordData::Bit(x) => buf.extend(utils::u16_to_vec(x)), [INFO] [stderr] 660 | | &RecordData::Int16(x) => buf.extend(utils::i16_to_vec(x)), [INFO] [stderr] 661 | | &RecordData::Int32(x) => buf.extend(utils::i32_to_vec(x)), [INFO] [stderr] ... | [INFO] [stderr] 667 | | _ => {} [INFO] [stderr] 668 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 658 | match *d { [INFO] [stderr] 659 | RecordData::Bit(x) => buf.extend(utils::u16_to_vec(x)), [INFO] [stderr] 660 | RecordData::Int16(x) => buf.extend(utils::i16_to_vec(x)), [INFO] [stderr] 661 | RecordData::Int32(x) => buf.extend(utils::i32_to_vec(x)), [INFO] [stderr] 662 | RecordData::Real32(x) => [INFO] [stderr] 663 | buf.extend(utils::gds_real_32_to_bytes(x).to_vec()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Structure` [INFO] [stderr] --> src/lib.rs:684:5 [INFO] [stderr] | [INFO] [stderr] 684 | / pub fn new() -> Structure { [INFO] [stderr] 685 | | Structure{name: String::from(""), elements: Vec::new(), [INFO] [stderr] 686 | | date_mod: Date::new(), date_acc: Date::new()} [INFO] [stderr] 687 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 675 | impl Default for Structure { [INFO] [stderr] 676 | fn default() -> Self { [INFO] [stderr] 677 | Self::new() [INFO] [stderr] 678 | } [INFO] [stderr] 679 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Element` [INFO] [stderr] --> src/lib.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | / pub fn new() -> Element { [INFO] [stderr] 697 | | Element{element_type: ElementType::None, parameters: Vec::new()} [INFO] [stderr] 698 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 690 | impl Default for Element { [INFO] [stderr] 691 | fn default() -> Self { [INFO] [stderr] 692 | Self::new() [INFO] [stderr] 693 | } [INFO] [stderr] 694 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:718:13 [INFO] [stderr] | [INFO] [stderr] 718 | / match param { [INFO] [stderr] 719 | | &ElementParameter::Layer(x) => res.push(Record::new_single( [INFO] [stderr] 720 | | constants::REC_TYPE_LAYER, constants::DATA_TYPE_INT16, [INFO] [stderr] 721 | | RecordData::Int16(x))), [INFO] [stderr] ... | [INFO] [stderr] 778 | | //TODO more parameters [INFO] [stderr] 779 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 718 | match *param { [INFO] [stderr] 719 | ElementParameter::Layer(x) => res.push(Record::new_single( [INFO] [stderr] 720 | constants::REC_TYPE_LAYER, constants::DATA_TYPE_INT16, [INFO] [stderr] 721 | RecordData::Int16(x))), [INFO] [stderr] 722 | ElementParameter::XY(ref x) => { [INFO] [stderr] 723 | let mut xy_data: Vec = Vec::new(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "4d08de99a94edad8241fa58384f1bc62b97aa96d60e7f1f4006558fec80102f1"` [INFO] running `"docker" "rm" "-f" "4d08de99a94edad8241fa58384f1bc62b97aa96d60e7f1f4006558fec80102f1"` [INFO] [stdout] 4d08de99a94edad8241fa58384f1bc62b97aa96d60e7f1f4006558fec80102f1