[INFO] crate gamemath 0.2.0 is already in cache [INFO] extracting crate gamemath 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/gamemath/0.2.0 [INFO] extracting crate gamemath 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gamemath/0.2.0 [INFO] validating manifest of gamemath-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gamemath-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gamemath-0.2.0 [INFO] finished frobbing gamemath-0.2.0 [INFO] frobbed toml for gamemath-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/gamemath/0.2.0/Cargo.toml [INFO] started frobbing gamemath-0.2.0 [INFO] finished frobbing gamemath-0.2.0 [INFO] frobbed toml for gamemath-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gamemath/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gamemath-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gamemath/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc20260cb912448ea22d3099aa08d97ea11afdee35fad8546718ddd13ee307de [INFO] running `"docker" "start" "-a" "fc20260cb912448ea22d3099aa08d97ea11afdee35fad8546718ddd13ee307de"` [INFO] [stderr] Checking gamemath v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec2.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec2.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn normalized(&self) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mat4.rs:694:20 [INFO] [stderr] | [INFO] [stderr] 694 | fn from(tuple: ((f32, f32, f32, f32), [INFO] [stderr] | ____________________^ [INFO] [stderr] 695 | | (f32, f32, f32, f32), [INFO] [stderr] 696 | | (f32, f32, f32, f32), [INFO] [stderr] 697 | | (f32, f32, f32, f32))) -> Mat4 { [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mat4.rs:708:20 [INFO] [stderr] | [INFO] [stderr] 708 | fn from(tuple: (f32, f32, f32, f32, [INFO] [stderr] | ____________________^ [INFO] [stderr] 709 | | f32, f32, f32, f32, [INFO] [stderr] 710 | | f32, f32, f32, f32, [INFO] [stderr] 711 | | f32, f32, f32, f32)) -> Mat4 { [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/quat.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | *self = *self * Quat::rotation(radians, axis); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*self *= Quat::rotation(radians, axis)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec2.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec2.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn normalized(&self) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mat4.rs:694:20 [INFO] [stderr] | [INFO] [stderr] 694 | fn from(tuple: ((f32, f32, f32, f32), [INFO] [stderr] | ____________________^ [INFO] [stderr] 695 | | (f32, f32, f32, f32), [INFO] [stderr] 696 | | (f32, f32, f32, f32), [INFO] [stderr] 697 | | (f32, f32, f32, f32))) -> Mat4 { [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/mat4.rs:708:20 [INFO] [stderr] | [INFO] [stderr] 708 | fn from(tuple: (f32, f32, f32, f32, [INFO] [stderr] | ____________________^ [INFO] [stderr] 709 | | f32, f32, f32, f32, [INFO] [stderr] 710 | | f32, f32, f32, f32, [INFO] [stderr] 711 | | f32, f32, f32, f32)) -> Mat4 { [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/quat.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | *self = *self * Quat::rotation(radians, axis); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*self *= Quat::rotation(radians, axis)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "fc20260cb912448ea22d3099aa08d97ea11afdee35fad8546718ddd13ee307de"` [INFO] running `"docker" "rm" "-f" "fc20260cb912448ea22d3099aa08d97ea11afdee35fad8546718ddd13ee307de"` [INFO] [stdout] fc20260cb912448ea22d3099aa08d97ea11afdee35fad8546718ddd13ee307de